return 4x4 matrix from SkColorSpace

return 4x4 matrix from SkColorSpace
move SkMatrix44 into core (with alias in utils to transition chrome)

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1943833002

Committed: https://skia.googlesource.com/skia/+/50d3b57c8aaa0f026b981101c45ea30361382940

[reed1, 2016-05-03 12:24:19]

Description was changed from

==========
return 4x4 matrix from SkColorSpace

BUG=skia:
==========

to

==========
return 4x4 matrix from SkColorSpace

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[reed1, 2016-05-03 12:24:57]

reed@google.com changed reviewers:
+ msarett@google.com

[reed1, 2016-05-03 12:25:10]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-03 12:25:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943833002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943833002/1

[commit-bot: I haz the power, 2016-05-03 12:26:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 12:26:48]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)

[msarett, 2016-05-03 13:01:13]

Looks great!

I can see we edited a bunch of the same lines, but I think the logic is mostly
separate.

https://codereview.chromium.org/1943833002/diff/1/tests/ColorSpaceTest.cpp
File tests/ColorSpaceTest.cpp (right):

https://codereview.chromium.org/1943833002/diff/1/tests/ColorSpaceTest.cpp#ne...
tests/ColorSpaceTest.cpp:19: static void test_space(skiatest::Reporter* r,
SkColorSpace* space,
Nice!

https://codereview.chromium.org/1943833002/diff/1/tests/ColorSpaceTest.cpp#ne...
tests/ColorSpaceTest.cpp:30: SkDebugf("\n");
Delete SkDebugf statements?

[reed1, 2016-05-03 13:19:22]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-03 13:19:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943833002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943833002/20001

[reed1, 2016-05-03 13:19:49]

Description was changed from

==========
return 4x4 matrix from SkColorSpace

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
return 4x4 matrix from SkColorSpace
move SkMatrix44 into core (with alias in utils to transition chrome)

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[commit-bot: I haz the power, 2016-05-03 13:22:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 13:22:03]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[reed1, 2016-05-03 13:22:43]

The CQ bit was unchecked by reed@google.com

[reed1, 2016-05-03 13:24:40]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-03 13:24:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943833002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943833002/40001

[commit-bot: I haz the power, 2016-05-03 13:37:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 13:37:30]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[reed1, 2016-05-03 17:44:51]

https://codereview.chromium.org/1943833002/diff/1/tests/ColorSpaceTest.cpp
File tests/ColorSpaceTest.cpp (right):

https://codereview.chromium.org/1943833002/diff/1/tests/ColorSpaceTest.cpp#ne...
tests/ColorSpaceTest.cpp:30: SkDebugf("\n");
On 2016/05/03 13:01:13, msarett wrote:
> Delete SkDebugf statements?

Done.

[msarett, 2016-05-03 17:47:25]

LGTM

[reed1, 2016-05-03 17:50:40]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-03 17:50:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943833002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943833002/80001

[commit-bot: I haz the power, 2016-05-03 17:54:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 17:54:22]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[reed1, 2016-05-03 18:58:25]

The CQ bit was checked by reed@google.com

[reed1, 2016-05-03 18:58:25]

The patchset sent to the CQ was uploaded after l-g-t-m from msarett@google.com
Link to the patchset: https://codereview.chromium.org/1943833002/#ps100001
(title: "fix redirect header")

[commit-bot: I haz the power, 2016-05-03 18:58:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943833002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943833002/100001

[commit-bot: I haz the power, 2016-05-03 19:13:24]

Description was changed from

==========
return 4x4 matrix from SkColorSpace
move SkMatrix44 into core (with alias in utils to transition chrome)

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
return 4x4 matrix from SkColorSpace
move SkMatrix44 into core (with alias in utils to transition chrome)

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/50d3b57c8aaa0f026b981101c45ea30361382940
==========

[commit-bot: I haz the power, 2016-05-03 19:13:25]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/50d3b57c8aaa0f026b981101c45ea30361382940