Chromium Code Reviews Chromium Code Reviews
Issue 1943633002:
[css-flexbox] Add test case for definite widths (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/LayoutTests/css3/flexbox/bug604346.html |
| diff --git a/third_party/WebKit/LayoutTests/css3/flexbox/bug604346.html b/third_party/WebKit/LayoutTests/css3/flexbox/bug604346.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..2e3d4cc01573e07be1521f16a732c870d2fdfae6 |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/css3/flexbox/bug604346.html |
| @@ -0,0 +1,41 @@ |
| +<!DOCTYPE html> |
| + |
| +<style> |
| +.fixed-pos{ |
| + position: fixed; |
| + background: red; |
| +} |
| + |
| +.inner { |
| + width: 100%; |
|
Manuel Rego
2016/05/03 09:53:34
Do we need a similar test to check this for height
|
| + background: green; |
| +} |
| + |
| +.flexbox { |
| + display: flex; |
| +} |
| + |
| +.column { |
| + flex-direction: column; |
| +} |
| +</style> |
| + |
| +You should see no red |
|
Manuel Rego
2016/05/03 09:53:34
Nit: Missing dot at the end.
We usually wrap this
|
| + |
| +<div class="fixed-pos" > |
| + <div class="flexbox column"> |
| + |
| + <div class="flexbox"> |
| + <div class="inner"> |
| + XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX |
|
mstensho (USE GERRIT)
2016/05/03 12:08:52
Trailing whitespace here and elsewhere.
|
| + </div> |
| + </div> |
| + |
| + <div class="flexbox"> |
| + <div class="inner"> |
| + YYYY |
| + </div> |
| + </div> |
| + |
| + </div> |
| +</div> |
