third_party/WebKit/LayoutTests/css3/flexbox/bug604346.html - Issue 1943633002: [css-flexbox] Add test case for definite widths

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/css3/flexbox/bug604346.html

Issue 1943633002: [css-flexbox] Add test case for definite widths (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: with test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2

	3 <style>

	4 .fixed-pos{

	5 position: fixed;

	6 background: red;

	7 }

	8

	9 .inner {

	10 width: 100%;
	Manuel Rego 2016/05/03 09:53:34 Do we need a similar test to check this for height Do we need a similar test to check this for height? Just wondering if we should test this case: + Positioned +-- Flexbox (row) +-- Flexbox (column) +-- Item (height: 100%)
	11 background: green;

	12 }

	13

	14 .flexbox {

	15 display: flex;

	16 }

	17

	18 .column {

	19 flex-direction: column;

	20 }

	21 </style>

	22

	23 You should see no red
	Manuel Rego 2016/05/03 09:53:34 Nit: Missing dot at the end. We usually wrap this Nit: Missing dot at the end. We usually wrap this in a paragraph.
	24

	25 <div class="fixed-pos" >

	26 <div class="flexbox column">

	27

	28 <div class="flexbox">

	29 <div class="inner">

	30 XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
	mstensho (USE GERRIT) 2016/05/03 12:08:52 Trailing whitespace here and elsewhere. Trailing whitespace here and elsewhere.
	31 </div>

	32 </div>

	33

	34 <div class="flexbox">

	35 <div class="inner">

	36 YYYY

	37 </div>

	38 </div>

	39

	40 </div>

	41 </div>

OLD	NEW