Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 1943633002: [css-flexbox] Add test case for definite widths (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: with test Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
index 70e2509cb39ec661154035ac38b7e44ec691b6e9..9188b1f89c6d17c18afdc73830f2f91818ea16b2 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
@@ -4180,6 +4180,7 @@ static bool logicalWidthIsResolvable(const LayoutBox& layoutBox)
const LayoutBox* box = &layoutBox;
while (!box->isLayoutView() && !box->isFloatingOrOutOfFlowPositioned()
&& (box->style()->logicalWidth().isAuto() || box->isAnonymousBlock())
+ && !isStretchingColumnFlexItem(box)
&& !box->hasOverrideContainingBlockLogicalWidth())
box = box->containingBlock();
@@ -4189,6 +4190,8 @@ static bool logicalWidthIsResolvable(const LayoutBox& layoutBox)
return true;
if (box->isOutOfFlowPositioned() && !box->style()->logicalLeft().isAuto() && !box->style()->logicalRight().isAuto())
return true;
+ if (isStretchingColumnFlexItem(box))
mstensho (USE GERRIT) 2016/05/03 12:08:52 logicalWidthIsResolvable(), isn't that about the s
+ return true;
if (box->hasOverrideContainingBlockLogicalWidth())
return box->overrideContainingBlockContentLogicalWidth() != -1;
if (box->style()->logicalWidth().hasPercent())

Powered by Google App Engine
This is Rietveld 408576698