Make it possible to write a message pipe endpoint's peer into it.

Make it possible to write a message pipe endpoint's peer into it.

This is a nonsensical thing to do, but there's no real reason to
disallow it. (Similar nonsense can be achieve anyway.)

This requires a bit of unfortunate plumbing, but maybe it's less
unfortunate than the existing plumbing. (I also need to replace
"DispatcherTransport" with "HandleTransport", which will carry handle
rights.)

R=azani@chromium.org
BUG=fixes #767

Committed: https://chromium.googlesource.com/external/mojo/+/406a5c159c90aa0e9e2bdfa6a456adaf5b9306c4

[azani, 2016-05-03 19:54:27]

lgtm but for a nit.

https://codereview.chromium.org/1943123002/diff/1/mojo/edk/system/dispatcher.h
File mojo/edk/system/dispatcher.h (right):

https://codereview.chromium.org/1943123002/diff/1/mojo/edk/system/dispatcher....
mojo/edk/system/dispatcher.h:264: // produce "close" this dispatcher and return
a new one equivalent to it.
The meaning of "produce 'close' this dispatcher" is hard to understand. Could
you clarify?

[viettrungluu, 2016-05-03 20:27:29]

Description was changed from

==========
Make it possible to write a message pipe endpoint's peer into it.

This is a nonsensical thing to do, but there's no real reason to
disallow it. (Similar nonsense can be achieve anyway.)

This requires a bit of unfortunate plumbing, but maybe it's less
unfortunate than the existing plumbing. (I also need to replace
"DispatcherTransport" with "HandleTransport", which will carry handle
rights.)

R=azani@chromium.org
BUG=fixes #767
==========

to

==========
Make it possible to write a message pipe endpoint's peer into it.

This is a nonsensical thing to do, but there's no real reason to
disallow it. (Similar nonsense can be achieve anyway.)

This requires a bit of unfortunate plumbing, but maybe it's less
unfortunate than the existing plumbing. (I also need to replace
"DispatcherTransport" with "HandleTransport", which will carry handle
rights.)

R=azani@chromium.org
BUG=fixes #767

Committed:
https://chromium.googlesource.com/external/mojo/+/406a5c159c90aa0e9e2bdfa6a45...
==========

[viettrungluu, 2016-05-03 20:27:31]

Committed patchset #1 (id:1) manually as
406a5c159c90aa0e9e2bdfa6a456adaf5b9306c4 (presubmit successful).

[viettrungluu, 2016-05-03 20:28:01]

Thanks.

https://codereview.chromium.org/1943123002/diff/1/mojo/edk/system/dispatcher.h
File mojo/edk/system/dispatcher.h (right):

https://codereview.chromium.org/1943123002/diff/1/mojo/edk/system/dispatcher....
mojo/edk/system/dispatcher.h:264: // produce "close" this dispatcher and return
a new one equivalent to it.
On 2016/05/03 19:54:27, azani wrote:
> The meaning of "produce 'close' this dispatcher" is hard to understand. Could
> you clarify?

Oops, I meant to s/produce // this before landing. Will fix ASAP.