Make it possible to write a message pipe endpoint's peer into it.

mojo/edk/system/message_pipe.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/edk/system/message_pipe.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/logging.h"
@@ skipping 106 matching lines @@
 
 MessagePipeEndpoint::Type MessagePipe::GetType(unsigned port) {
   DCHECK(port == 0 || port == 1);
   MutexLocker locker(&mutex_);
   DCHECK(endpoints_[port]);
 
   return endpoints_[port]->GetType();
 }
 
 void MessagePipe::CancelAllAwakables(unsigned port) {
-  DCHECK(port == 0 || port == 1);
-
   MutexLocker locker(&mutex_);
-  DCHECK(endpoints_[port]);
-  endpoints_[port]->CancelAllAwakables();
+  CancelAllAwakablesNoLock(port);
 }
 
 void MessagePipe::Close(unsigned port) {
   DCHECK(port == 0 || port == 1);
 
   unsigned peer_port = GetPeerPort(port);
 
   MutexLocker locker(&mutex_);
   // The endpoint's |OnPeerClose()| may have been called first and returned
   // false, which would have resulted in its destruction.
@@ skipping 137 matching lines @@
     endpoints_[peer_port].reset();
   }
 
   endpoints_[port]->Close();
   endpoints_[port].reset(replacement_endpoint);
 
   *actual_size = channel->GetSerializedEndpointSize();
   return true;
 }
 
+void MessagePipe::CancelAllAwakablesNoLock(unsigned port) {
+  DCHECK(port == 0 || port == 1);
+  mutex_.AssertHeld();
+  DCHECK(endpoints_[port]);
+  endpoints_[port]->CancelAllAwakables();
+}
+
 bool MessagePipe::OnReadMessage(unsigned port, MessageInTransit* message) {
   MutexLocker locker(&mutex_);
 
   if (!endpoints_[port]) {
     // This will happen only on the rare occasion that the call to
     // |OnReadMessage()| is racing with us calling
     // |ChannelEndpoint::ReplaceClient()|, in which case we reject the message,
     // and the |ChannelEndpoint| can retry (calling the new client's
     // |OnReadMessage()|).
     return false;
@@ skipping 49 matching lines @@
   endpoints_[port]->EnqueueMessage(std::move(message));
   return MOJO_RESULT_OK;
 }
 
 MojoResult MessagePipe::AttachTransportsNoLock(
     unsigned port,
     MessageInTransit* message,
     std::vector<DispatcherTransport>* transports) {
   DCHECK(!message->has_dispatchers());
 
-  // You're not allowed to send either handle to a message pipe over the message
-  // pipe, so check for this. (The case of trying to write a handle to itself is
-  // taken care of by |Core|. That case kind of makes sense, but leads to
-  // complications if, e.g., both sides try to do the same thing with their
-  // respective handles simultaneously. The other case, of trying to write the
-  // peer handle to a handle, doesn't make sense -- since no handle will be
-  // available to read the message from.)
-  for (size_t i = 0; i < transports->size(); i++) {
-    if (!(*transports)[i].is_valid())
-      continue;
-    if ((*transports)[i].GetType() == Dispatcher::Type::MESSAGE_PIPE) {
-      MessagePipeDispatcherTransport mp_transport((*transports)[i]);
-      if (mp_transport.GetMessagePipe() == this) {
-        // The other case should have been disallowed by |Core|. (Note: |port|
-        // is the peer port of the handle given to |WriteMessage()|.)
-        DCHECK_EQ(mp_transport.GetPort(), port);
-        return MOJO_RESULT_INVALID_ARGUMENT;
-      }
-    }
-  }
-
   // Clone the dispatchers and attach them to the message. (This must be done as
   // a separate loop, since we want to leave the dispatchers alone on failure.)
   std::unique_ptr<DispatcherVector> dispatchers(new DispatcherVector());
   dispatchers->reserve(transports->size());
   for (size_t i = 0; i < transports->size(); i++) {
     if ((*transports)[i].is_valid()) {
       dispatchers->push_back(
-          (*transports)[i].CreateEquivalentDispatcherAndClose());
+          (*transports)[i].CreateEquivalentDispatcherAndClose(this, port));
     } else {
       LOG(WARNING) << "Enqueueing null dispatcher";
       dispatchers->push_back(nullptr);
     }
   }
   message->SetDispatchers(std::move(dispatchers));
   return MOJO_RESULT_OK;
 }
 
 }  // namespace system
 }  // namespace mojo