Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1942423002: EDK: Move DispatcherTransport to handle_transport.*. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work789_edk_handle_9
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Move DispatcherTransport to handle_transport.*. I'll rename DispatcherTransport to HandleTransport separately. R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/74b16b5238baedf57a7c04c6716aafe87e155a41

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -53 lines) Patch
M mojo/edk/system/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/core.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/data_pipe_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/dispatcher.h View 1 1 chunk +0 lines, -37 lines 0 comments Download
M mojo/edk/system/dispatcher.cc View 4 chunks +2 lines, -12 lines 0 comments Download
M mojo/edk/system/handle_table.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A mojo/edk/system/handle_transport.h View 1 chunk +59 lines, -0 lines 0 comments Download
A mojo/edk/system/handle_transport.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M mojo/edk/system/ipc_support_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/message_pipe.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/multiprocess_message_pipe_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/platform_handle_dispatcher_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/remote_data_pipe_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/remote_message_pipe_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1946763002 Patch 1

Messages

Total messages: 4 (1 generated)
viettrungluu
(Dependent on https://codereview.chromium.org/1943123002/.)
4 years, 7 months ago (2016-05-03 17:27:49 UTC) #1
azani
lgtm
4 years, 7 months ago (2016-05-03 21:40:41 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-03 21:43:36 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
74b16b5238baedf57a7c04c6716aafe87e155a41 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698