Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1943123002: Make it possible to write a message pipe endpoint's peer into it. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make it possible to write a message pipe endpoint's peer into it. This is a nonsensical thing to do, but there's no real reason to disallow it. (Similar nonsense can be achieve anyway.) This requires a bit of unfortunate plumbing, but maybe it's less unfortunate than the existing plumbing. (I also need to replace "DispatcherTransport" with "HandleTransport", which will carry handle rights.) R=azani@chromium.org BUG=fixes #767 Committed: https://chromium.googlesource.com/external/mojo/+/406a5c159c90aa0e9e2bdfa6a456adaf5b9306c4

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -99 lines) Patch
M mojo/edk/system/core_test_base.cc View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/edk/system/core_unittest.cc View 2 chunks +52 lines, -6 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.h View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.cc View 1 chunk +5 lines, -1 line 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.h View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.cc View 1 chunk +5 lines, -1 line 0 comments Download
M mojo/edk/system/dispatcher.h View 5 chunks +23 lines, -14 lines 2 comments Download
M mojo/edk/system/dispatcher.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M mojo/edk/system/message_pipe.h View 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/edk/system/message_pipe.cc View 4 chunks +9 lines, -26 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.h View 4 chunks +3 lines, -22 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.cc View 2 chunks +14 lines, -10 lines 0 comments Download
M mojo/edk/system/mock_simple_dispatcher.h View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/edk/system/mock_simple_dispatcher.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M mojo/edk/system/platform_handle_dispatcher.h View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/edk/system/platform_handle_dispatcher.cc View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/edk/system/platform_handle_dispatcher_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.h View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.cc View 1 chunk +6 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 5 (1 generated)
viettrungluu
4 years, 7 months ago (2016-05-03 00:13:05 UTC) #1
azani
lgtm but for a nit. https://codereview.chromium.org/1943123002/diff/1/mojo/edk/system/dispatcher.h File mojo/edk/system/dispatcher.h (right): https://codereview.chromium.org/1943123002/diff/1/mojo/edk/system/dispatcher.h#newcode264 mojo/edk/system/dispatcher.h:264: // produce "close" this ...
4 years, 7 months ago (2016-05-03 19:54:27 UTC) #2
viettrungluu
Committed patchset #1 (id:1) manually as 406a5c159c90aa0e9e2bdfa6a456adaf5b9306c4 (presubmit successful).
4 years, 7 months ago (2016-05-03 20:27:31 UTC) #4
viettrungluu
4 years, 7 months ago (2016-05-03 20:28:01 UTC) #5
Message was sent while issue was closed.
Thanks.

https://codereview.chromium.org/1943123002/diff/1/mojo/edk/system/dispatcher.h
File mojo/edk/system/dispatcher.h (right):

https://codereview.chromium.org/1943123002/diff/1/mojo/edk/system/dispatcher....
mojo/edk/system/dispatcher.h:264: // produce "close" this dispatcher and return
a new one equivalent to it.
On 2016/05/03 19:54:27, azani wrote:
> The meaning of "produce 'close' this dispatcher" is hard to understand. Could
> you clarify?

Oops, I meant to s/produce // this before landing. Will fix ASAP.

Powered by Google App Engine
This is Rietveld 408576698