Remove all uses of skia::RefPtr and stale includes

Remove all uses of skia::RefPtr and stale includes

This CL is the Ozone-specific section of the change.

Finish deprecating skia::RefPtr in favor of sk_sp<>.
This should significantly reduce the amount of manual reference
management Chromium and Blink authors need to do for Skia objects.

We still have some APIs vending raw pointers to ref-counted Skia
objects which will need to be wrapped in sk_sp<>, but that should
be easier and more predictable. This CL does *not* try to remove
all cases of raw pointers to Skia objects in Chromium.

R=fmalita@chromium.org,spang@chromium.org
BUG=skia:5707, 604716
Committed: https://crrev.com/71c5554872e1b2094a1c3bddbc5a520040d2607a
Cr-Commit-Position: refs/heads/master@{#391231}

[tomhudson, 2016-05-02 19:21:35]

The CQ bit was checked by tomhudson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-02 19:21:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1942973002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1942973002/1

[tomhudson, 2016-05-02 19:51:57]

Florin: Skia reviewer.
spang@: please review ui/ozone/.

[f(malita), 2016-05-02 20:15:47]

Non-owner LGTM.

https://codereview.chromium.org/1942973002/diff/20001/ui/ozone/platform/caca/...
File ui/ozone/platform/caca/caca_window_manager.cc (right):

https://codereview.chromium.org/1942973002/diff/20001/ui/ozone/platform/caca/...
ui/ozone/platform/caca/caca_window_manager.cc:32: sk_sp<SkSurface> GetSurface()
override;
Hmm, I see the base class signature has already been updated to sk_sp - I
presume this code is not being built currently?

[tomhudson, 2016-05-02 20:20:01]

https://codereview.chromium.org/1942973002/diff/20001/ui/ozone/platform/caca/...
File ui/ozone/platform/caca/caca_window_manager.cc (right):

https://codereview.chromium.org/1942973002/diff/20001/ui/ozone/platform/caca/...
ui/ozone/platform/caca/caca_window_manager.cc:32: sk_sp<SkSurface> GetSurface()
override;
On 2016/05/02 20:15:47, f(malita) wrote:
> Hmm, I see the base class signature has already been updated to sk_sp - I
> presume this code is not being built currently?

Either I broke something 3 weeks ago in
https://codereview.chromium.org/1855273002 and we never noticed, or the compiler
has magically been working around that.

[spang, 2016-05-02 21:00:37]

lgtm

https://codereview.chromium.org/1942973002/diff/20001/ui/ozone/platform/caca/...
File ui/ozone/platform/caca/caca_window_manager.cc (right):

https://codereview.chromium.org/1942973002/diff/20001/ui/ozone/platform/caca/...
ui/ozone/platform/caca/caca_window_manager.cc:32: sk_sp<SkSurface> GetSurface()
override;
On 2016/05/02 20:20:01, tomhudson wrote:
> On 2016/05/02 20:15:47, f(malita) wrote:
> > Hmm, I see the base class signature has already been updated to sk_sp - I
> > presume this code is not being built currently?
> 
> Either I broke something 3 weeks ago in
> https://codereview.chromium.org/1855273002 and we never noticed, or the
compiler
> has magically been working around that.

No magic; the build of this platform is indeed currently broken for this and 1
other issue. This patch does fix it - thanks!

This is sample code; it does not ship.

[tomhudson, 2016-05-03 13:26:53]

The CQ bit was checked by tomhudson@google.com

[commit-bot: I haz the power, 2016-05-03 13:27:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1942973002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1942973002/20001

[commit-bot: I haz the power, 2016-05-03 14:01:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 14:01:22]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tomhudson, 2016-05-03 14:08:50]

The CQ bit was checked by tomhudson@google.com

[tomhudson, 2016-05-03 14:08:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
fmalita@chromium.org, spang@chromium.org
Link to the patchset: https://codereview.chromium.org/1942973002/#ps40001
(title: "trybots missed one missing include?")

[commit-bot: I haz the power, 2016-05-03 14:09:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1942973002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1942973002/40001

[commit-bot: I haz the power, 2016-05-03 14:41:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-03 14:43:39]

Description was changed from

==========
Remove all uses of skia::RefPtr and stale includes

This CL is the Ozone-specific section of the change.

Finish deprecating skia::RefPtr in favor of sk_sp<>.
This should significantly reduce the amount of manual reference
management Chromium and Blink authors need to do for Skia objects.

We still have some APIs vending raw pointers to ref-counted Skia
objects which will need to be wrapped in sk_sp<>, but that should
be easier and more predictable. This CL does *not* try to remove
all cases of raw pointers to Skia objects in Chromium.

R=fmalita@chromium.org,spang@chromium.org
BUG=skia:5707,604716
==========

to

==========
Remove all uses of skia::RefPtr and stale includes

This CL is the Ozone-specific section of the change.

Finish deprecating skia::RefPtr in favor of sk_sp<>.
This should significantly reduce the amount of manual reference
management Chromium and Blink authors need to do for Skia objects.

We still have some APIs vending raw pointers to ref-counted Skia
objects which will need to be wrapped in sk_sp<>, but that should
be easier and more predictable. This CL does *not* try to remove
all cases of raw pointers to Skia objects in Chromium.

R=fmalita@chromium.org,spang@chromium.org
BUG=skia:5707,604716

Committed: https://crrev.com/71c5554872e1b2094a1c3bddbc5a520040d2607a
Cr-Commit-Position: refs/heads/master@{#391231}
==========

[commit-bot: I haz the power, 2016-05-03 14:43:40]

Patchset 3 (id:??) landed as
https://crrev.com/71c5554872e1b2094a1c3bddbc5a520040d2607a
Cr-Commit-Position: refs/heads/master@{#391231}