media/gpu/ipc/service/gpu_video_decode_accelerator.cc - Issue 1942123002: Plumb decoded video pixel format from GPU process to renderer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/gpu/ipc/service/gpu_video_decode_accelerator.cc

Issue 1942123002: Plumb decoded video pixel format from GPU process to renderer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/gpu/dxva_video_decode_accelerator_win.cc ('K') | « media/gpu/ipc/service/gpu_video_decode_accelerator.h ('k') | media/gpu/v4l2_slice_video_decode_accelerator.h » ('j') | media/gpu/v4l2_slice_video_decode_accelerator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/gpu/ipc/service/gpu_video_decode_accelerator.cc

diff --git a/media/gpu/ipc/service/gpu_video_decode_accelerator.cc b/media/gpu/ipc/service/gpu_video_decode_accelerator.cc

index 1608127c7bf59756ba0ffda93670269a0bbf3b42..09c3129e38f126e0424ed0ba42698dfc1f86831d 100644

--- a/media/gpu/ipc/service/gpu_video_decode_accelerator.cc

+++ b/media/gpu/ipc/service/gpu_video_decode_accelerator.cc

@@ -219,6 +219,7 @@ void GpuVideoDecodeAccelerator::NotifyInitializationComplete(bool success) {

void GpuVideoDecodeAccelerator::ProvidePictureBuffers(

uint32_t requested_num_of_buffers,

+ VideoPixelFormat format,

uint32_t textures_per_buffer,

const gfx::Size& dimensions,

uint32_t texture_target) {

@@ -229,7 +230,7 @@ void GpuVideoDecodeAccelerator::ProvidePictureBuffers(

return;

}

if (!Send(new AcceleratedVideoDecoderHostMsg_ProvidePictureBuffers(

- host_route_id_, requested_num_of_buffers, textures_per_buffer,

+ host_route_id_, format, requested_num_of_buffers, textures_per_buffer,

dimensions, texture_target))) {

DLOG(ERROR) << "Send(AcceleratedVideoDecoderHostMsg_ProvidePictureBuffers) "

<< "failed";