Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: media/gpu/v4l2_slice_video_decode_accelerator.cc

Issue 1942123002: Plumb decoded video pixel format from GPU process to renderer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/gpu/v4l2_slice_video_decode_accelerator.cc
diff --git a/media/gpu/v4l2_slice_video_decode_accelerator.cc b/media/gpu/v4l2_slice_video_decode_accelerator.cc
index 1b4cce7b48ce7ff45f58c41109a2c508bd619dd6..a0b2f5ee6098df40319bf560eef58f2a108c566f 100644
--- a/media/gpu/v4l2_slice_video_decode_accelerator.cc
+++ b/media/gpu/v4l2_slice_video_decode_accelerator.cc
@@ -754,10 +754,15 @@ bool V4L2SliceVideoDecodeAccelerator::CreateOutputBuffers() {
<< ", visible size=" << visible_size_.ToString()
<< ", coded size=" << coded_size_.ToString();
+ DCHECK(output_format_fourcc_);
Pawel Osciak 2016/05/18 07:32:31 This should not be needed, we'd fail S_FMT for 0.
+
+ VideoPixelFormat pixel_format =
+ V4L2Device::V4L2PixFmtToVideoPixelFormat(output_format_fourcc_);
+
child_task_runner_->PostTask(
FROM_HERE,
base::Bind(&VideoDecodeAccelerator::Client::ProvidePictureBuffers,
- client_, num_pictures, 1, coded_size_,
+ client_, num_pictures, pixel_format, 1, coded_size_,
device_->GetTextureTarget()));
// Go into kAwaitingPictureBuffers to prevent us from doing any more decoding
@@ -2795,11 +2800,6 @@ bool V4L2SliceVideoDecodeAccelerator::TryToSetupDecodeOnSeparateThread(
return true;
}
-media::VideoPixelFormat V4L2SliceVideoDecodeAccelerator::GetOutputFormat()
- const {
- return V4L2Device::V4L2PixFmtToVideoPixelFormat(output_format_fourcc_);
-}
-
// static
media::VideoDecodeAccelerator::SupportedProfiles
V4L2SliceVideoDecodeAccelerator::GetSupportedProfiles() {

Powered by Google App Engine
This is Rietveld 408576698