media/gpu/dxva_video_decode_accelerator_win.cc - Issue 1942123002: Plumb decoded video pixel format from GPU process to renderer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/gpu/dxva_video_decode_accelerator_win.cc

Issue 1942123002: Plumb decoded video pixel format from GPU process to renderer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/filters/gpu_video_decoder.cc ('K') | « media/gpu/android_video_decode_accelerator_unittest.cc ('k') | media/gpu/fake_video_decode_accelerator.cc » ('j') | media/gpu/v4l2_slice_video_decode_accelerator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/gpu/dxva_video_decode_accelerator_win.cc

diff --git a/media/gpu/dxva_video_decode_accelerator_win.cc b/media/gpu/dxva_video_decode_accelerator_win.cc

index 01ac4d322579dccd3d97728f162be5bf83d6d463..7a5b49ac299ade868add2bbbf5cc1a324fe8fd24 100644

--- a/media/gpu/dxva_video_decode_accelerator_win.cc

+++ b/media/gpu/dxva_video_decode_accelerator_win.cc

@@ -1881,8 +1881,9 @@ void DXVAVideoDecodeAccelerator::RequestPictureBuffers(int width, int height) {

// They're shared to ANGLE using EGL_NV_stream_consumer_gltexture_yuv, so

// they need to be GL_TEXTURE_EXTERNAL_OES.

client_->ProvidePictureBuffers(

- kNumPictureBuffers, share_nv12_textures_ ? 2 : 1,

- gfx::Size(width, height),

+ kNumPictureBuffers,

+ share_nv12_textures_ ? PIXEL_FORMAT_NV12 : PIXEL_FORMAT_UNKNOWN,

Pawel Osciak 2016/05/18 07:32:31 Should we report RGBA instead of UNKNOWN in genera

+ share_nv12_textures_ ? 2 : 1, gfx::Size(width, height),

share_nv12_textures_ ? GL_TEXTURE_EXTERNAL_OES : GL_TEXTURE_2D);

}