Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 19417002: Move ICU header part 2 (Closed)

Created:
7 years, 5 months ago by jungshik at Google
Modified:
7 years, 5 months ago
Reviewers:
cpu_(ooo_6.6-7.5), mark
CC:
chromium-reviews
Visibility:
Public.

Description

Move ICU header part 2 Move public/i18n/unicode to source/i18n/unicode, delete public/{common,i18n}. Update icu.gyp accordingly. This move is done in stages to work around a problem with gcl handling a large patch. All-in-one patch was approved at https://codereview.chromium.org/18836004/ The upstream has headers in source/{common,i18n}/unicode. With Blink's ICU headers removed, there's no need to keep them in a location different than the upstream. Future ICU updates will be a bit more streamlined. v8 also likes to have this change. The Chrome-side of change is at http://codereview.chromium.org/18252003 This revision will be rolled in along with the global replacements of include-references to ICU headers and DEPS changes. See also http://crbug.com/232922 where ICU headers in Blink are removed. BUG=251433 TEST=NONE for now. TBR=mark,cpu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211848

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -42383 lines) Patch
M icu.gyp View 1 5 chunks +10 lines, -26 lines 0 comments Download
D public/i18n/unicode/basictz.h View 1 1 chunk +0 lines, -210 lines 0 comments Download
D public/i18n/unicode/bms.h View 1 1 chunk +0 lines, -274 lines 0 comments Download
D public/i18n/unicode/bmsearch.h View 1 1 chunk +0 lines, -226 lines 0 comments Download
D public/i18n/unicode/calendar.h View 1 1 chunk +0 lines, -2252 lines 0 comments Download
D public/i18n/unicode/choicfmt.h View 1 1 chunk +0 lines, -749 lines 0 comments Download
D public/i18n/unicode/coleitr.h View 1 1 chunk +0 lines, -400 lines 0 comments Download
D public/i18n/unicode/coll.h View 1 1 chunk +0 lines, -1113 lines 0 comments Download
D public/i18n/unicode/colldata.h View 1 1 chunk +0 lines, -452 lines 0 comments Download
D public/i18n/unicode/curramt.h View 1 1 chunk +0 lines, -130 lines 0 comments Download
D public/i18n/unicode/currpinf.h View 1 1 chunk +0 lines, -259 lines 0 comments Download
D public/i18n/unicode/currunit.h View 1 1 chunk +0 lines, -117 lines 0 comments Download
D public/i18n/unicode/datefmt.h View 1 1 chunk +0 lines, -751 lines 0 comments Download
D public/i18n/unicode/dcfmtsym.h View 1 1 chunk +0 lines, -460 lines 0 comments Download
D public/i18n/unicode/decimfmt.h View 1 1 chunk +0 lines, -2310 lines 0 comments Download
D public/i18n/unicode/dtfmtsym.h View 1 1 chunk +0 lines, -755 lines 0 comments Download
D public/i18n/unicode/dtitvfmt.h View 1 1 chunk +0 lines, -970 lines 0 comments Download
D public/i18n/unicode/dtitvinf.h View 1 1 chunk +0 lines, -527 lines 0 comments Download
D public/i18n/unicode/dtptngen.h View 1 1 chunk +0 lines, -474 lines 0 comments Download
D public/i18n/unicode/dtrule.h View 1 1 chunk +0 lines, -250 lines 0 comments Download
D public/i18n/unicode/fieldpos.h View 1 1 chunk +0 lines, -291 lines 0 comments Download
D public/i18n/unicode/fmtable.h View 1 1 chunk +0 lines, -673 lines 0 comments Download
D public/i18n/unicode/format.h View 1 1 chunk +0 lines, -303 lines 0 comments Download
D public/i18n/unicode/fpositer.h View 1 1 chunk +0 lines, -120 lines 0 comments Download
D public/i18n/unicode/gregocal.h View 1 1 chunk +0 lines, -823 lines 0 comments Download
D public/i18n/unicode/locdspnm.h View 1 1 chunk +0 lines, -188 lines 0 comments Download
D public/i18n/unicode/measfmt.h View 1 1 chunk +0 lines, -77 lines 0 comments Download
D public/i18n/unicode/measunit.h View 1 1 chunk +0 lines, -71 lines 0 comments Download
D public/i18n/unicode/measure.h View 1 1 chunk +0 lines, -137 lines 0 comments Download
D public/i18n/unicode/msgfmt.h View 1 1 chunk +0 lines, -961 lines 0 comments Download
D public/i18n/unicode/numfmt.h View 1 1 chunk +0 lines, -1051 lines 0 comments Download
D public/i18n/unicode/numsys.h View 1 1 chunk +0 lines, -191 lines 0 comments Download
D public/i18n/unicode/plurfmt.h View 1 1 chunk +0 lines, -549 lines 0 comments Download
D public/i18n/unicode/plurrule.h View 1 1 chunk +0 lines, -299 lines 0 comments Download
D public/i18n/unicode/rbnf.h View 1 1 chunk +0 lines, -1059 lines 0 comments Download
D public/i18n/unicode/rbtz.h View 1 1 chunk +0 lines, -361 lines 0 comments Download
D public/i18n/unicode/regex.h View 1 1 chunk +0 lines, -1772 lines 0 comments Download
D public/i18n/unicode/search.h View 1 1 chunk +0 lines, -569 lines 0 comments Download
D public/i18n/unicode/selfmt.h View 1 1 chunk +0 lines, -377 lines 0 comments Download
D public/i18n/unicode/simpletz.h View 1 1 chunk +0 lines, -927 lines 0 comments Download
D public/i18n/unicode/smpdtfmt.h View 1 1 chunk +0 lines, -1207 lines 0 comments Download
D public/i18n/unicode/sortkey.h View 1 1 chunk +0 lines, -324 lines 0 comments Download
D public/i18n/unicode/stsearch.h View 1 1 chunk +0 lines, -518 lines 0 comments Download
D public/i18n/unicode/tblcoll.h View 1 1 chunk +0 lines, -966 lines 0 comments Download
D public/i18n/unicode/timezone.h View 1 1 chunk +0 lines, -777 lines 0 comments Download
D public/i18n/unicode/tmunit.h View 1 1 chunk +0 lines, -149 lines 0 comments Download
D public/i18n/unicode/tmutamt.h View 1 1 chunk +0 lines, -168 lines 0 comments Download
D public/i18n/unicode/tmutfmt.h View 1 1 chunk +0 lines, -272 lines 0 comments Download
D public/i18n/unicode/translit.h View 1 1 chunk +0 lines, -1320 lines 0 comments Download
D public/i18n/unicode/tzrule.h View 1 1 chunk +0 lines, -828 lines 0 comments Download
D public/i18n/unicode/tztrans.h View 1 1 chunk +0 lines, -195 lines 0 comments Download
D public/i18n/unicode/ucal.h View 1 1 chunk +0 lines, -1285 lines 0 comments Download
D public/i18n/unicode/ucol.h View 1 1 chunk +0 lines, -1227 lines 0 comments Download
D public/i18n/unicode/ucoleitr.h View 1 1 chunk +0 lines, -330 lines 0 comments Download
D public/i18n/unicode/ucsdet.h View 1 1 chunk +0 lines, -370 lines 0 comments Download
D public/i18n/unicode/ucurr.h View 1 1 chunk +0 lines, -316 lines 0 comments Download
D public/i18n/unicode/udat.h View 1 1 chunk +0 lines, -997 lines 0 comments Download
D public/i18n/unicode/udatpg.h View 1 1 chunk +0 lines, -586 lines 0 comments Download
D public/i18n/unicode/uldnames.h View 1 1 chunk +0 lines, -270 lines 0 comments Download
D public/i18n/unicode/ulocdata.h View 1 1 chunk +0 lines, -263 lines 0 comments Download
D public/i18n/unicode/umsg.h View 1 1 chunk +0 lines, -709 lines 0 comments Download
D public/i18n/unicode/unirepl.h View 1 1 chunk +0 lines, -97 lines 0 comments Download
D public/i18n/unicode/unum.h View 1 1 chunk +0 lines, -999 lines 0 comments Download
D public/i18n/unicode/uregex.h View 1 1 chunk +0 lines, -1451 lines 0 comments Download
D public/i18n/unicode/usearch.h View 1 1 chunk +0 lines, -829 lines 0 comments Download
D public/i18n/unicode/uspoof.h View 1 1 chunk +0 lines, -887 lines 0 comments Download
D public/i18n/unicode/utmscale.h View 1 1 chunk +0 lines, -481 lines 0 comments Download
D public/i18n/unicode/utrans.h View 1 1 chunk +0 lines, -603 lines 0 comments Download
D public/i18n/unicode/vtzone.h View 1 1 chunk +0 lines, -455 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jungshik at Google
7 years, 5 months ago (2013-07-16 21:23:19 UTC) #1
Message was sent while issue was closed.
Committed patchset #2 manually as r211848 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698