Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: chrome/browser/extensions/api/storage/policy_value_store_unittest.cc

Issue 1940133002: Use std::unique_ptr to transfer base::Value ownership in extensions::ValueStoreChange (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/storage/syncable_settings_storage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/storage/policy_value_store_unittest.cc
diff --git a/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc b/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc
index c74035852927c002aef9cc33e13f6c7e599be74f..de089d4523355f0e5a9572855f79c40ae69c3edb 100644
--- a/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc
+++ b/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc
@@ -161,7 +161,7 @@ TEST_F(PolicyValueStoreTest, NotifyOnChanges) {
const base::StringValue value("111");
{
ValueStoreChangeList changes;
- changes.push_back(ValueStoreChange("aaa", NULL, value.DeepCopy()));
+ changes.push_back(ValueStoreChange("aaa", nullptr, value.CreateDeepCopy()));
EXPECT_CALL(observer_,
OnSettingsChanged(kTestExtensionId,
settings_namespace::MANAGED,
@@ -178,7 +178,7 @@ TEST_F(PolicyValueStoreTest, NotifyOnChanges) {
// Notify when new policies are added.
{
ValueStoreChangeList changes;
- changes.push_back(ValueStoreChange("bbb", NULL, value.DeepCopy()));
+ changes.push_back(ValueStoreChange("bbb", nullptr, value.CreateDeepCopy()));
EXPECT_CALL(observer_,
OnSettingsChanged(kTestExtensionId,
settings_namespace::MANAGED,
@@ -195,8 +195,8 @@ TEST_F(PolicyValueStoreTest, NotifyOnChanges) {
const base::StringValue new_value("222");
{
ValueStoreChangeList changes;
- changes.push_back(
- ValueStoreChange("bbb", value.DeepCopy(), new_value.DeepCopy()));
+ changes.push_back(ValueStoreChange("bbb", value.CreateDeepCopy(),
+ new_value.CreateDeepCopy()));
EXPECT_CALL(observer_,
OnSettingsChanged(kTestExtensionId,
settings_namespace::MANAGED,
@@ -212,7 +212,8 @@ TEST_F(PolicyValueStoreTest, NotifyOnChanges) {
// Notify when policies are removed.
{
ValueStoreChangeList changes;
- changes.push_back(ValueStoreChange("bbb", new_value.DeepCopy(), NULL));
+ changes.push_back(
+ ValueStoreChange("bbb", new_value.CreateDeepCopy(), nullptr));
EXPECT_CALL(observer_,
OnSettingsChanged(kTestExtensionId,
settings_namespace::MANAGED,
« no previous file with comments | « no previous file | chrome/browser/extensions/api/storage/syncable_settings_storage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698