Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: chrome/browser/extensions/api/storage/syncable_settings_storage.h

Issue 1940133002: Use std::unique_ptr to transfer base::Value ownership in extensions::ValueStoreChange (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/storage/syncable_settings_storage.h
diff --git a/chrome/browser/extensions/api/storage/syncable_settings_storage.h b/chrome/browser/extensions/api/storage/syncable_settings_storage.h
index c49b49e38235594405a36541c8a76ad94714903c..24456e15f6ee481dc0a1833b7fe507db614ae5a2 100644
--- a/chrome/browser/extensions/api/storage/syncable_settings_storage.h
+++ b/chrome/browser/extensions/api/storage/syncable_settings_storage.h
@@ -98,21 +98,17 @@ class SyncableSettingsStorage : public ValueStore {
std::unique_ptr<base::DictionaryValue> sync_state,
std::unique_ptr<base::DictionaryValue> local_state);
- // Called when an Add/Update/Remove comes from sync. Ownership of Value*s
- // are taken.
- syncer::SyncError OnSyncAdd(
- const std::string& key,
- base::Value* new_value,
- ValueStoreChangeList* changes);
- syncer::SyncError OnSyncUpdate(
- const std::string& key,
- base::Value* old_value,
- base::Value* new_value,
- ValueStoreChangeList* changes);
- syncer::SyncError OnSyncDelete(
- const std::string& key,
- base::Value* old_value,
- ValueStoreChangeList* changes);
+ // Called when an Add/Update/Remove comes from sync.
+ syncer::SyncError OnSyncAdd(const std::string& key,
+ std::unique_ptr<base::Value> new_value,
+ ValueStoreChangeList* changes);
+ syncer::SyncError OnSyncUpdate(const std::string& key,
+ std::unique_ptr<base::Value> old_value,
+ std::unique_ptr<base::Value> new_value,
+ ValueStoreChangeList* changes);
+ syncer::SyncError OnSyncDelete(const std::string& key,
+ std::unique_ptr<base::Value> old_value,
+ ValueStoreChangeList* changes);
// List of observers to settings changes.
const scoped_refptr<SettingsObserverList> observers_;

Powered by Google App Engine
This is Rietveld 408576698