Use std::unique_ptr to transfer base::Value ownership in extensions::ValueStoreChange

chrome/browser/extensions/api/storage/policy_value_store_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/storage/policy_value_store.h"
 
 #include <memory>
 
 #include "base/callback.h"
 #include "base/files/file_path.h"
@@ skipping 143 matching lines @@
   keys.push_back("key");
   EXPECT_FALSE(store_->Remove(keys)->status().ok());
   EXPECT_FALSE(store_->Clear()->status().ok());
 }
 
 TEST_F(PolicyValueStoreTest, NotifyOnChanges) {
   // Notify when setting the initial policy.
   const base::StringValue value("111");
   {
     ValueStoreChangeList changes;
-    changes.push_back(ValueStoreChange("aaa", NULL, value.DeepCopy()));
+    changes.push_back(ValueStoreChange("aaa", nullptr, value.CreateDeepCopy()));
     EXPECT_CALL(observer_,
                 OnSettingsChanged(kTestExtensionId,
                                   settings_namespace::MANAGED,
                                   ValueStoreChange::ToJson(changes)));
   }
 
   policy::PolicyMap policies;
   policies.Set("aaa", policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
                policy::POLICY_SOURCE_CLOUD, value.DeepCopy(), nullptr);
   store_->SetCurrentPolicy(policies);
   loop_.RunUntilIdle();
   Mock::VerifyAndClearExpectations(&observer_);
 
   // Notify when new policies are added.
   {
     ValueStoreChangeList changes;
-    changes.push_back(ValueStoreChange("bbb", NULL, value.DeepCopy()));
+    changes.push_back(ValueStoreChange("bbb", nullptr, value.CreateDeepCopy()));
     EXPECT_CALL(observer_,
                 OnSettingsChanged(kTestExtensionId,
                                   settings_namespace::MANAGED,
                                   ValueStoreChange::ToJson(changes)));
   }
 
   policies.Set("bbb", policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
                policy::POLICY_SOURCE_CLOUD, value.DeepCopy(), nullptr);
   store_->SetCurrentPolicy(policies);
   loop_.RunUntilIdle();
   Mock::VerifyAndClearExpectations(&observer_);
 
   // Notify when policies change.
   const base::StringValue new_value("222");
   {
     ValueStoreChangeList changes;
-    changes.push_back(
-        ValueStoreChange("bbb", value.DeepCopy(), new_value.DeepCopy()));
+    changes.push_back(ValueStoreChange("bbb", value.CreateDeepCopy(),
+                                       new_value.CreateDeepCopy()));
     EXPECT_CALL(observer_,
                 OnSettingsChanged(kTestExtensionId,
                                   settings_namespace::MANAGED,
                                   ValueStoreChange::ToJson(changes)));
   }
 
   policies.Set("bbb", policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
                policy::POLICY_SOURCE_CLOUD, new_value.DeepCopy(), nullptr);
   store_->SetCurrentPolicy(policies);
   loop_.RunUntilIdle();
   Mock::VerifyAndClearExpectations(&observer_);
 
   // Notify when policies are removed.
   {
     ValueStoreChangeList changes;
-    changes.push_back(ValueStoreChange("bbb", new_value.DeepCopy(), NULL));
+    changes.push_back(
+        ValueStoreChange("bbb", new_value.CreateDeepCopy(), nullptr));
     EXPECT_CALL(observer_,
                 OnSettingsChanged(kTestExtensionId,
                                   settings_namespace::MANAGED,
                                   ValueStoreChange::ToJson(changes)));
   }
 
   policies.Erase("bbb");
   store_->SetCurrentPolicy(policies);
   loop_.RunUntilIdle();
   Mock::VerifyAndClearExpectations(&observer_);
 
   // Don't notify when there aren't any changes.
   EXPECT_CALL(observer_, OnSettingsChanged(_, _, _)).Times(0);
   store_->SetCurrentPolicy(policies);
   loop_.RunUntilIdle();
   Mock::VerifyAndClearExpectations(&observer_);
 }
 
 }  // namespace extensions