Use std::unique_ptr to transfer base::Value ownership in extensions::ValueStoreChange

Use std::unique_ptr to transfer base::Value ownership in extensions::ValueStoreChange

BUG=581865
Committed: https://crrev.com/a226db909b0c5ec72eff20cc9b1ff8eed69145a8
Cr-Commit-Position: refs/heads/master@{#391322}

[dcheng, 2016-05-03 06:11:18]

Description was changed from

==========
Moo


Meh

BUG=
==========

to

==========
Use std::unique_ptr to hold base::Value in extensions::ValueStoreChange.

BUG=581865
==========

[dcheng, 2016-05-03 06:11:18]

dcheng@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[dcheng, 2016-05-03 06:11:55]

Description was changed from

==========
Use std::unique_ptr to hold base::Value in extensions::ValueStoreChange.

BUG=581865
==========

to

==========
Use std::unique_ptr to express ownership in extensions::ValueStoreChange.

BUG=581865
==========

[dcheng, 2016-05-03 06:13:01]

Description was changed from

==========
Use std::unique_ptr to express ownership in extensions::ValueStoreChange.

BUG=581865
==========

to

==========
Use std::unique_ptr to transfer base::Value ownership in
extensions::ValueStoreChange

BUG=581865
==========

[dcheng, 2016-05-03 06:15:14]

Part of the work to switch away from deprecated base::Value functions.

The long-term plan is to make base::Value movable: the indirection through
std::unique_ptr doesn't really add much value and usually just makes things much
more verbose.

[Devlin, 2016-05-03 16:55:05]

On 2016/05/03 06:15:14, dcheng wrote:
> Part of the work to switch away from deprecated base::Value functions.
> 
> The long-term plan is to make base::Value movable: the indirection through
> std::unique_ptr doesn't really add much value and usually just makes things
much
> more verbose.

+1, especially since we already provide the Swap() functionality, I'd love to
just be able to std::move() them.

LGTM

https://codereview.chromium.org/1940133002/diff/40001/extensions/browser/valu...
File extensions/browser/value_store/value_store_unittest.cc (right):

https://codereview.chromium.org/1940133002/diff/40001/extensions/browser/valu...
extensions/browser/value_store/value_store_unittest.cc:390:
inner_dict->SetString("bar", "baz");
UAF (was already a conceptual problem, but now this will crash).

[dcheng, 2016-05-03 17:16:25]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-05-03 17:16:26]

https://codereview.chromium.org/1940133002/diff/40001/extensions/browser/valu...
File extensions/browser/value_store/value_store_unittest.cc (right):

https://codereview.chromium.org/1940133002/diff/40001/extensions/browser/valu...
extensions/browser/value_store/value_store_unittest.cc:390:
inner_dict->SetString("bar", "baz");
On 2016/05/03 at 16:55:05, Devlin wrote:
> UAF (was already a conceptual problem, but now this will crash).

Done. This was "safe" before but is now unsafe.

[dcheng, 2016-05-03 17:16:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/1940133002/#ps60001
(title: ".")

[commit-bot: I haz the power, 2016-05-03 17:17:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1940133002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1940133002/60001

[commit-bot: I haz the power, 2016-05-03 17:45:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 17:45:19]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dcheng, 2016-05-03 17:58:23]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-05-03 17:58:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/1940133002/#ps80001
(title: "One more.")

[commit-bot: I haz the power, 2016-05-03 17:58:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1940133002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1940133002/80001

[commit-bot: I haz the power, 2016-05-03 18:14:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 18:14:58]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dcheng, 2016-05-03 18:17:18]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-05-03 18:17:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/1940133002/#ps100001
(title: ".")

[commit-bot: I haz the power, 2016-05-03 18:17:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1940133002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1940133002/100001

[commit-bot: I haz the power, 2016-05-03 19:12:52]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-05-03 19:14:39]

Description was changed from

==========
Use std::unique_ptr to transfer base::Value ownership in
extensions::ValueStoreChange

BUG=581865
==========

to

==========
Use std::unique_ptr to transfer base::Value ownership in
extensions::ValueStoreChange

BUG=581865

Committed: https://crrev.com/a226db909b0c5ec72eff20cc9b1ff8eed69145a8
Cr-Commit-Position: refs/heads/master@{#391322}
==========

[commit-bot: I haz the power, 2016-05-03 19:14:40]

Patchset 6 (id:??) landed as
https://crrev.com/a226db909b0c5ec72eff20cc9b1ff8eed69145a8
Cr-Commit-Position: refs/heads/master@{#391322}