Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issue 1939983002: This CL fixes a bug in from_gws_page_load_metrics_observer.cc in WasAbortedInForeground. Earlier it… (Closed)

Created:
4 years, 7 months ago by Charlie Harrison
Modified:
4 years, 7 months ago
Reviewers:
Bryan McQuade
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

This CL fixes a bug in from_gws_page_load_metrics_observer.cc in WasAbortedInForeground. Earlier it did not consider cases where info.startedInForeground was false. BUG=608038 Review-Url: https://codereview.chromium.org/1935533003 Cr-Commit-Position: refs/heads/master@{#390776} (cherry picked from commit a3bed3b3193c41af5150b18706af412623c26a1a) Handle intent-based navigations from gws. We now explicitly ignore provisional navigations for non HTTP/HTTPS schemes. We also consider navigations from the intent redirector to be from search. BUG=607330 TBR=bmcquade@chromium.org Review-Url: https://codereview.chromium.org/1929673004 Cr-Commit-Position: refs/heads/master@{#390652} (cherry picked from commit f91fa02d7d146fb0dc4d17b25aef3128f644a439) Committed: https://chromium.googlesource.com/chromium/src/+/38bfe2b58578bad98d9731f820b13fe2b66da66f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -65 lines) Patch
M chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc View 5 chunks +48 lines, -27 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc View 2 chunks +52 lines, -36 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Charlie Harrison
4 years, 7 months ago (2016-05-02 21:22:49 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
38bfe2b58578bad98d9731f820b13fe2b66da66f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698