WasAbortedInForeground: condition missing

This CL fixes a bug in from_gws_page_load_metrics_observer.cc in
WasAbortedInForeground. Earlier it did not consider cases where
info.startedInForeground was false.
BUG=608038
Committed: https://crrev.com/a3bed3b3193c41af5150b18706af412623c26a1a
Cr-Commit-Position: refs/heads/master@{#390776}

[shivanisha, 2016-04-29 20:55:21]

shivanisha@chromium.org changed reviewers:
+ bmcquade@chromium.org, csharrison@chromium.org

[Bryan McQuade, 2016-04-29 21:01:02]

lgtm

[Charlie Harrison, 2016-04-29 21:02:36]

https://codereview.chromium.org/1935533003/diff/1/chrome/browser/page_load_me...
File
chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
(left):

https://codereview.chromium.org/1935533003/diff/1/chrome/browser/page_load_me...
chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc:176:
if (WasStartedInForegroundEventInForeground(time_to_abort, info))
Doesn't WasStartedInForegroundEventInForeground check this?

[shivanisha, 2016-04-29 21:06:14]

https://codereview.chromium.org/1935533003/diff/1/chrome/browser/page_load_me...
File
chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
(left):

https://codereview.chromium.org/1935533003/diff/1/chrome/browser/page_load_me...
chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc:176:
if (WasStartedInForegroundEventInForeground(time_to_abort, info))
On 2016/04/29 at 21:02:36, csharrison wrote:
> Doesn't WasStartedInForegroundEventInForeground check this?

It does and it returns false if info.started_in_foreground is false.
Before the new condition the code would have proceeded assuming
first_background_time exists which is not the case.

[Charlie Harrison, 2016-04-29 21:09:09]

You're right. lgtm.

[shivanisha, 2016-04-29 21:10:22]

The CQ bit was checked by shivanisha@chromium.org

[commit-bot: I haz the power, 2016-04-29 21:11:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1935533003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1935533003/1

[commit-bot: I haz the power, 2016-04-29 21:59:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-30 17:29:26]

Patchset 1 (id:??) landed as
https://crrev.com/a3bed3b3193c41af5150b18706af412623c26a1a
Cr-Commit-Position: refs/heads/master@{#390776}

[commit-bot: I haz the power, 2016-04-30 18:02:59]

Description was changed from

==========
This CL fixes a bug in from_gws_page_load_metrics_observer.cc in
WasAbortedInForeground. Earlier it did not consider cases where
info.startedInForeground was false.
BUG=608038
==========

to

==========
This CL fixes a bug in from_gws_page_load_metrics_observer.cc in
WasAbortedInForeground. Earlier it did not consider cases where
info.startedInForeground was false.
BUG=608038

Committed: https://crrev.com/a3bed3b3193c41af5150b18706af412623c26a1a
Cr-Commit-Position: refs/heads/master@{#390776}
==========