Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2043)

Unified Diff: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h

Issue 1939983002: This CL fixes a bug in from_gws_page_load_metrics_observer.cc in WasAbortedInForeground. Earlier it… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
index b00e965b12d9863a45ed2b8ca2997ee5e02204e0..e2f5c9117d3090bdfde1b48ea02431f5eca41646 100644
--- a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
@@ -46,7 +46,6 @@ class FromGWSPageLoadMetricsLogger {
// The methods below are public only for testing.
static bool IsGoogleSearchHostname(base::StringPiece host);
static bool IsGoogleSearchResultUrl(const GURL& url);
- static bool IsGoogleRedirectorUrl(const GURL& url);
static bool IsGoogleSearchRedirectorUrl(const GURL& url);
bool ShouldLogMetrics(const GURL& url);
@@ -69,7 +68,8 @@ class FromGWSPageLoadMetricsLogger {
bool previously_committed_url_is_search_results_ = false;
bool previously_committed_url_is_search_redirector_ = false;
bool navigation_initiated_via_link_ = false;
- bool provisional_url_is_search_results_or_google_redirector_ = false;
+ bool provisional_url_has_search_hostname_ = false;
+ bool provisional_url_is_non_http_or_https_ = false;
static bool IsUrlFromGWS(const GURL& url);
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698