third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py - Issue 1939843002: Replace webkitpy standalone builders functions with instantiable class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 1939843002: Replace webkitpy standalone builders functions with instantiable class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved builders out of port, updated comment Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/builders.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

index 19237957dfdd71ed5f3a643d88105a75d6c229b7..43a0e5c62e56f875d7e49e34f73342c8de1133d8 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

@@ -1307,7 +1307,7 @@ class Port(object):

full_port_name = self.determine_full_port_name(self.host, self._options, self.port_name)

builder_category = self.get_option('ignore_builder_category', 'layout')

- factory = BotTestExpectationsFactory()

+ factory = BotTestExpectationsFactory(self.host.builders)

# FIXME: This only grabs release builder's flakiness data. If we're running debug,

# when we should grab the debug builder's data.

expectations = factory.expectations_for_port(full_port_name, builder_category)