Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/builders.py

Issue 1939843002: Replace webkitpy standalone builders functions with instantiable class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moved builders out of port, updated comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/builders.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/builders.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/builders.py
deleted file mode 100644
index 63220c727abb0b6d0789800b0953388dc1165e70..0000000000000000000000000000000000000000
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/builders.py
+++ /dev/null
@@ -1,97 +0,0 @@
-# Copyright (C) 2011 Google Inc. All rights reserved.
-#
-# Redistribution and use in source and binary forms, with or without
-# modification, are permitted provided that the following conditions are
-# met:
-#
-# * Redistributions of source code must retain the above copyright
-# notice, this list of conditions and the following disclaimer.
-# * Redistributions in binary form must reproduce the above
-# copyright notice, this list of conditions and the following disclaimer
-# in the documentation and/or other materials provided with the
-# distribution.
-# * Neither the name of Google Inc. nor the names of its
-# contributors may be used to endorse or promote products derived from
-# this software without specific prior written permission.
-#
-# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-import re
-
-# In this dictionary, each item stores:
-# * port_name -- a fully qualified port name
-# * rebaseline_override_dir -- (optional) directory to put baselines in instead of where you would normally put them.
-# This is useful when we don't have bots that cover particular configurations; so, e.g., you might
-# support mac-mountainlion but not have a mac-mountainlion bot yet, so you'd want to put the mac-lion
-# results into platform/mac temporarily.
-# * specifiers -- TestExpectation specifiers for that config. Valid values are found in
-# TestExpectationsParser._configuration_tokens_list
-
-_exact_matches = {
- "WebKit Win7": {"port_name": "win-win7", "specifiers": ['Win7', 'Release']},
- "WebKit Win7 (dbg)": {"port_name": "win-win7", "specifiers": ['Win7', 'Debug']},
- "WebKit Win10": {"port_name": "win-win10", "specifiers": ['Win10', 'Release']},
- # FIXME: Rename this to 'WebKit Linux Precise'
- "WebKit Linux": {"port_name": "linux-precise", "specifiers": ['Precise', 'Release']},
- "WebKit Linux Trusty": {"port_name": "linux-trusty", "specifiers": ['Trusty', 'Release']},
- "WebKit Linux (dbg)": {"port_name": "linux-precise", "specifiers": ['Precise', 'Debug']},
- "WebKit Mac10.9": {"port_name": "mac-mac10.9", "specifiers": ['Mac10.9', 'Release']},
- "WebKit Mac10.10": {"port_name": "mac-mac10.10", "specifiers": ['Mac10.10', 'Release']},
- "WebKit Mac10.11": {"port_name": "mac-mac10.11", "specifiers": ['10.11', 'Release']},
- "WebKit Mac10.11 (dbg)": {"port_name": "mac-mac10.11", "specifiers": ['10.11', 'Debug']},
- "WebKit Mac10.11 (retina)": {"port_name": "mac-retina", "specifiers": ['Retina', 'Release']},
- "WebKit Android (Nexus4)": {"port_name": "android", "specifiers": ['Android', 'Release']},
-}
-
-
-_ports_without_builders = [
-]
-
-
-def builder_path_from_name(builder_name):
- return re.sub(r'[\s().]', '_', builder_name)
-
-
-def all_builder_names():
- return sorted(set(_exact_matches.keys()))
-
-
-def all_port_names():
- return sorted(set(map(lambda x: x["port_name"], _exact_matches.values()) + _ports_without_builders))
-
-
-def rebaseline_override_dir(builder_name):
- return _exact_matches[builder_name].get("rebaseline_override_dir", None)
-
-
-def port_name_for_builder_name(builder_name):
- return _exact_matches[builder_name]["port_name"]
-
-
-def specifiers_for_builder(builder_name):
- return _exact_matches[builder_name]["specifiers"]
-
-
-def builder_name_for_port_name(target_port_name):
- debug_builder_name = None
- for builder_name, builder_info in _exact_matches.items():
- if builder_info['port_name'] == target_port_name:
- if 'dbg' in builder_name:
- debug_builder_name = builder_name
- else:
- return builder_name
- return debug_builder_name
-
-
-def builder_path_for_port_name(port_name):
- builder_path_from_name(builder_name_for_port_name(port_name))

Powered by Google App Engine
This is Rietveld 408576698