Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 1939843002: Replace webkitpy standalone builders functions with instantiable class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moved builders out of port, updated comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 1289 matching lines...) Expand 10 before | Expand all | Expand 10 after
1300 else: 1300 else:
1301 _log.warning("additional_expectations path '%s' does not exist" % path) 1301 _log.warning("additional_expectations path '%s' does not exist" % path)
1302 return expectations 1302 return expectations
1303 1303
1304 def bot_expectations(self): 1304 def bot_expectations(self):
1305 if not self.get_option('ignore_flaky_tests'): 1305 if not self.get_option('ignore_flaky_tests'):
1306 return {} 1306 return {}
1307 1307
1308 full_port_name = self.determine_full_port_name(self.host, self._options, self.port_name) 1308 full_port_name = self.determine_full_port_name(self.host, self._options, self.port_name)
1309 builder_category = self.get_option('ignore_builder_category', 'layout') 1309 builder_category = self.get_option('ignore_builder_category', 'layout')
1310 factory = BotTestExpectationsFactory() 1310 factory = BotTestExpectationsFactory(self.host.builders)
1311 # FIXME: This only grabs release builder's flakiness data. If we're runn ing debug, 1311 # FIXME: This only grabs release builder's flakiness data. If we're runn ing debug,
1312 # when we should grab the debug builder's data. 1312 # when we should grab the debug builder's data.
1313 expectations = factory.expectations_for_port(full_port_name, builder_cat egory) 1313 expectations = factory.expectations_for_port(full_port_name, builder_cat egory)
1314 1314
1315 if not expectations: 1315 if not expectations:
1316 return {} 1316 return {}
1317 1317
1318 ignore_mode = self.get_option('ignore_flaky_tests') 1318 ignore_mode = self.get_option('ignore_flaky_tests')
1319 if ignore_mode == 'very-flaky' or ignore_mode == 'maybe-flaky': 1319 if ignore_mode == 'very-flaky' or ignore_mode == 'maybe-flaky':
1320 return expectations.flakes_by_path(ignore_mode == 'very-flaky') 1320 return expectations.flakes_by_path(ignore_mode == 'very-flaky')
(...skipping 461 matching lines...) Expand 10 before | Expand all | Expand 10 after
1782 1782
1783 def __init__(self, base, args, reference_args=None): 1783 def __init__(self, base, args, reference_args=None):
1784 self.name = base 1784 self.name = base
1785 self.base = base 1785 self.base = base
1786 self.args = args 1786 self.args = args
1787 self.reference_args = args if reference_args is None else reference_args 1787 self.reference_args = args if reference_args is None else reference_args
1788 self.tests = set() 1788 self.tests = set()
1789 1789
1790 def __repr__(self): 1790 def __repr__(self):
1791 return "PhysicalTestSuite('%s', '%s', %s, %s)" % (self.name, self.base, self.args, self.reference_args) 1791 return "PhysicalTestSuite('%s', '%s', %s, %s)" % (self.name, self.base, self.args, self.reference_args)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698