Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1939413002: [Extensions] Add coarse metrics for extension function performance (Closed)

Created:
4 years, 7 months ago by Devlin
Modified:
4 years, 7 months ago
Reviewers:
lazyboy, Mark P
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Add coarse metrics for extension function performance Add metrics for extension function performance for overall and synchronous execution time. After these stew awhile, I'll add bucketed metrics that can capture specific extension metrics (see bug for more details). BUG=608561 Committed: https://crrev.com/f46fe266479fc6e1b133a80ad4ff95f15e064be7 Cr-Commit-Position: refs/heads/master@{#391389}

Patch Set 1 : #

Total comments: 8

Patch Set 2 : Istiaque's #

Total comments: 6

Patch Set 3 : Mark's #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -0 lines) Patch
M extensions/browser/extension_function.h View 2 chunks +3 lines, -0 lines 0 comments Download
M extensions/browser/extension_function.cc View 1 2 chunks +15 lines, -0 lines 0 comments Download
M extensions/browser/extension_function_dispatcher.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Devlin
Istiaque and Mark, mind taking a look? Mark, please also see comment in histograms.xml. https://codereview.chromium.org/1939413002/diff/20001/tools/metrics/histograms/histograms.xml ...
4 years, 7 months ago (2016-05-03 00:43:49 UTC) #3
lazyboy
https://codereview.chromium.org/1939413002/diff/20001/extensions/browser/extension_function.cc File extensions/browser/extension_function.cc (right): https://codereview.chromium.org/1939413002/diff/20001/extensions/browser/extension_function.cc#newcode411 extensions/browser/extension_function.cc:411: // TODO(devlin): Once we have a baseline metric for ...
4 years, 7 months ago (2016-05-03 01:00:01 UTC) #4
Devlin
https://codereview.chromium.org/1939413002/diff/20001/extensions/browser/extension_function.cc File extensions/browser/extension_function.cc (right): https://codereview.chromium.org/1939413002/diff/20001/extensions/browser/extension_function.cc#newcode411 extensions/browser/extension_function.cc:411: // TODO(devlin): Once we have a baseline metric for ...
4 years, 7 months ago (2016-05-03 17:03:36 UTC) #5
lazyboy
extensions LGTM
4 years, 7 months ago (2016-05-03 17:29:26 UTC) #6
Mark P
https://codereview.chromium.org/1939413002/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1939413002/diff/20001/tools/metrics/histograms/histograms.xml#newcode13592 tools/metrics/histograms/histograms.xml:13592: +<histogram name="Extensions.Functions.SynchronousExecutionTime" units="ms"> On 2016/05/03 00:43:49, Devlin wrote: > ...
4 years, 7 months ago (2016-05-03 18:30:39 UTC) #7
Devlin
https://codereview.chromium.org/1939413002/diff/40001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1939413002/diff/40001/tools/metrics/histograms/histograms.xml#newcode13596 tools/metrics/histograms/histograms.xml:13596: + succeeded from the time the extension function is ...
4 years, 7 months ago (2016-05-03 20:43:01 UTC) #8
Mark P
histograms.xml lgtm
4 years, 7 months ago (2016-05-03 21:37:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1939413002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1939413002/60001
4 years, 7 months ago (2016-05-03 21:55:39 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 7 months ago (2016-05-03 23:15:54 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 23:17:27 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f46fe266479fc6e1b133a80ad4ff95f15e064be7
Cr-Commit-Position: refs/heads/master@{#391389}

Powered by Google App Engine
This is Rietveld 408576698