Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 1939413002: [Extensions] Add coarse metrics for extension function performance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 2f8df067687647edf40dbeec32e4f83d2dddac51..786ee75fce4bc225e19408998c66043bfb3a406c 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -13589,6 +13589,26 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<summary>Number of calls to extension functions.</summary>
</histogram>
+<histogram name="Extensions.Functions.SynchronousExecutionTime" units="ms">
Devlin 2016/05/03 00:43:49 Mark: I see other places that use TimeTicks/TimeDe
Mark P 2016/05/03 18:30:39 All the UMA_HISTOGRAM_TIMES macros use millisecond
+ <owner>rdevlin.cronin@chromium.org</owner>
+ <summary>
+ The synchronous amount of time an extension function takes. Note that many
+ extension functions run asynchronously; see also
+ Extensions.Functions.TotalExecutionTime.
+ </summary>
+</histogram>
+
+<histogram name="Extensions.Functions.TotalExecutionTime" units="ms">
+ <owner>rdevlin.cronin@chromium.org</owner>
+ <summary>
+ The total amount of time it takes to execute an extension function from the
+ time the extension function is called to the time the function responds.
+ Note that since some extension functions are inherently slow (anything that
+ requires user interaction, for instance), this is not a definitive source
+ for function performance.
+ </summary>
+</histogram>
+
<histogram name="Extensions.GetUserDataTempDir" enum="GetUserDataTempDirResult">
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<summary>

Powered by Google App Engine
This is Rietveld 408576698