Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 1939413002: [Extensions] Add coarse metrics for extension function performance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Istiaque's Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « extensions/browser/extension_function_dispatcher.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 2f8df067687647edf40dbeec32e4f83d2dddac51..25fa01e9dee8d2d3b55c3f6054a656f15ebbd845 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -13589,6 +13589,37 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<summary>Number of calls to extension functions.</summary>
</histogram>
+<histogram name="Extensions.Functions.FailedTotalExecutionTime" units="ms">
+ <owner>rdevlin.cronin@chromium.org</owner>
+ <summary>
+ The total amount of time it took to execute an extension function that
+ succeeded from the time the extension function is called to the time the
Mark P 2016/05/03 18:30:39 succeed -> failed
Devlin 2016/05/03 20:43:01 Done.
+ function responds. Note that since some extension functions are inherently
Mark P 2016/05/03 18:30:39 Is it possible to fail without responding (e.g., a
Devlin 2016/05/03 20:43:01 Theoretically, we should always respond. If we do
+ slow (anything that requires user interaction, for instance), this is not a
+ definitive source for function performance.
+ </summary>
+</histogram>
+
+<histogram name="Extensions.Functions.SucceededTotalExecutionTime" units="ms">
+ <owner>rdevlin.cronin@chromium.org</owner>
+ <summary>
+ The total amount of time it took to execute an extension function that
+ succeeded from the time the extension function is called to the time the
+ function responds. Note that since some extension functions are inherently
+ slow (anything that requires user interaction, for instance), this is not a
+ definitive source for function performance.
+ </summary>
+</histogram>
+
+<histogram name="Extensions.Functions.SynchronousExecutionTime" units="ms">
Mark P 2016/05/03 18:30:39 I see this is recorded in two places in the code.
Devlin 2016/05/03 20:43:01 Yep, they are conceptually the same.
+ <owner>rdevlin.cronin@chromium.org</owner>
+ <summary>
+ The synchronous amount of time an extension function takes. Note that many
+ extension functions run asynchronously; see also
+ Extensions.Functions.[Succeeded|Failed]TotalExecutionTime.
+ </summary>
+</histogram>
+
<histogram name="Extensions.GetUserDataTempDir" enum="GetUserDataTempDirResult">
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<summary>
« no previous file with comments | « extensions/browser/extension_function_dispatcher.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698