Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-3.html

Issue 19390002: Spanning logical height is not added properly in all spanning rows. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@RowSpan_B254914_6
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-2.html ('k') | LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-3-expected.txt » ('j') | Source/core/rendering/RenderTableSection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-3.html
diff --git a/LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-1.html b/LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-3.html
similarity index 65%
copy from LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-1.html
copy to LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-3.html
index d1ff10d3ad224fc731b7a5bde3fc36791ed499d7..5a287125ef7fae25673add4d38ef79245c149332 100644
--- a/LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-1.html
+++ b/LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-3.html
@@ -12,9 +12,9 @@
</style>
</head>
<body onload="checkLayout('tr')">
-<h3>Test for chromium bug : <a href="https://code.google.com/p/chromium/issues/detail?id=78724">78724</a>. Extra logical height is not properly spread over the rows in a row-spanning cell.</h3>
+<h3>Test for chromium bug : <a href="https://code.google.com/p/chromium/issues/detail?id=249600">249600</a>. Extra logical height is not properly spread over the rows in a row-spanning cell.</h3>
Julien - ping for review 2013/07/23 00:13:43 It would really be better to pick up the meta bug
a.suchit 2013/07/23 12:19:56 Every patch is created to fix a specific bug in th
Julien - ping for review 2013/07/23 18:00:11 I have a hard time understanding your point here.
<h4>Rows in rowspan should get proportional height.</h4>
-<h5>Test 1 - One rowSpan cell</h5>
+<h5>Test 1 - Three rowSpan cells</h5>
<table border="1">
<tbody>
<tr>
@@ -36,9 +36,49 @@
<tr data-expected-height="19">
<td>row5 col0</td>
</tr>
+ <tr>
+ <td>row6 col0</td>
+ </tr>
+ <tr data-expected-height="57">
+ <td>row7 col0</td>
+ <td rowspan="4" style="height:300px">row7 col1 - rowspan=4</td>
+ </tr>
+ <tr data-expected-height="57">
+ <td>row8 col0</td>
+ </tr>
+ <tr data-expected-height="74">
+ <td>row9 col0</td>
+ </tr>
+ <tr data-expected-height="75">
+ <td>row10 col0</td>
+ </tr>
+ <tr data-expected-height="19">
+ <td>row11 col0</td>
+ <td>row11 col1</td>
+ </tr>
+ <tr>
+ <td>row12 col0</td>
+ </tr>
+ <tr data-expected-height="59">
+ <td>row13 col0</td>
+ <td rowspan="4" style="height:300px">row13 col1 - rowspan=4</td>
+ </tr>
+ <tr data-expected-height="74">
+ <td style="height:70px">row14 col0</td>
+ </tr>
+ <tr data-expected-height="34">
+ <td style="height:30px">row15 col0</td>
+ </tr>
+ <tr data-expected-height="104">
+ <td style="height:100px">row16 col0</td>
+ </tr>
+ <tr data-expected-height="54">
+ <td style="height:50px">row17 col0</td>
+ <td>row17 col1</td>
+ </tr>
Julien - ping for review 2013/07/23 00:13:43 Can we please add more complex cases as we impleme
a.suchit 2013/07/23 12:19:56 These test cases are specifying that multiple span
</tbody>
</table>
-<h5>Test 2 - One rowSpan cell and specified table width</h5>
+<h5>Test 2 - Three rowSpan cell and specified table width</h5>
<table border="1" width="607">
<tbody>
<tr data-expected-height="19">
@@ -57,59 +97,100 @@
<tr data-expected-height="19">
<td>row4 col1</td>
</tr>
- </tbody>
-</table>
-<h5>Test 3 - One rowSpan cell and specified rowSpan cell height</h5>
-<table border="1">
- <tbody>
<tr>
- <td>row0 col0</td>
+ <td>row5 col0</td>
</tr>
<tr data-expected-height="57">
- <td>row1 col0</td>
- <td rowspan="4" style="height:300px">row1 col1 - rowspan=4</td>
+ <td>row6 col0</td>
+ <td rowspan="4" style="height:300px">row6 col1 - rowspan=4</td>
</tr>
<tr data-expected-height="57">
- <td>row2 col0</td>
+ <td>row7 col0</td>
</tr>
<tr data-expected-height="74">
- <td>row3 col0</td>
+ <td>row8 col0</td>
</tr>
<tr data-expected-height="75">
- <td>row4 col0</td>
+ <td>row9 col0</td>
</tr>
<tr data-expected-height="19">
- <td>row5 col0</td>
- <td>row5 col1</td>
+ <td>row10 col0</td>
+ <td>row10 col1</td>
+ </tr>
+ <tr>
+ <td>row11 col0</td>
+ </tr>
+ <tr data-expected-height="59">
+ <td>row12 col0</td>
+ <td rowspan="4" style="height:300px">row12 col1 - rowspan=4</td>
+ </tr>
+ <tr data-expected-height="74">
+ <td style="height:70px">row13 col0</td>
+ </tr>
+ <tr data-expected-height="34">
+ <td style="height:30px">row14 col0</td>
+ </tr>
+ <tr data-expected-height="104">
+ <td style="height:100px">row15 col0</td>
+ </tr>
+ <tr data-expected-height="54">
+ <td style="height:50px">row16 col0</td>
+ <td>row16 col1</td>
</tr>
</tbody>
</table>
-<h5>Test 4 - One rowSpan cell and specified cells height</h5>
+<h5>Test 3 - Continuous 3 rowSpan cells</h5>
<table border="1">
<tbody>
<tr>
<td>row0 col0</td>
</tr>
+ <tr data-expected-height="19">
+ <td rowspan="4">row1 col0 - rowspan=4</td>
+ <td>row1 col1</td>
+ </tr>
+ <tr data-expected-height="19">
+ <td>row2 col1</td>
+ </tr>
+ <tr data-expected-height="19">
+ <td>row3 col1</td>
+ </tr>
+ <tr data-expected-height="19">
+ <td>row4 col1</td>
+ </tr>
+ <tr data-expected-height="57">
+ <td>row5 col0</td>
+ <td rowspan="4" style="height:300px">row5 col1 - rowspan=4</td>
+ </tr>
+ <tr data-expected-height="57">
+ <td>row6 col0</td>
+ </tr>
+ <tr data-expected-height="74">
+ <td>row7 col0</td>
+ </tr>
+ <tr data-expected-height="75">
+ <td>row8 col0</td>
+ </tr>
<tr data-expected-height="59">
- <td>row1 col0</td>
- <td rowspan="4" style="height:300px">row1 col1 - rowspan=4</td>
+ <td>row9 col0</td>
+ <td rowspan="4" style="height:300px">row9 col1 - rowspan=4</td>
</tr>
<tr data-expected-height="74">
- <td style="height:70px">row2 col0</td>
+ <td style="height:70px">row10 col0</td>
</tr>
<tr data-expected-height="34">
- <td style="height:30px">row3 col0</td>
+ <td style="height:30px">row11 col0</td>
</tr>
<tr data-expected-height="104">
- <td style="height:100px">row4 col0</td>
+ <td style="height:100px">row12 col0</td>
</tr>
<tr data-expected-height="54">
- <td style="height:50px">row5 col0</td>
- <td>row5 col1</td>
+ <td style="height:50px">row13 col0</td>
+ <td>row13 col1</td>
</tr>
</tbody>
</table>
-<h5>Test 5 - RowSpan and ColSpan. </h5>
+<h5>Test 4 - RowSpan and ColSpan. </h5>
<table border="1" width="607">
<tbody>
<tr data-expected-height="34">
@@ -131,7 +212,7 @@
</tr>
</tbody>
</table>
-<h5>Test 6 - Mix of baseline aligned and non-baseline aligned cells.</h5>
+<h5>Test 5 - Mix of baseline aligned and non-baseline aligned cells.</h5>
<table border="1" width="607">
<tbody>
<tr data-expected-height="104">
@@ -160,7 +241,7 @@
</tr>
</tbody>
</table>
-<h5>Test 7 - CSS Table.</h5>
+<h5>Test 6 - CSS Table.</h5>
<div id="div-table">
<span id="span-row">
<span id="span-cell">row0 col0</span>
@@ -205,7 +286,7 @@
<div id="div-cell">row10 col0</div>
</div>
</div>
-<h5>Test 8 - Table Similar to CSS table with rowspan.</h5>
+<h5>Test 7 - Table Similar to CSS table with rowspan.</h5>
<table border="1px">
<tr data-expected-height="39">
<td rowspan=5 style="height:300px">row0 col0</td>
@@ -237,16 +318,16 @@
<td rowspan=5 style="height:200px">row6 col0</td>
<td rowspan=5 style="height:100px">row6 col1</td>
</tr>
- <tr data-expected-height="19">
+ <tr data-expected-height="37">
<td>row7 col1</td>
</tr>
- <tr data-expected-height="19">
+ <tr data-expected-height="38">
<td>row8 col1</td>
</tr>
- <tr data-expected-height="19">
+ <tr data-expected-height="49">
<td>row9 col1</td>
</tr>
- <tr data-expected-height="19">
+ <tr data-expected-height="49">
<td>row10 col1</td>
</tr>
</table>
« no previous file with comments | « LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-2.html ('k') | LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-3-expected.txt » ('j') | Source/core/rendering/RenderTableSection.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698