Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-3-expected.txt

Issue 19390002: Spanning logical height is not added properly in all spanning rows. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@RowSpan_B254914_6
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-3-expected.txt
diff --git a/LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-1-expected.txt b/LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-3-expected.txt
similarity index 52%
copy from LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-1-expected.txt
copy to LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-3-expected.txt
index 43dbd41f59460ff5057179ae2ec500a1dfea65a8..01e2747dabae34c745984c7d6ecbbd64cfbfe5d8 100644
--- a/LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-1-expected.txt
+++ b/LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-3-expected.txt
@@ -1,8 +1,8 @@
-Test for chromium bug : 78724. Extra logical height is not properly spread over the rows in a row-spanning cell.
+Test for chromium bug : 249600. Extra logical height is not properly spread over the rows in a row-spanning cell.
Rows in rowspan should get proportional height.
-Test 1 - One rowSpan cell
+Test 1 - Three rowSpan cells
row0 col0
PASS
@@ -16,7 +16,31 @@ row4 col1
PASS
row5 col0
PASS
-Test 2 - One rowSpan cell and specified table width
+row6 col0
+PASS
+row7 col0 row7 col1 - rowspan=4
+PASS
+row8 col0
+PASS
+row9 col0
+PASS
+row10 col0
+PASS
+row11 col0 row11 col1
+PASS
+row12 col0
+PASS
+row13 col0 row13 col1 - rowspan=4
+PASS
+row14 col0
+PASS
+row15 col0
+PASS
+row16 col0
+PASS
+row17 col0 row17 col1
+PASS
+Test 2 - Three rowSpan cell and specified table width
row0 col0 - rowspan=5 row0 col1
PASS
@@ -28,35 +52,61 @@ row3 col1
PASS
row4 col1
PASS
-Test 3 - One rowSpan cell and specified rowSpan cell height
-
-row0 col0
+row5 col0
PASS
-row1 col0 row1 col1 - rowspan=4
+row6 col0 row6 col1 - rowspan=4
PASS
-row2 col0
+row7 col0
PASS
-row3 col0
+row8 col0
PASS
-row4 col0
+row9 col0
PASS
-row5 col0 row5 col1
+row10 col0 row10 col1
PASS
-Test 4 - One rowSpan cell and specified cells height
+row11 col0
+PASS
+row12 col0 row12 col1 - rowspan=4
+PASS
+row13 col0
+PASS
+row14 col0
+PASS
+row15 col0
+PASS
+row16 col0 row16 col1
+PASS
+Test 3 - Continuous 3 rowSpan cells
row0 col0
PASS
-row1 col0 row1 col1 - rowspan=4
+row1 col0 - rowspan=4 row1 col1
PASS
-row2 col0
+row2 col1
PASS
-row3 col0
+row3 col1
PASS
-row4 col0
+row4 col1
+PASS
+row5 col0 row5 col1 - rowspan=4
+PASS
+row6 col0
+PASS
+row7 col0
+PASS
+row8 col0
+PASS
+row9 col0 row9 col1 - rowspan=4
+PASS
+row10 col0
+PASS
+row11 col0
+PASS
+row12 col0
PASS
-row5 col0 row5 col1
+row13 col0 row13 col1
PASS
-Test 5 - RowSpan and ColSpan.
+Test 4 - RowSpan and ColSpan.
row0 col0 row0 col1 - rowspan=3 colspan=2 row0 col2
PASS
@@ -68,7 +118,7 @@ row3 col0 - colspan=3
PASS
row4 col0
PASS
-Test 6 - Mix of baseline aligned and non-baseline aligned cells.
+Test 5 - Mix of baseline aligned and non-baseline aligned cells.
row0 col0 row0 col1 vertical-align=top row0 col2 vertical-align=bottom
PASS
@@ -84,7 +134,7 @@ row5 col1 vertical-align=text-bottom
PASS
row6 col0
PASS
-Test 7 - CSS Table.
+Test 6 - CSS Table.
row0 col0 row0 col1 row0 col2
row1 col0 row1 col1 row1 col2
@@ -97,7 +147,7 @@ row7 col0
row8 col0
row9 col0
row10 col0
-Test 8 - Table Similar to CSS table with rowspan.
+Test 7 - Table Similar to CSS table with rowspan.
row0 col0 row0 col1 row0 col2
PASS

Powered by Google App Engine
This is Rietveld 408576698