Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-3.html

Issue 19390002: Spanning logical height is not added properly in all spanning rows. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@RowSpan_B254914_6
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-2.html ('k') | LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-3-expected.txt » ('j') | Source/core/rendering/RenderTableSection.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <html> 2 <html>
3 <head> 3 <head>
4 <title>Table rowspan</title> 4 <title>Table rowspan</title>
5 <script src="../../resources/check-layout.js"></script> 5 <script src="../../resources/check-layout.js"></script>
6 <style> 6 <style>
7 td { font: 15px/1 Ahem } 7 td { font: 15px/1 Ahem }
8 #div-table { display: table; border-spacing: 2px } 8 #div-table { display: table; border-spacing: 2px }
9 #div-row, #span-row { display: table-row } 9 #div-row, #span-row { display: table-row }
10 #div-cell, #span-cell { display: table-cell } 10 #div-cell, #span-cell { display: table-cell }
11 #div-table, #div-row, #span-row, #div-cell, #span-cell{ border: 1px solid bl ack } 11 #div-table, #div-row, #span-row, #div-cell, #span-cell{ border: 1px solid bl ack }
12 </style> 12 </style>
13 </head> 13 </head>
14 <body onload="checkLayout('tr')"> 14 <body onload="checkLayout('tr')">
15 <h3>Test for chromium bug : <a href="https://code.google.com/p/chromium/issues/d etail?id=78724">78724</a>. Extra logical height is not properly spread over the rows in a row-spanning cell.</h3> 15 <h3>Test for chromium bug : <a href="https://code.google.com/p/chromium/issues/d etail?id=249600">249600</a>. Extra logical height is not properly spread over th e rows in a row-spanning cell.</h3>
Julien - ping for review 2013/07/23 00:13:43 It would really be better to pick up the meta bug
a.suchit 2013/07/23 12:19:56 Every patch is created to fix a specific bug in th
Julien - ping for review 2013/07/23 18:00:11 I have a hard time understanding your point here.
16 <h4>Rows in rowspan should get proportional height.</h4> 16 <h4>Rows in rowspan should get proportional height.</h4>
17 <h5>Test 1 - One rowSpan cell</h5> 17 <h5>Test 1 - Three rowSpan cells</h5>
18 <table border="1"> 18 <table border="1">
19 <tbody> 19 <tbody>
20 <tr> 20 <tr>
21 <td>row0 col0</td> 21 <td>row0 col0</td>
22 </tr> 22 </tr>
23 <tr data-expected-height="19"> 23 <tr data-expected-height="19">
24 <td rowspan="4">row1 col0 - rowspan=4</td> 24 <td rowspan="4">row1 col0 - rowspan=4</td>
25 <td>row1 col1</td> 25 <td>row1 col1</td>
26 </tr> 26 </tr>
27 <tr data-expected-height="19"> 27 <tr data-expected-height="19">
28 <td>row2 col1</td> 28 <td>row2 col1</td>
29 </tr> 29 </tr>
30 <tr data-expected-height="19"> 30 <tr data-expected-height="19">
31 <td>row3 col1</td> 31 <td>row3 col1</td>
32 </tr> 32 </tr>
33 <tr data-expected-height="19"> 33 <tr data-expected-height="19">
34 <td>row4 col1</td> 34 <td>row4 col1</td>
35 </tr> 35 </tr>
36 <tr data-expected-height="19"> 36 <tr data-expected-height="19">
37 <td>row5 col0</td> 37 <td>row5 col0</td>
38 </tr> 38 </tr>
39 <tr>
40 <td>row6 col0</td>
41 </tr>
42 <tr data-expected-height="57">
43 <td>row7 col0</td>
44 <td rowspan="4" style="height:300px">row7 col1 - rowspan=4</td>
45 </tr>
46 <tr data-expected-height="57">
47 <td>row8 col0</td>
48 </tr>
49 <tr data-expected-height="74">
50 <td>row9 col0</td>
51 </tr>
52 <tr data-expected-height="75">
53 <td>row10 col0</td>
54 </tr>
55 <tr data-expected-height="19">
56 <td>row11 col0</td>
57 <td>row11 col1</td>
58 </tr>
59 <tr>
60 <td>row12 col0</td>
61 </tr>
62 <tr data-expected-height="59">
63 <td>row13 col0</td>
64 <td rowspan="4" style="height:300px">row13 col1 - rowspan=4</td>
65 </tr>
66 <tr data-expected-height="74">
67 <td style="height:70px">row14 col0</td>
68 </tr>
69 <tr data-expected-height="34">
70 <td style="height:30px">row15 col0</td>
71 </tr>
72 <tr data-expected-height="104">
73 <td style="height:100px">row16 col0</td>
74 </tr>
75 <tr data-expected-height="54">
76 <td style="height:50px">row17 col0</td>
77 <td>row17 col1</td>
78 </tr>
Julien - ping for review 2013/07/23 00:13:43 Can we please add more complex cases as we impleme
a.suchit 2013/07/23 12:19:56 These test cases are specifying that multiple span
39 </tbody> 79 </tbody>
40 </table> 80 </table>
41 <h5>Test 2 - One rowSpan cell and specified table width</h5> 81 <h5>Test 2 - Three rowSpan cell and specified table width</h5>
42 <table border="1" width="607"> 82 <table border="1" width="607">
43 <tbody> 83 <tbody>
44 <tr data-expected-height="19"> 84 <tr data-expected-height="19">
45 <td rowspan="5">row0 col0 - rowspan=5</td> 85 <td rowspan="5">row0 col0 - rowspan=5</td>
46 <td>row0 col1</td> 86 <td>row0 col1</td>
47 </tr> 87 </tr>
48 <tr data-expected-height="19"> 88 <tr data-expected-height="19">
49 <td>row1 col1</td> 89 <td>row1 col1</td>
50 </tr> 90 </tr>
51 <tr data-expected-height="19"> 91 <tr data-expected-height="19">
52 <td>row2 col1</td> 92 <td>row2 col1</td>
53 </tr> 93 </tr>
54 <tr data-expected-height="19"> 94 <tr data-expected-height="19">
55 <td>row3 col1</td> 95 <td>row3 col1</td>
56 </tr> 96 </tr>
57 <tr data-expected-height="19"> 97 <tr data-expected-height="19">
58 <td>row4 col1</td> 98 <td>row4 col1</td>
59 </tr> 99 </tr>
100 <tr>
101 <td>row5 col0</td>
102 </tr>
103 <tr data-expected-height="57">
104 <td>row6 col0</td>
105 <td rowspan="4" style="height:300px">row6 col1 - rowspan=4</td>
106 </tr>
107 <tr data-expected-height="57">
108 <td>row7 col0</td>
109 </tr>
110 <tr data-expected-height="74">
111 <td>row8 col0</td>
112 </tr>
113 <tr data-expected-height="75">
114 <td>row9 col0</td>
115 </tr>
116 <tr data-expected-height="19">
117 <td>row10 col0</td>
118 <td>row10 col1</td>
119 </tr>
120 <tr>
121 <td>row11 col0</td>
122 </tr>
123 <tr data-expected-height="59">
124 <td>row12 col0</td>
125 <td rowspan="4" style="height:300px">row12 col1 - rowspan=4</td>
126 </tr>
127 <tr data-expected-height="74">
128 <td style="height:70px">row13 col0</td>
129 </tr>
130 <tr data-expected-height="34">
131 <td style="height:30px">row14 col0</td>
132 </tr>
133 <tr data-expected-height="104">
134 <td style="height:100px">row15 col0</td>
135 </tr>
136 <tr data-expected-height="54">
137 <td style="height:50px">row16 col0</td>
138 <td>row16 col1</td>
139 </tr>
60 </tbody> 140 </tbody>
61 </table> 141 </table>
62 <h5>Test 3 - One rowSpan cell and specified rowSpan cell height</h5> 142 <h5>Test 3 - Continuous 3 rowSpan cells</h5>
63 <table border="1"> 143 <table border="1">
64 <tbody> 144 <tbody>
65 <tr> 145 <tr>
66 <td>row0 col0</td> 146 <td>row0 col0</td>
67 </tr> 147 </tr>
148 <tr data-expected-height="19">
149 <td rowspan="4">row1 col0 - rowspan=4</td>
150 <td>row1 col1</td>
151 </tr>
152 <tr data-expected-height="19">
153 <td>row2 col1</td>
154 </tr>
155 <tr data-expected-height="19">
156 <td>row3 col1</td>
157 </tr>
158 <tr data-expected-height="19">
159 <td>row4 col1</td>
160 </tr>
68 <tr data-expected-height="57"> 161 <tr data-expected-height="57">
69 » <td>row1 col0</td> 162 » <td>row5 col0</td>
70 » <td rowspan="4" style="height:300px">row1 col1 - rowspan=4</td> 163 » <td rowspan="4" style="height:300px">row5 col1 - rowspan=4</td>
71 </tr> 164 </tr>
72 <tr data-expected-height="57"> 165 <tr data-expected-height="57">
73 <td>row2 col0</td> 166 <td>row6 col0</td>
74 </tr> 167 </tr>
75 <tr data-expected-height="74"> 168 <tr data-expected-height="74">
76 <td>row3 col0</td> 169 <td>row7 col0</td>
77 </tr> 170 </tr>
78 <tr data-expected-height="75"> 171 <tr data-expected-height="75">
79 <td>row4 col0</td> 172 <td>row8 col0</td>
80 </tr> 173 </tr>
81 <tr data-expected-height="19"> 174 <tr data-expected-height="59">
82 <td>row5 col0</td> 175 » <td>row9 col0</td>
83 <td>row5 col1</td> 176 » <td rowspan="4" style="height:300px">row9 col1 - rowspan=4</td>
177 » </tr>
178 <tr data-expected-height="74">
179 <td style="height:70px">row10 col0</td>
180 </tr>
181 <tr data-expected-height="34">
182 <td style="height:30px">row11 col0</td>
183 </tr>
184 <tr data-expected-height="104">
185 <td style="height:100px">row12 col0</td>
186 </tr>
187 <tr data-expected-height="54">
188 <td style="height:50px">row13 col0</td>
189 <td>row13 col1</td>
84 </tr> 190 </tr>
85 </tbody> 191 </tbody>
86 </table> 192 </table>
87 <h5>Test 4 - One rowSpan cell and specified cells height</h5> 193 <h5>Test 4 - RowSpan and ColSpan. </h5>
88 <table border="1">
89 <tbody>
90 <tr>
91 <td>row0 col0</td>
92 </tr>
93 <tr data-expected-height="59">
94 » <td>row1 col0</td>
95 » <td rowspan="4" style="height:300px">row1 col1 - rowspan=4</td>
96 » </tr>
97 <tr data-expected-height="74">
98 <td style="height:70px">row2 col0</td>
99 </tr>
100 <tr data-expected-height="34">
101 <td style="height:30px">row3 col0</td>
102 </tr>
103 <tr data-expected-height="104">
104 <td style="height:100px">row4 col0</td>
105 </tr>
106 <tr data-expected-height="54">
107 <td style="height:50px">row5 col0</td>
108 <td>row5 col1</td>
109 </tr>
110 </tbody>
111 </table>
112 <h5>Test 5 - RowSpan and ColSpan. </h5>
113 <table border="1" width="607"> 194 <table border="1" width="607">
114 <tbody> 195 <tbody>
115 <tr data-expected-height="34"> 196 <tr data-expected-height="34">
116 <td>row0 col0</td> 197 <td>row0 col0</td>
117 <td rowspan="3" colspan="2">row0 col1 - rowspan=3 colspan=2</td> 198 <td rowspan="3" colspan="2">row0 col1 - rowspan=3 colspan=2</td>
118 <td>row0 col2</td> 199 <td>row0 col2</td>
119 </tr> 200 </tr>
120 <tr data-expected-height="34"> 201 <tr data-expected-height="34">
121 <td>row1 col0</td> 202 <td>row1 col0</td>
122 </tr> 203 </tr>
123 <tr data-expected-height="34"> 204 <tr data-expected-height="34">
124 <td>row2 col0</td> 205 <td>row2 col0</td>
125 </tr> 206 </tr>
126 <tr data-expected-height="19"> 207 <tr data-expected-height="19">
127 <td colspan="3">row3 col0 - colspan=3</td> 208 <td colspan="3">row3 col0 - colspan=3</td>
128 </tr> 209 </tr>
129 <tr data-expected-height="34"> 210 <tr data-expected-height="34">
130 <td>row4 col0</td> 211 <td>row4 col0</td>
131 </tr> 212 </tr>
132 </tbody> 213 </tbody>
133 </table> 214 </table>
134 <h5>Test 6 - Mix of baseline aligned and non-baseline aligned cells.</h5> 215 <h5>Test 5 - Mix of baseline aligned and non-baseline aligned cells.</h5>
135 <table border="1" width="607"> 216 <table border="1" width="607">
136 <tbody> 217 <tbody>
137 <tr data-expected-height="104"> 218 <tr data-expected-height="104">
138 <td style="height:100px">row0 col0</td> 219 <td style="height:100px">row0 col0</td>
139 <td style="vertical-align:top">row0 col1 vertical-align=top</td> 220 <td style="vertical-align:top">row0 col1 vertical-align=top</td>
140 <td style="vertical-align:bottom">row0 col2 vertical-align=bottom</td> 221 <td style="vertical-align:bottom">row0 col2 vertical-align=bottom</td>
141 </tr> 222 </tr>
142 <tr data-expected-height="19"> 223 <tr data-expected-height="19">
143 <td>row1 col0</td> 224 <td>row1 col0</td>
144 </tr> 225 </tr>
145 <tr data-expected-height="77"> 226 <tr data-expected-height="77">
146 <td rowspan="4" style="vertical-align:text-top; height:300px">row2 col0 - rowspan=4 vertical-align=text-top</td> 227 <td rowspan="4" style="vertical-align:text-top; height:300px">row2 col0 - rowspan=4 vertical-align=text-top</td>
147 <td style="vertical-align:sub">row2 col1 vertical-align=sub</td> 228 <td style="vertical-align:sub">row2 col1 vertical-align=sub</td>
148 </tr> 229 </tr>
149 <tr data-expected-height="77"> 230 <tr data-expected-height="77">
150 <td style="vertical-align:middle">row3 col1 vertical-align=middle</td> 231 <td style="vertical-align:middle">row3 col1 vertical-align=middle</td>
151 </tr> 232 </tr>
152 <tr data-expected-height="69"> 233 <tr data-expected-height="69">
153 <td style="vertical-align:super">row4 col1 vertical-align=super</td> 234 <td style="vertical-align:super">row4 col1 vertical-align=super</td>
154 </tr> 235 </tr>
155 <tr data-expected-height="91"> 236 <tr data-expected-height="91">
156 <td style="vertical-align:text-bottom">row5 col1 vertical-align=text-botto m</td> 237 <td style="vertical-align:text-bottom">row5 col1 vertical-align=text-botto m</td>
157 </tr> 238 </tr>
158 <tr data-expected-height="19"> 239 <tr data-expected-height="19">
159 <td>row6 col0</td> 240 <td>row6 col0</td>
160 </tr> 241 </tr>
161 </tbody> 242 </tbody>
162 </table> 243 </table>
163 <h5>Test 7 - CSS Table.</h5> 244 <h5>Test 6 - CSS Table.</h5>
164 <div id="div-table"> 245 <div id="div-table">
165 <span id="span-row"> 246 <span id="span-row">
166 <span id="span-cell">row0 col0</span> 247 <span id="span-cell">row0 col0</span>
167 <div id="div-cell">row0 col1</div> 248 <div id="div-cell">row0 col1</div>
168 <span id="span-cell">row0 col2</span> 249 <span id="span-cell">row0 col2</span>
169 </span> 250 </span>
170 <div id="div-row"> 251 <div id="div-row">
171 <div id="div-cell">row1 col0</div> 252 <div id="div-cell">row1 col0</div>
172 <span id="span-cell">row1 col1</span> 253 <span id="span-cell">row1 col1</span>
173 <div id="div-cell">row1 col2</div> 254 <div id="div-cell">row1 col2</div>
(...skipping 24 matching lines...) Expand all
198 <span id="span-row"> 279 <span id="span-row">
199 <span id="span-cell">row8 col0</span> 280 <span id="span-cell">row8 col0</span>
200 </span> 281 </span>
201 <div id="div-row"> 282 <div id="div-row">
202 <div id="div-cell">row9 col0</div> 283 <div id="div-cell">row9 col0</div>
203 </div> 284 </div>
204 <div id="div-row"> 285 <div id="div-row">
205 <div id="div-cell">row10 col0</div> 286 <div id="div-cell">row10 col0</div>
206 </div> 287 </div>
207 </div> 288 </div>
208 <h5>Test 8 - Table Similar to CSS table with rowspan.</h5> 289 <h5>Test 7 - Table Similar to CSS table with rowspan.</h5>
209 <table border="1px"> 290 <table border="1px">
210 <tr data-expected-height="39"> 291 <tr data-expected-height="39">
211 <td rowspan=5 style="height:300px">row0 col0</td> 292 <td rowspan=5 style="height:300px">row0 col0</td>
212 <td>row0 col1</td> 293 <td>row0 col1</td>
213 <td>row0 col2</td> 294 <td>row0 col2</td>
214 </tr> 295 </tr>
215 <tr data-expected-height="48"> 296 <tr data-expected-height="48">
216 <td rowspan=3 style="height:200px">row1 col1</td> 297 <td rowspan=3 style="height:200px">row1 col1</td>
217 <td rowspan=2 style="height:100px">row1 col2</td> 298 <td rowspan=2 style="height:100px">row1 col2</td>
218 <td>row1 col3</td> 299 <td>row1 col3</td>
(...skipping 11 matching lines...) Expand all
230 </tr> 311 </tr>
231 <tr data-expected-height="19"> 312 <tr data-expected-height="19">
232 <td>row5 col0</td> 313 <td>row5 col0</td>
233 <td>row5 col1</td> 314 <td>row5 col1</td>
234 <td>row5 col2</td> 315 <td>row5 col2</td>
235 </tr> 316 </tr>
236 <tr data-expected-height="0"> 317 <tr data-expected-height="0">
237 <td rowspan=5 style="height:200px">row6 col0</td> 318 <td rowspan=5 style="height:200px">row6 col0</td>
238 <td rowspan=5 style="height:100px">row6 col1</td> 319 <td rowspan=5 style="height:100px">row6 col1</td>
239 </tr> 320 </tr>
240 <tr data-expected-height="19"> 321 <tr data-expected-height="37">
241 <td>row7 col1</td> 322 <td>row7 col1</td>
242 </tr> 323 </tr>
243 <tr data-expected-height="19"> 324 <tr data-expected-height="38">
244 <td>row8 col1</td> 325 <td>row8 col1</td>
245 </tr> 326 </tr>
246 <tr data-expected-height="19"> 327 <tr data-expected-height="49">
247 <td>row9 col1</td> 328 <td>row9 col1</td>
248 </tr> 329 </tr>
249 <tr data-expected-height="19"> 330 <tr data-expected-height="49">
250 <td>row10 col1</td> 331 <td>row10 col1</td>
251 </tr> 332 </tr>
252 </table> 333 </table>
253 </body> 334 </body>
254 </html> 335 </html>
OLDNEW
« no previous file with comments | « LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-2.html ('k') | LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-3-expected.txt » ('j') | Source/core/rendering/RenderTableSection.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698