JIT precompilated snapshots.

JIT precompilated snapshots.

(Precompiled snapshots with unoptimized code.)

+ ./out/ReleaseX64/dart --package-root=./out/ReleaseX64/packages ./pkg/compiler/lib/src/dart2js.dart /usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript: out.js

real	0m3.299s
user	0m3.197s
sys	0m0.831s

+ ./out/ProductX64/dart_bootstrap --full-snapshot-after-run=/usr/local/google/home/rmacnak/dart3/sdk/app --package-root=./out/ReleaseX64/packages ./pkg/compiler/lib/src/dart2js.dart /usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript: out.js
+ ./out/ProductX64/dart --run-full-snapshot=/usr/local/google/home/rmacnak/dart3/sdk/app --package-root=./out/ReleaseX64/packages ./pkg/compiler/lib/src/dart2js.dart /usr/local/google/home/rmacnak/hello.dart
vm-service: Isolate creation error: (null)
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript: out.js

real	0m1.979s
user	0m1.806s
sys	0m0.581s

+ ./out/ReleaseX64/dart_bootstrap --use_blobs --gen-precompiled-jit-snapshot=/usr/local/google/home/rmacnak/dart3/sdk --package-root=./out/ReleaseX64/packages ./pkg/compiler/lib/src/dart2js.dart /usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript: out.js
VMIsolate(CodeSize): 2699304
Isolate(CodeSize): 5930097
Instructions(CodeSize): 9440176
Total(CodeSize): 18069577
+ ./out/ReleaseX64/dart --use_blobs --run-precompiled-jit-snapshot=/usr/local/google/home/rmacnak/dart3/sdk --package-root=./out/ReleaseX64/packages ./pkg/compiler/lib/src/dart2js.dart /usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript: out.js

real	0m0.994s
user	0m1.259s
sys	0m0.229s

R=asiva@google.com, fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/257b3a82b8d3d1cee57956deb214e6ef1aba3ac1

[rmacnak, 2016-04-29 23:06:43]

Description was changed from

==========
okay without background compilation


More kAppWithJIT versus kAppNoJIT.


Undo "Don't include an object header for instructions in the text section."

This undoes most of b2f3e8efe1f32bacad99ddbedbc434a6102d8be2.

This optimization prevents precompiled code from being disabled and re-enabled,
because disabling causes the code to lose its only reference to its own
instructions. This was okay for precompilated code that ran without a JIT
because it is never disabled, but precompiled code that runs in a JIT will
become disabled when corresponding optimized code is compiled and re-abled after
a deopt.

patch from issue 1925153003 at patchset 40001
(http://crrev.com/1925153003#ps40001)

BUG=
==========

to

==========
JIT precompilated snapshots.

+ ./out/ReleaseX64/dart --package-root=./out/ReleaseX64/packages
./pkg/compiler/lib/src/dart2js.dart /usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript:
out.js

real 0m2.628s
user 0m3.070s
sys  0m0.312s

+ ./out/ReleaseX64/dart_bootstrap --use_blobs
--gen-precompiled-jit-snapshot=/usr/local/google/home/rmacnak/dart3/sdk
--package-root=./out/ReleaseX64/packages ./pkg/compiler/lib/src/dart2js.dart
/usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript:
out.js
VMIsolate(CodeSize): 2699298
Isolate(CodeSize): 5977141
Instructions(CodeSize): 9440176
Total(CodeSize): 18116615
+ ./out/ReleaseX64/dart --use_blobs
--run-precompiled-jit-snapshot=/usr/local/google/home/rmacnak/dart3/sdk
--package-root=./out/ReleaseX64/packages ./pkg/compiler/lib/src/dart2js.dart
/usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript:
out.js

real 0m0.950s
user 0m1.234s
sys  0m0.158s
==========

[rmacnak, 2016-04-29 23:08:16]

Description was changed from

==========
JIT precompilated snapshots.

+ ./out/ReleaseX64/dart --package-root=./out/ReleaseX64/packages
./pkg/compiler/lib/src/dart2js.dart /usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript:
out.js

real 0m2.628s
user 0m3.070s
sys  0m0.312s

+ ./out/ReleaseX64/dart_bootstrap --use_blobs
--gen-precompiled-jit-snapshot=/usr/local/google/home/rmacnak/dart3/sdk
--package-root=./out/ReleaseX64/packages ./pkg/compiler/lib/src/dart2js.dart
/usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript:
out.js
VMIsolate(CodeSize): 2699298
Isolate(CodeSize): 5977141
Instructions(CodeSize): 9440176
Total(CodeSize): 18116615
+ ./out/ReleaseX64/dart --use_blobs
--run-precompiled-jit-snapshot=/usr/local/google/home/rmacnak/dart3/sdk
--package-root=./out/ReleaseX64/packages ./pkg/compiler/lib/src/dart2js.dart
/usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript:
out.js

real 0m0.950s
user 0m1.234s
sys  0m0.158s
==========

to

==========
JIT precompilated snapshots.

+ ./out/ReleaseX64/dart --package-root=./out/ReleaseX64/packages
./pkg/compiler/lib/src/dart2js.dart /usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript:
out.js

real 0m2.628s
user 0m3.070s
sys  0m0.312s

+ ./out/ReleaseX64/dart_bootstrap --use_blobs
--gen-precompiled-jit-snapshot=/usr/local/google/home/rmacnak/dart3/sdk
--package-root=./out/ReleaseX64/packages ./pkg/compiler/lib/src/dart2js.dart
/usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript:
out.js
VMIsolate(CodeSize): 2699298
Isolate(CodeSize): 5977141
Instructions(CodeSize): 9440176
Total(CodeSize): 18116615
+ ./out/ReleaseX64/dart --use_blobs
--run-precompiled-jit-snapshot=/usr/local/google/home/rmacnak/dart3/sdk
--package-root=./out/ReleaseX64/packages ./pkg/compiler/lib/src/dart2js.dart
/usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript:
out.js

real 0m0.950s
user 0m1.234s
sys  0m0.158s
==========

[rmacnak, 2016-04-29 23:20:17]

Description was changed from

==========
JIT precompilated snapshots.

+ ./out/ReleaseX64/dart --package-root=./out/ReleaseX64/packages
./pkg/compiler/lib/src/dart2js.dart /usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript:
out.js

real 0m2.628s
user 0m3.070s
sys  0m0.312s

+ ./out/ReleaseX64/dart_bootstrap --use_blobs
--gen-precompiled-jit-snapshot=/usr/local/google/home/rmacnak/dart3/sdk
--package-root=./out/ReleaseX64/packages ./pkg/compiler/lib/src/dart2js.dart
/usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript:
out.js
VMIsolate(CodeSize): 2699298
Isolate(CodeSize): 5977141
Instructions(CodeSize): 9440176
Total(CodeSize): 18116615
+ ./out/ReleaseX64/dart --use_blobs
--run-precompiled-jit-snapshot=/usr/local/google/home/rmacnak/dart3/sdk
--package-root=./out/ReleaseX64/packages ./pkg/compiler/lib/src/dart2js.dart
/usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript:
out.js

real 0m0.950s
user 0m1.234s
sys  0m0.158s
==========

to

==========
JIT precompilated snapshots.

(Precompiled snapshots with unoptimized code.)

+ ./out/ReleaseX64/dart --package-root=./out/ReleaseX64/packages
./pkg/compiler/lib/src/dart2js.dart /usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript:
out.js

real	0m3.299s
user	0m3.197s
sys	0m0.831s

+ ./out/ProductX64/dart_bootstrap
--full-snapshot-after-run=/usr/local/google/home/rmacnak/dart3/sdk/app
--package-root=./out/ReleaseX64/packages ./pkg/compiler/lib/src/dart2js.dart
/usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript:
out.js
+ ./out/ProductX64/dart
--run-full-snapshot=/usr/local/google/home/rmacnak/dart3/sdk/app
--package-root=./out/ReleaseX64/packages ./pkg/compiler/lib/src/dart2js.dart
/usr/local/google/home/rmacnak/hello.dart
vm-service: Isolate creation error: (null)
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript:
out.js

real	0m1.979s
user	0m1.806s
sys	0m0.581s

+ ./out/ReleaseX64/dart_bootstrap --use_blobs
--gen-precompiled-jit-snapshot=/usr/local/google/home/rmacnak/dart3/sdk
--package-root=./out/ReleaseX64/packages ./pkg/compiler/lib/src/dart2js.dart
/usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript:
out.js
VMIsolate(CodeSize): 2699304
Isolate(CodeSize): 5930097
Instructions(CodeSize): 9440176
Total(CodeSize): 18069577
+ ./out/ReleaseX64/dart --use_blobs
--run-precompiled-jit-snapshot=/usr/local/google/home/rmacnak/dart3/sdk
--package-root=./out/ReleaseX64/packages ./pkg/compiler/lib/src/dart2js.dart
/usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript:
out.js

real	0m0.994s
user	0m1.259s
sys	0m0.229s
==========

[rmacnak, 2016-04-29 23:20:42]

rmacnak@google.com changed reviewers:
+ asiva@google.com, fschneider@google.com

[rmacnak, 2016-04-29 23:20:43]

Depends on https://chromiumcodereview.appspot.com/1925153003/.

[Florian Schneider, 2016-05-03 09:20:35]

https://codereview.chromium.org/1938653002/diff/40001/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/1938653002/diff/40001/runtime/include/dart_ap...
runtime/include/dart_api.h:2980: DART_EXPORT Dart_Handle Dart_PrecompileJIT();
When would you use this function without Dart_CreatePrecompiledJITSnapshotBlob?

Would one API function (Dart_CreatePrecompiledJITSnapshot) that does both be
enough?

https://codereview.chromium.org/1938653002/diff/40001/runtime/vm/dart.cc
File runtime/vm/dart.cc (right):

https://codereview.chromium.org/1938653002/diff/40001/runtime/vm/dart.cc#newc...
runtime/vm/dart.cc:203: #if !defined(DART_PRECOMPILED_RUNTIME)
For consistency I'd swap if- and else block to avoid negation.

https://codereview.chromium.org/1938653002/diff/40001/runtime/vm/dart_api_imp...
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/1938653002/diff/40001/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:6223: error = cls.EnsureIsFinalized(T);
Why do all classes need to be finalized?

[rmacnak, 2016-05-03 19:54:21]

https://codereview.chromium.org/1938653002/diff/40001/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/1938653002/diff/40001/runtime/include/dart_ap...
runtime/include/dart_api.h:2980: DART_EXPORT Dart_Handle Dart_PrecompileJIT();
On 2016/05/03 09:20:35, Florian Schneider wrote:
> When would you use this function without
Dart_CreatePrecompiledJITSnapshotBlob?
> 
> Would one API function (Dart_CreatePrecompiledJITSnapshot) that does both be
> enough?

I expect we'll get to a place with something like

host:
   Dart_PrecompileJIT()  "more conservative tree-shake"
   Dart_CreateSnapshot();
target:
   first launch
   Dart_Initialize(snapshot without code)
   end of first frame
   Dart_CreatePrecompiledJITSnapshot()
   second launch
   Dart_Initialize(snapshot with the code for needed for startup)

https://codereview.chromium.org/1938653002/diff/40001/runtime/vm/dart.cc
File runtime/vm/dart.cc (right):

https://codereview.chromium.org/1938653002/diff/40001/runtime/vm/dart.cc#newc...
runtime/vm/dart.cc:203: #if !defined(DART_PRECOMPILED_RUNTIME)
On 2016/05/03 09:20:35, Florian Schneider wrote:
> For consistency I'd swap if- and else block to avoid negation.

Done.

https://codereview.chromium.org/1938653002/diff/40001/runtime/vm/dart_api_imp...
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/1938653002/diff/40001/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:6223: error = cls.EnsureIsFinalized(T);
On 2016/05/03 09:20:35, Florian Schneider wrote:
> Why do all classes need to be finalized?

It's not required now, the idea is to do some work ahead of time. In the future
a tree-shaking step should happen here.

[Florian Schneider, 2016-05-03 20:16:07]

lgtm

[siva, 2016-05-03 23:28:39]

https://chromiumcodereview.appspot.com/1938653002/diff/80001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://chromiumcodereview.appspot.com/1938653002/diff/80001/runtime/bin/main...
runtime/bin/main.cc:85: static bool run_precompiled_jit_snapshot = false;
I was wondering if run_full_snapshot and run_precompiled_jit_snapshot could be
combined and if the instructions snapshot exists in the specified directory then
we load it up otherwise we just continue without instructions.

That way we won't have too many similar options.

https://chromiumcodereview.appspot.com/1938653002/diff/80001/runtime/bin/main...
runtime/bin/main.cc:568: { "--gen-precompiled-jit-snapshot",
ProcessGenPrecompiledJITSnapshotOption },
Similarly I was wondering if we could group the gen-precompiled-jit-snapshot and
full-snapshot-after-run into a single option e.g:

--gen-app-snapshot=<filename>[,with-instrs][,after-run]

or other creative ways you could think of.

[rmacnak, 2016-05-04 18:21:22]

On 2016/05/03 23:28:39, siva wrote:
>
https://chromiumcodereview.appspot.com/1938653002/diff/80001/runtime/bin/main.cc
> File runtime/bin/main.cc (right):
> 
>
https://chromiumcodereview.appspot.com/1938653002/diff/80001/runtime/bin/main...
> runtime/bin/main.cc:85: static bool run_precompiled_jit_snapshot = false;
> I was wondering if run_full_snapshot and run_precompiled_jit_snapshot could be
> combined and if the instructions snapshot exists in the specified directory
then
> we load it up otherwise we just continue without instructions.
> 
> That way we won't have too many similar options.
> 
>
https://chromiumcodereview.appspot.com/1938653002/diff/80001/runtime/bin/main...
> runtime/bin/main.cc:568: { "--gen-precompiled-jit-snapshot",
> ProcessGenPrecompiledJITSnapshotOption },
> Similarly I was wondering if we could group the gen-precompiled-jit-snapshot
and
> full-snapshot-after-run into a single option e.g:
> 
> --gen-app-snapshot=<filename>[,with-instrs][,after-run]
> 
> or other creative ways you could think of.

Agreed, but this is involved enough that I'd like it to be a separate CL
(started as https://codereview.chromium.org/1947783003).

[siva, 2016-05-05 00:08:32]

Ok we can do the option changes in a new CL.

Rest of the changes LGTM with some comments.

https://chromiumcodereview.appspot.com/1938653002/diff/80001/runtime/vm/dart.cc
File runtime/vm/dart.cc (right):

https://chromiumcodereview.appspot.com/1938653002/diff/80001/runtime/vm/dart....
runtime/vm/dart.cc:50: Snapshot::Kind Dart::snapshot_kind_ = Snapshot::kNone;
Can we initialize this to Snapshot::kInvalid so that we now that Dart_InitOnce
is run before any code makes any decisions based on the snapshot kind.

https://chromiumcodereview.appspot.com/1938653002/diff/80001/runtime/vm/dart_...
File runtime/vm/dart_api_impl.cc (right):

https://chromiumcodereview.appspot.com/1938653002/diff/80001/runtime/vm/dart_...
runtime/vm/dart_api_impl.cc:6211:
GrowableObjectArray::Handle(I->object_store()->libraries());
Handle(Z, I->object_store()->libraries());

https://chromiumcodereview.appspot.com/1938653002/diff/80001/runtime/vm/dart_...
runtime/vm/dart_api_impl.cc:6214: Error& error = Error::Handle();
Ditto comment for these handles use Handle(Z)

https://chromiumcodereview.appspot.com/1938653002/diff/80001/runtime/vm/raw_o...
File runtime/vm/raw_object_snapshot.cc (right):

https://chromiumcodereview.appspot.com/1938653002/diff/80001/runtime/vm/raw_o...
runtime/vm/raw_object_snapshot.cc:757: func.ClearICDataArray();
why do you have to clear the IC data array here we are anyway reading the ic
data and assigning it below.

https://chromiumcodereview.appspot.com/1938653002/diff/80001/runtime/vm/raw_o...
runtime/vm/raw_object_snapshot.cc:758: func.ClearCode();
Ditto question about ClearCode can we do it conditionally based on the code
object we read?

https://chromiumcodereview.appspot.com/1938653002/diff/80001/runtime/vm/raw_o...
runtime/vm/raw_object_snapshot.cc:1453: ASSERT(pointer_offsets_length == 0);
Why did you change this to an assert from FATAL?

https://chromiumcodereview.appspot.com/1938653002/diff/80001/runtime/vm/raw_o...
runtime/vm/raw_object_snapshot.cc:1463: ASSERT(!is_optimized);
shouldn't this ASSERT be a FATAL instead?

https://chromiumcodereview.appspot.com/1938653002/diff/80001/runtime/vm/raw_o...
runtime/vm/raw_object_snapshot.cc:1958: ContextScope& context_scope =
ContextScope::ZoneHandle();
ZoneHandle(zone());

[rmacnak, 2016-05-05 01:47:03]

https://codereview.chromium.org/1938653002/diff/80001/runtime/vm/dart.cc
File runtime/vm/dart.cc (right):

https://codereview.chromium.org/1938653002/diff/80001/runtime/vm/dart.cc#newc...
runtime/vm/dart.cc:50: Snapshot::Kind Dart::snapshot_kind_ = Snapshot::kNone;
On 2016/05/05 00:08:32, siva wrote:
> Can we initialize this to Snapshot::kInvalid so that we now that Dart_InitOnce
> is run before any code makes any decisions based on the snapshot kind.

Done.

https://codereview.chromium.org/1938653002/diff/80001/runtime/vm/dart_api_imp...
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/1938653002/diff/80001/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:6211:
GrowableObjectArray::Handle(I->object_store()->libraries());
On 2016/05/05 00:08:32, siva wrote:
> Handle(Z, I->object_store()->libraries());

Done.

https://codereview.chromium.org/1938653002/diff/80001/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:6214: Error& error = Error::Handle();
On 2016/05/05 00:08:32, siva wrote:
> Ditto comment for these handles use Handle(Z)

Done.

https://codereview.chromium.org/1938653002/diff/80001/runtime/vm/raw_object_s...
File runtime/vm/raw_object_snapshot.cc (right):

https://codereview.chromium.org/1938653002/diff/80001/runtime/vm/raw_object_s...
runtime/vm/raw_object_snapshot.cc:757: func.ClearICDataArray();
On 2016/05/05 00:08:32, siva wrote:
> why do you have to clear the IC data array here we are anyway reading the ic
> data and assigning it below.

ClearICData satisfied assert in ClearCode below.

https://codereview.chromium.org/1938653002/diff/80001/runtime/vm/raw_object_s...
runtime/vm/raw_object_snapshot.cc:758: func.ClearCode();
On 2016/05/05 00:08:32, siva wrote:
> Ditto question about ClearCode can we do it conditionally based on the code
> object we read?

Yes, that works.

https://codereview.chromium.org/1938653002/diff/80001/runtime/vm/raw_object_s...
runtime/vm/raw_object_snapshot.cc:1453: ASSERT(pointer_offsets_length == 0);
On 2016/05/05 00:08:32, siva wrote:
> Why did you change this to an assert from FATAL?

Was thinking the fatals on --precompilation would hit first, but that won't
happen for a JIT snapshot.

https://codereview.chromium.org/1938653002/diff/80001/runtime/vm/raw_object_s...
runtime/vm/raw_object_snapshot.cc:1463: ASSERT(!is_optimized);
On 2016/05/05 00:08:32, siva wrote:
> shouldn't this ASSERT be a FATAL instead?

Done.

https://codereview.chromium.org/1938653002/diff/80001/runtime/vm/raw_object_s...
runtime/vm/raw_object_snapshot.cc:1958: ContextScope& context_scope =
ContextScope::ZoneHandle();
On 2016/05/05 00:08:32, siva wrote:
> ZoneHandle(zone());

Done.

[rmacnak, 2016-05-05 01:47:41]

Description was changed from

==========
JIT precompilated snapshots.

(Precompiled snapshots with unoptimized code.)

+ ./out/ReleaseX64/dart --package-root=./out/ReleaseX64/packages
./pkg/compiler/lib/src/dart2js.dart /usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript:
out.js

real	0m3.299s
user	0m3.197s
sys	0m0.831s

+ ./out/ProductX64/dart_bootstrap
--full-snapshot-after-run=/usr/local/google/home/rmacnak/dart3/sdk/app
--package-root=./out/ReleaseX64/packages ./pkg/compiler/lib/src/dart2js.dart
/usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript:
out.js
+ ./out/ProductX64/dart
--run-full-snapshot=/usr/local/google/home/rmacnak/dart3/sdk/app
--package-root=./out/ReleaseX64/packages ./pkg/compiler/lib/src/dart2js.dart
/usr/local/google/home/rmacnak/hello.dart
vm-service: Isolate creation error: (null)
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript:
out.js

real	0m1.979s
user	0m1.806s
sys	0m0.581s

+ ./out/ReleaseX64/dart_bootstrap --use_blobs
--gen-precompiled-jit-snapshot=/usr/local/google/home/rmacnak/dart3/sdk
--package-root=./out/ReleaseX64/packages ./pkg/compiler/lib/src/dart2js.dart
/usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript:
out.js
VMIsolate(CodeSize): 2699304
Isolate(CodeSize): 5930097
Instructions(CodeSize): 9440176
Total(CodeSize): 18069577
+ ./out/ReleaseX64/dart --use_blobs
--run-precompiled-jit-snapshot=/usr/local/google/home/rmacnak/dart3/sdk
--package-root=./out/ReleaseX64/packages ./pkg/compiler/lib/src/dart2js.dart
/usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript:
out.js

real	0m0.994s
user	0m1.259s
sys	0m0.229s
==========

to

==========
JIT precompilated snapshots.

(Precompiled snapshots with unoptimized code.)

+ ./out/ReleaseX64/dart --package-root=./out/ReleaseX64/packages
./pkg/compiler/lib/src/dart2js.dart /usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript:
out.js

real	0m3.299s
user	0m3.197s
sys	0m0.831s

+ ./out/ProductX64/dart_bootstrap
--full-snapshot-after-run=/usr/local/google/home/rmacnak/dart3/sdk/app
--package-root=./out/ReleaseX64/packages ./pkg/compiler/lib/src/dart2js.dart
/usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript:
out.js
+ ./out/ProductX64/dart
--run-full-snapshot=/usr/local/google/home/rmacnak/dart3/sdk/app
--package-root=./out/ReleaseX64/packages ./pkg/compiler/lib/src/dart2js.dart
/usr/local/google/home/rmacnak/hello.dart
vm-service: Isolate creation error: (null)
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript:
out.js

real	0m1.979s
user	0m1.806s
sys	0m0.581s

+ ./out/ReleaseX64/dart_bootstrap --use_blobs
--gen-precompiled-jit-snapshot=/usr/local/google/home/rmacnak/dart3/sdk
--package-root=./out/ReleaseX64/packages ./pkg/compiler/lib/src/dart2js.dart
/usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript:
out.js
VMIsolate(CodeSize): 2699304
Isolate(CodeSize): 5930097
Instructions(CodeSize): 9440176
Total(CodeSize): 18069577
+ ./out/ReleaseX64/dart --use_blobs
--run-precompiled-jit-snapshot=/usr/local/google/home/rmacnak/dart3/sdk
--package-root=./out/ReleaseX64/packages ./pkg/compiler/lib/src/dart2js.dart
/usr/local/google/home/rmacnak/hello.dart
Dart file (/usr/local/google/home/rmacnak/hello.dart) compiled to JavaScript:
out.js

real	0m0.994s
user	0m1.259s
sys	0m0.229s

R=asiva@google.com, fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/257b3a82b8d3d1cee57956deb214e6ef1aba3ac1
==========

[rmacnak, 2016-05-05 01:47:46]

Committed patchset #6 (id:100001) manually as
257b3a82b8d3d1cee57956deb214e6ef1aba3ac1 (presubmit successful).