Simplify command line options for creating snapshots.

Simplify command line options for creating snapshots.

Also makes codeless app snapshots work in debug and release modes.

dart --snapshot=file.snap [--snapshot-kind=script] script.dart
dart file.snap

dart_bootstrap --snapshot=dir --snapshot-kind=app-after-run script.dart
dart --run-app-snapshot=dir script.dart

dart_bootstrap --snapshot=dir --snapshot-kind=app-jit-after-run script.dart
dart --run-app-snapshot=dir script.dart

dart_bootstrap --snapshot=dir --snapshot-kind=app-aot script.dart
dart_precompiled_runtime --run-app-snapshot=dir script.dart

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/7546ef1709578dc7d9298d1d9e56c67396087469

[rmacnak, 2016-05-04 23:32:01]

Description was changed from

==========
Simplify command line options for creating snapshots.

dart --snapshot=file [--snapshot-kind=script]        script.dart
dart --snapshot=dir  --snapshot-kind=precompiled     script.dart
dart --snapshot=dir  --snapshot-kind=precompiled-jit script.dart
dart --snapshot=dir  --snapshot-kind=full-after-run  script.dart
==========

to

==========
Simplify command line options for creating snapshots.

dart --snapshot=file.snap [--snapshot-kind=script] script.dart
dart file.snap

dart_bootstrap --snapshot=dir --snapshot-kind=full-after-run script.dart
dart --run-full-snapshot=dir script.dart

dart_bootstrap --snapshot=dir --snapshot-kind=precompiled-jit script.dart
dart --run-full-snapshot=dir script.dart

dart_bootstrap --snapshot=dir --snapshot-kind=precompiled script.dart
dart_precompiled_runtime --run-full-snapshot=dir script.dart
==========

[rmacnak, 2016-05-05 18:10:32]

Description was changed from

==========
Simplify command line options for creating snapshots.

dart --snapshot=file.snap [--snapshot-kind=script] script.dart
dart file.snap

dart_bootstrap --snapshot=dir --snapshot-kind=full-after-run script.dart
dart --run-full-snapshot=dir script.dart

dart_bootstrap --snapshot=dir --snapshot-kind=precompiled-jit script.dart
dart --run-full-snapshot=dir script.dart

dart_bootstrap --snapshot=dir --snapshot-kind=precompiled script.dart
dart_precompiled_runtime --run-full-snapshot=dir script.dart
==========

to

==========
Simplify command line options for creating snapshots.

Also makes codeless app snapshots work in debug and release modes.

dart --snapshot=file.snap [--snapshot-kind=script] script.dart
dart file.snap

dart_bootstrap --snapshot=dir --snapshot-kind=full-after-run script.dart
dart --run-full-snapshot=dir script.dart

dart_bootstrap --snapshot=dir --snapshot-kind=precompiled-jit script.dart
dart --run-full-snapshot=dir script.dart

dart_bootstrap --snapshot=dir --snapshot-kind=precompiled script.dart
dart_precompiled_runtime --run-full-snapshot=dir script.dart
==========

[rmacnak, 2016-05-05 18:12:56]

rmacnak@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-05-05 22:38:44]

LGTM with some comments.

Please send email to dart-vm group with the new options as some folks in Aarhus
have been experimenting with --full-snapshot-after-run

https://codereview.chromium.org/1947783003/diff/80001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/1947783003/diff/80001/runtime/bin/main.cc#new...
runtime/bin/main.cc:361: }
As discussed offline, I am wondering if this list could be

script
full (current gen_snapshot, i.e root library is null)
app
app-after-run
appJIT
appJIT-after-run
appAOT

also should we have an error message here for an unknown kind?

https://codereview.chromium.org/1947783003/diff/80001/runtime/bin/main.cc#new...
runtime/bin/main.cc:888: "  loads Dart script and generates a snapshot in the
specified file\n"
we should remember to add help information here for the new options being added
once we are more stable, maybe we hold off until it stabilizes.

https://codereview.chromium.org/1947783003/diff/80001/runtime/bin/main.cc#new...
runtime/bin/main.cc:1141: return symbol;
why do you have the NULL check and return NULL why not just

return symbol;

https://codereview.chromium.org/1947783003/diff/80001/runtime/bin/main.cc#new...
runtime/bin/main.cc:1360: // be included in the precompiled snapshot.
the comment says precompiled snapshot but should probably be in the full
application snapshot?

[rmacnak, 2016-05-06 00:17:45]

Description was changed from

==========
Simplify command line options for creating snapshots.

Also makes codeless app snapshots work in debug and release modes.

dart --snapshot=file.snap [--snapshot-kind=script] script.dart
dart file.snap

dart_bootstrap --snapshot=dir --snapshot-kind=full-after-run script.dart
dart --run-full-snapshot=dir script.dart

dart_bootstrap --snapshot=dir --snapshot-kind=precompiled-jit script.dart
dart --run-full-snapshot=dir script.dart

dart_bootstrap --snapshot=dir --snapshot-kind=precompiled script.dart
dart_precompiled_runtime --run-full-snapshot=dir script.dart
==========

to

==========
Simplify command line options for creating snapshots.

Also makes codeless app snapshots work in debug and release modes.

dart --snapshot=file.snap [--snapshot-kind=script] script.dart
dart file.snap

dart_bootstrap --snapshot=dir --snapshot-kind=app-after-run script.dart
dart --run-app-snapshot=dir script.dart

dart_bootstrap --snapshot=dir --snapshot-kind=app-jit-after-run script.dart
dart --run-app-snapshot=dir script.dart

dart_bootstrap --snapshot=dir --snapshot-kind=app-aot script.dart
dart_precompiled_runtime --run-app-snapshot=dir script.dart
==========

[rmacnak, 2016-05-06 00:19:47]

PTAL at revised names.

https://codereview.chromium.org/1947783003/diff/80001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/1947783003/diff/80001/runtime/bin/main.cc#new...
runtime/bin/main.cc:361: }
On 2016/05/05 22:38:43, siva wrote:
> As discussed offline, I am wondering if this list could be
> 
> script
> full (current gen_snapshot, i.e root library is null)
> app
> app-after-run
> appJIT
> appJIT-after-run
> appAOT

Updated the names and changed --run-full-snapshot to --run-app-snapshot.

> 
> also should we have an error message here for an unknown kind?

Added.

https://codereview.chromium.org/1947783003/diff/80001/runtime/bin/main.cc#new...
runtime/bin/main.cc:1141: return symbol;
On 2016/05/05 22:38:43, siva wrote:
> why do you have the NULL check and return NULL why not just
> 
> return symbol;
> 

Done.

https://codereview.chromium.org/1947783003/diff/80001/runtime/bin/main.cc#new...
runtime/bin/main.cc:1360: // be included in the precompiled snapshot.
On 2016/05/05 22:38:44, siva wrote:
> the comment says precompiled snapshot but should probably be in the full
> application snapshot?

Changed to 'app snapshot'

[siva, 2016-05-06 18:18:28]

lgtm

[rmacnak, 2016-05-06 19:40:11]

Description was changed from

==========
Simplify command line options for creating snapshots.

Also makes codeless app snapshots work in debug and release modes.

dart --snapshot=file.snap [--snapshot-kind=script] script.dart
dart file.snap

dart_bootstrap --snapshot=dir --snapshot-kind=app-after-run script.dart
dart --run-app-snapshot=dir script.dart

dart_bootstrap --snapshot=dir --snapshot-kind=app-jit-after-run script.dart
dart --run-app-snapshot=dir script.dart

dart_bootstrap --snapshot=dir --snapshot-kind=app-aot script.dart
dart_precompiled_runtime --run-app-snapshot=dir script.dart
==========

to

==========
Simplify command line options for creating snapshots.

Also makes codeless app snapshots work in debug and release modes.

dart --snapshot=file.snap [--snapshot-kind=script] script.dart
dart file.snap

dart_bootstrap --snapshot=dir --snapshot-kind=app-after-run script.dart
dart --run-app-snapshot=dir script.dart

dart_bootstrap --snapshot=dir --snapshot-kind=app-jit-after-run script.dart
dart --run-app-snapshot=dir script.dart

dart_bootstrap --snapshot=dir --snapshot-kind=app-aot script.dart
dart_precompiled_runtime --run-app-snapshot=dir script.dart

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7546ef1709578dc7d9298d1d9e56c67396087469
==========

[rmacnak, 2016-05-06 19:40:13]

Committed patchset #7 (id:100001) manually as
7546ef1709578dc7d9298d1d9e56c67396087469 (presubmit successful).