Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1938413002: [keys] Moving property/keys related methods to KeyAccumulator in keys.cc (Closed)

Created:
4 years, 7 months ago by Camillo Bruni
Modified:
4 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com, caitp (gmail)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[keys] Moving property/keys related methods to KeyAccumulator in keys.cc The Great Keys Migration: This is part of a bigger effort to centralize optimizations for key collections in a central place. This necessary to avoid the penalty that would be introduced by fixing shadowed property iteration. BUG=v8:4758, v8:705 LOG=N Committed: https://crrev.com/c736a452575f406c9a05a8c202b0708cb60d43e5 Cr-Commit-Position: refs/heads/master@{#35991}

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : merging with master #

Patch Set 4 : fixing wrong macro #

Total comments: 3

Patch Set 5 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+490 lines, -486 lines) Patch
M src/isolate.h View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M src/keys.h View 1 2 4 chunks +19 lines, -3 lines 0 comments Download
M src/keys.cc View 1 2 3 4 6 chunks +420 lines, -3 lines 0 comments Download
M src/messages.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M src/objects.h View 1 2 1 chunk +0 lines, -12 lines 0 comments Download
M src/objects.cc View 1 2 3 19 chunks +38 lines, -466 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 24 (13 generated)
Camillo Bruni
PTAL - Mostly moving stuff from objects.cc to keys.cc - changed methods to use this ...
4 years, 7 months ago (2016-05-03 11:04:48 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938413002/20001
4 years, 7 months ago (2016-05-03 11:08:57 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/17094) v8_linux_dbg_ng on ...
4 years, 7 months ago (2016-05-03 11:10:10 UTC) #9
Camillo Bruni
On 2016/05/03 at 11:08:57, commit-bot wrote: > Dry run: CQ is trying da patch. Follow ...
4 years, 7 months ago (2016-05-03 11:18:05 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938413002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938413002/40001
4 years, 7 months ago (2016-05-03 11:43:03 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938413002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938413002/60001
4 years, 7 months ago (2016-05-03 12:03:49 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 12:33:04 UTC) #17
Jakob Kummerow
LGTM with a few nits. (Reviewed in detail what appeared to have changed, mostly rubberstamping ...
4 years, 7 months ago (2016-05-03 14:56:13 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938413002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938413002/80001
4 years, 7 months ago (2016-05-03 15:04:08 UTC) #21
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-03 15:29:37 UTC) #22
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 15:30:55 UTC) #24
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/c736a452575f406c9a05a8c202b0708cb60d43e5
Cr-Commit-Position: refs/heads/master@{#35991}

Powered by Google App Engine
This is Rietveld 408576698