[keys] Moving property/keys related methods to KeyAccumulator in keys.cc

[keys] Moving property/keys related methods to KeyAccumulator in keys.cc

The Great Keys Migration:
This is part of a bigger effort to centralize optimizations for key collections
in a central place. This necessary to avoid the penalty that would be introduced
by fixing shadowed property iteration.

BUG=v8:4758, v8:705
LOG=N

Committed: https://crrev.com/c736a452575f406c9a05a8c202b0708cb60d43e5
Cr-Commit-Position: refs/heads/master@{#35991}

[Camillo Bruni, 2016-05-03 10:00:05]

Description was changed from

==========
[keys] Moving property/keys related methods to KeyAccumulator in keys.cc

This is part of a bigger effort to centralize optimizations for key collections
in a central place. This necessary to avoid the penalty that would be introduced
by fixing shadowed property iteration (v8:705).

BUG=v8:4758, v8:705
==========

to

==========
[keys] Moving property/keys related methods to KeyAccumulator in keys.cc

The Great Keys Migration:
This is part of a bigger effort to centralize optimizations for key collections
in a central place. This necessary to avoid the penalty that would be introduced
by fixing shadowed property iteration (v8:705).

BUG=v8:4758, v8:705
==========

[Camillo Bruni, 2016-05-03 10:43:01]

Description was changed from

==========
[keys] Moving property/keys related methods to KeyAccumulator in keys.cc

The Great Keys Migration:
This is part of a bigger effort to centralize optimizations for key collections
in a central place. This necessary to avoid the penalty that would be introduced
by fixing shadowed property iteration (v8:705).

BUG=v8:4758, v8:705
==========

to

==========
[keys] Moving property/keys related methods to KeyAccumulator in keys.cc

The Great Keys Migration:
This is part of a bigger effort to centralize optimizations for key collections
in a central place. This necessary to avoid the penalty that would be introduced
by fixing shadowed property iteration (v8:705).

BUG=v8:4758, v8:705
LOG=N
==========

[Camillo Bruni, 2016-05-03 10:43:19]

Description was changed from

==========
[keys] Moving property/keys related methods to KeyAccumulator in keys.cc

The Great Keys Migration:
This is part of a bigger effort to centralize optimizations for key collections
in a central place. This necessary to avoid the penalty that would be introduced
by fixing shadowed property iteration (v8:705).

BUG=v8:4758, v8:705
LOG=N
==========

to

==========
[keys] Moving property/keys related methods to KeyAccumulator in keys.cc

The Great Keys Migration:
This is part of a bigger effort to centralize optimizations for key collections
in a central place. This necessary to avoid the penalty that would be introduced
by fixing shadowed property iteration.

BUG=v8:4758, v8:705
LOG=N
==========

[Camillo Bruni, 2016-05-03 11:04:47]

cbruni@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Camillo Bruni, 2016-05-03 11:04:48]

PTAL
- Mostly moving stuff from objects.cc to keys.cc
- changed methods to use this instead of explicitely passing the accumulator
- changed methods to use the filter_ instead of passing it along everywhere

[Camillo Bruni, 2016-05-03 11:08:52]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-03 11:08:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1938413002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1938413002/20001

[commit-bot: I haz the power, 2016-05-03 11:10:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 11:10:10]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/5209)

[Camillo Bruni, 2016-05-03 11:18:05]

On 2016/05/03 at 11:08:57, commit-bot wrote:
> Dry run: CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1938413002/20001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1938413002/20001

currently working on merging master.

[Camillo Bruni, 2016-05-03 11:42:55]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-03 11:43:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1938413002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1938413002/40001

[Camillo Bruni, 2016-05-03 11:44:04]

The CQ bit was unchecked by cbruni@chromium.org

[Camillo Bruni, 2016-05-03 12:03:39]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-03 12:03:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1938413002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1938413002/60001

[commit-bot: I haz the power, 2016-05-03 12:33:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 12:33:04]

Dry run: This issue passed the CQ dry run.

[Jakob Kummerow, 2016-05-03 14:56:13]

LGTM with a few nits. (Reviewed in detail what appeared to have changed, mostly
rubberstamping the parts that were just moved around.)

https://codereview.chromium.org/1938413002/diff/60001/src/keys.cc
File src/keys.cc (right):

https://codereview.chromium.org/1938413002/diff/60001/src/keys.cc#newcode13
src/keys.cc:13: #include "src/objects.h"
nit: no need to include objects.h if you already have objects-inl.h

https://codereview.chromium.org/1938413002/diff/60001/src/keys.cc#newcode318
src/keys.cc:318: // Helper function for JSReceiver::GetKeys() below. Can be
called recursively.
nit: outdated comment

https://codereview.chromium.org/1938413002/diff/60001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1938413002/diff/60001/src/objects.cc#newcode1...
src/objects.cc:16136: Handle<Name>>>
beautiful! :-)

[Camillo Bruni, 2016-05-03 15:04:02]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-05-03 15:04:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1938413002/#ps80001
(title: "nits")

[commit-bot: I haz the power, 2016-05-03 15:04:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1938413002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1938413002/80001

[commit-bot: I haz the power, 2016-05-03 15:29:37]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-03 15:30:54]

Description was changed from

==========
[keys] Moving property/keys related methods to KeyAccumulator in keys.cc

The Great Keys Migration:
This is part of a bigger effort to centralize optimizations for key collections
in a central place. This necessary to avoid the penalty that would be introduced
by fixing shadowed property iteration.

BUG=v8:4758, v8:705
LOG=N
==========

to

==========
[keys] Moving property/keys related methods to KeyAccumulator in keys.cc

The Great Keys Migration:
This is part of a bigger effort to centralize optimizations for key collections
in a central place. This necessary to avoid the penalty that would be introduced
by fixing shadowed property iteration.

BUG=v8:4758, v8:705
LOG=N

Committed: https://crrev.com/c736a452575f406c9a05a8c202b0708cb60d43e5
Cr-Commit-Position: refs/heads/master@{#35991}
==========

[commit-bot: I haz the power, 2016-05-03 15:30:55]

Patchset 5 (id:??) landed as
https://crrev.com/c736a452575f406c9a05a8c202b0708cb60d43e5
Cr-Commit-Position: refs/heads/master@{#35991}