src/runtime/runtime-array.cc - Issue 1938413002: [keys] Moving property/keys related methods to KeyAccumulator in keys.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-array.cc

Issue 1938413002: [keys] Moving property/keys related methods to KeyAccumulator in keys.cc (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: nits Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-array.cc

diff --git a/src/runtime/runtime-array.cc b/src/runtime/runtime-array.cc

index 8315bfbc88ca781b7a22af4303764feb24d4a36e..59c86951c5d7826573bcf0d9ca67c64d8cd0bd9b 100644

--- a/src/runtime/runtime-array.cc

+++ b/src/runtime/runtime-array.cc

@@ -213,7 +213,7 @@ RUNTIME_FUNCTION(Runtime_GetArrayKeys) {

}

accumulator.NextPrototype();

Handle<JSObject> current = PrototypeIterator::GetCurrent<JSObject>(iter);

- JSObject::CollectOwnElementKeys(current, &accumulator, ALL_PROPERTIES);

+ accumulator.CollectOwnElementKeys(current);

}

// Erase any keys >= length.

Handle<FixedArray> keys = accumulator.GetKeys(KEEP_NUMBERS);

« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »