third_party/WebKit/Source/modules/mediasource/URLMediaSource.cpp - Issue 1938183002: Deprecate URL.createObjectURL/revokeObjectURL in Service Workers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediasource/URLMediaSource.cpp

Issue 1938183002: Deprecate URL.createObjectURL/revokeObjectURL in Service Workers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: derp Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/UseCounter.h ('k') | third_party/WebKit/Source/modules/mediastream/URLMediaStream.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediasource/URLMediaSource.cpp

diff --git a/third_party/WebKit/Source/modules/mediasource/URLMediaSource.cpp b/third_party/WebKit/Source/modules/mediasource/URLMediaSource.cpp

index b7bd93243edc4a651a94e7b76627d0a232c8ccb6..bfee6914f157f6dc892efab56f1384fb9589e32e 100644

--- a/third_party/WebKit/Source/modules/mediasource/URLMediaSource.cpp

+++ b/third_party/WebKit/Source/modules/mediasource/URLMediaSource.cpp

@@ -31,6 +31,8 @@

#include "modules/mediasource/URLMediaSource.h"

#include "core/dom/DOMURL.h"

+#include "core/frame/Deprecation.h"

+#include "core/frame/UseCounter.h"

#include "modules/mediasource/MediaSource.h"

namespace blink {

@@ -40,8 +42,12 @@ String URLMediaSource::createObjectURL(ExecutionContext* executionContext, Media

// Since WebWorkers cannot obtain MediaSource objects, we should be on the main thread.

ASSERT(isMainThread());

+ if (executionContext && executionContext->isServiceWorkerGlobalScope())

+ Deprecation::countDeprecation(executionContext, UseCounter::URLMethodCreateObjectURLServiceWorker);

if (!executionContext)

return String();

return DOMURL::createPublicURL(executionContext, source);

}