Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Side by Side Diff: third_party/WebKit/Source/core/fileapi/URLFileAPI.cpp

Issue 1938183002: Deprecate URL.createObjectURL/revokeObjectURL in Service Workers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: derp Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/Deprecation.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/fileapi/URLFileAPI.h" 5 #include "core/fileapi/URLFileAPI.h"
6 6
7 #include "bindings/core/v8/ExceptionState.h" 7 #include "bindings/core/v8/ExceptionState.h"
8 #include "core/dom/DOMURL.h" 8 #include "core/dom/DOMURL.h"
9 #include "core/dom/ExecutionContext.h" 9 #include "core/dom/ExecutionContext.h"
10 #include "core/fileapi/Blob.h" 10 #include "core/fileapi/Blob.h"
11 #include "core/frame/Deprecation.h"
12 #include "core/frame/UseCounter.h"
11 #include "core/html/PublicURLManager.h" 13 #include "core/html/PublicURLManager.h"
12 14
13 namespace blink { 15 namespace blink {
14 16
15 // static 17 // static
16 String URLFileAPI::createObjectURL(ExecutionContext* executionContext, Blob* blo b, ExceptionState& exceptionState) 18 String URLFileAPI::createObjectURL(ExecutionContext* executionContext, Blob* blo b, ExceptionState& exceptionState)
17 { 19 {
18 DCHECK(blob); 20 DCHECK(blob);
19 DCHECK(executionContext); 21 DCHECK(executionContext);
20 22
23 if (executionContext->isServiceWorkerGlobalScope())
24 Deprecation::countDeprecation(executionContext, UseCounter::URLMethodCre ateObjectURLServiceWorker);
25
21 if (blob->isClosed()) { 26 if (blob->isClosed()) {
22 exceptionState.throwDOMException(InvalidStateError, String(blob->isFile( ) ? "File" : "Blob") + " has been closed."); 27 exceptionState.throwDOMException(InvalidStateError, String(blob->isFile( ) ? "File" : "Blob") + " has been closed.");
23 return String(); 28 return String();
24 } 29 }
25 return DOMURL::createPublicURL(executionContext, blob, blob->uuid()); 30 return DOMURL::createPublicURL(executionContext, blob, blob->uuid());
26 } 31 }
27 32
28 // static 33 // static
29 void URLFileAPI::revokeObjectURL(ExecutionContext* executionContext, const Strin g& urlString) 34 void URLFileAPI::revokeObjectURL(ExecutionContext* executionContext, const Strin g& urlString)
30 { 35 {
31 DCHECK(executionContext); 36 DCHECK(executionContext);
32 37
38 if (executionContext->isServiceWorkerGlobalScope())
39 Deprecation::countDeprecation(executionContext, UseCounter::URLMethodRev okeObjectURLServiceWorker);
40
33 KURL url(KURL(), urlString); 41 KURL url(KURL(), urlString);
34 executionContext->removeURLFromMemoryCache(url); 42 executionContext->removeURLFromMemoryCache(url);
35 executionContext->publicURLManager().revoke(url); 43 executionContext->publicURLManager().revoke(url);
36 } 44 }
37 45
38 } // namespace blink 46 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/Deprecation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698