Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 1938133002: Enable full WPO for the PGO builds. (Closed)

Created:
4 years, 7 months ago by Sébastien Marchand
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable full WPO for the PGO builds. BUG=309849 Committed: https://crrev.com/4910a3e72d57b89e26ee45ce3ba754b17efa62a8 Cr-Commit-Position: refs/heads/master@{#391481}

Patch Set 1 #

Patch Set 2 : Fix + GN things. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -28 lines) Patch
M build/common.gypi View 1 4 chunks +11 lines, -6 lines 0 comments Download
M build/config/compiler/compiler.gni View 1 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/BUILD.gn View 1 2 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 28 (10 generated)
Sébastien Marchand
4 years, 7 months ago (2016-05-03 14:01:59 UTC) #2
Sébastien Marchand
PTAL
4 years, 7 months ago (2016-05-03 14:02:04 UTC) #3
scottmg
GN? lgtm
4 years, 7 months ago (2016-05-03 17:15:46 UTC) #4
Sébastien Marchand
not sure that we can do a PGO build with GN yet (I still need ...
4 years, 7 months ago (2016-05-03 17:17:28 UTC) #5
Sébastien Marchand
Confirmed that GN PGO doesn't work. I'm working on this now. I'll land this one ...
4 years, 7 months ago (2016-05-03 17:20:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938133002/1
4 years, 7 months ago (2016-05-03 17:24:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938133002/1
4 years, 7 months ago (2016-05-03 17:41:06 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/215611)
4 years, 7 months ago (2016-05-03 18:17:22 UTC) #13
Sébastien Marchand
GYP is weird, here's a GYP fix. I've also fixed the GN config while I ...
4 years, 7 months ago (2016-05-03 19:04:45 UTC) #14
scottmg
lgtm
4 years, 7 months ago (2016-05-03 19:43:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938133002/20001
4 years, 7 months ago (2016-05-03 19:44:05 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/176953)
4 years, 7 months ago (2016-05-03 19:56:38 UTC) #19
Sébastien Marchand
+jochen for owner approval.
4 years, 7 months ago (2016-05-03 20:00:11 UTC) #20
Sébastien Marchand
+jochen@ for real this time.
4 years, 7 months ago (2016-05-03 20:00:28 UTC) #22
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-04 10:54:08 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938133002/20001
4 years, 7 months ago (2016-05-04 11:07:38 UTC) #25
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-04 11:39:58 UTC) #26
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 11:41:19 UTC) #28
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4910a3e72d57b89e26ee45ce3ba754b17efa62a8
Cr-Commit-Position: refs/heads/master@{#391481}

Powered by Google App Engine
This is Rietveld 408576698