|
|
Created:
4 years, 7 months ago by Sébastien Marchand Modified:
4 years, 7 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable full WPO for the PGO builds.
BUG=309849
Committed: https://crrev.com/4910a3e72d57b89e26ee45ce3ba754b17efa62a8
Cr-Commit-Position: refs/heads/master@{#391481}
Patch Set 1 #Patch Set 2 : Fix + GN things. #
Messages
Total messages: 28 (10 generated)
sebmarchand@chromium.org changed reviewers: + scottmg@chromium.org
PTAL
GN? lgtm
not sure that we can do a PGO build with GN yet (I still need to work on this), I'll check before committing this.
Confirmed that GN PGO doesn't work. I'm working on this now. I'll land this one so the PGO builder will start spewing full WPO/PGO builds and we'll be able to see the impact on the build time.
The CQ bit was checked by sebmarchand@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938133002/1
The CQ bit was unchecked by sebmarchand@chromium.org
The CQ bit was checked by sebmarchand@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938133002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
GYP is weird, here's a GYP fix. I've also fixed the GN config while I was here.
lgtm
The CQ bit was checked by sebmarchand@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938133002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
+jochen for owner approval.
sebmarchand@chromium.org changed reviewers: + jochen@chromium.org
+jochen@ for real this time.
lgtm
The CQ bit was checked by sebmarchand@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938133002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Enable full WPO for the PGO builds. BUG=309849 ========== to ========== Enable full WPO for the PGO builds. BUG=309849 Committed: https://crrev.com/4910a3e72d57b89e26ee45ce3ba754b17efa62a8 Cr-Commit-Position: refs/heads/master@{#391481} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4910a3e72d57b89e26ee45ce3ba754b17efa62a8 Cr-Commit-Position: refs/heads/master@{#391481} |