Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: build/common.gypi

Issue 1938133002: Enable full WPO for the PGO builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix + GN things. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/compiler/compiler.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 641cc709fcb5ecc1c39c80d1e06ddd968f649650..b6aad8a1c098affdaab49d0a06a5eb5959ba7f0b 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -420,6 +420,12 @@
# Enable with GYP_DEFINES=win_fastlink=1
'win_fastlink%': 0,
+ # Experimental setting to optimize Chrome's DLLs with PGO.
+ 'chrome_pgo_phase%': '0',
+
+ # Experimental setting to build the official builds with full WPO.
+ 'full_wpo_on_official%': '0',
+
# Set to select the Title Case versions of strings in GRD files.
'use_titlecase_in_grd%': 0,
@@ -1187,6 +1193,8 @@
'component%': '<(component)',
'win_analyze%': '<(win_analyze)',
'win_fastlink%': '<(win_fastlink)',
+ 'chrome_pgo_phase%': '<(chrome_pgo_phase)',
+ 'full_wpo_on_official%': '<(full_wpo_on_official)',
'enable_resource_whitelist_generation%': '<(enable_resource_whitelist_generation)',
'use_titlecase_in_grd%': '<(use_titlecase_in_grd)',
'remoting%': '<(remoting)',
@@ -1377,12 +1385,6 @@
# process type.
'chrome_multiple_dll%': '0',
- # Experimental setting to optimize Chrome's DLLs with PGO.
- 'chrome_pgo_phase%': '0',
-
- # Experimental setting to build the official builds with full WPO.
- 'full_wpo_on_official%': '0',
-
# Whether the VS xtree header has been patched to disable warning 4702. If
# it has, then we don't need to disable 4702 (unreachable code warning).
# The patch is preapplied to the internal toolchain and hence all bots.
@@ -2034,6 +2036,9 @@
},{
'msvs_large_module_debug_link_mode%': '2', # Yes
}],
+ ['chrome_pgo_phase!= 0', {
+ 'full_wpo_on_official%': 1,
+ }],
],
'nacl_win64_defines': [
# This flag is used to minimize dependencies when building
« no previous file with comments | « no previous file | build/config/compiler/compiler.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698