Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Side by Side Diff: build/config/compiler/compiler.gni

Issue 1938133002: Enable full WPO for the PGO builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix + GN things. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | chrome/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/sanitizers/sanitizers.gni") 8 import("//build/config/sanitizers/sanitizers.gni")
9 9
10 declare_args() { 10 declare_args() {
11 # How many symbols to include in the build. This affects the performance of 11 # How many symbols to include in the build. This affects the performance of
12 # the build since the symbols are large and dealing with them is slow. 12 # the build since the symbols are large and dealing with them is slow.
13 # 2 means regular build with symbols. 13 # 2 means regular build with symbols.
14 # 1 means minimal symbols, usually enough for backtraces only. 14 # 1 means minimal symbols, usually enough for backtraces only.
15 # 0 means no symbols. 15 # 0 means no symbols.
16 # -1 means auto-set according to debug/release and platform. 16 # -1 means auto-set according to debug/release and platform.
17 symbol_level = -1 17 symbol_level = -1
18 18
19 # Compile in such a way as to enable profiling of the generated code. For 19 # Compile in such a way as to enable profiling of the generated code. For
20 # example, don't omit the frame pointer and leave in symbols. 20 # example, don't omit the frame pointer and leave in symbols.
21 enable_profiling = false 21 enable_profiling = false
22 22
23 # Specify the current PGO phase, only used for the Windows MSVS build. Here's
24 # the different values that can be used:
25 # 0 : Means that PGO is turned off.
26 # 1 : Used during the PGI (instrumentation) phase.
27 # 2 : Used during the PGO (optimization) phase.
28 #
29 # TODO(sebmarchand): Add support for the PGU (update) phase.
30 chrome_pgo_phase = 0
31
23 # Whether or not the official builds should be build with full WPO. 32 # Whether or not the official builds should be build with full WPO.
24 full_wpo_on_official = false 33 full_wpo_on_official = false
25 } 34 }
26 35
27 # If it wasn't manually set, set to an appropriate default. 36 # If it wasn't manually set, set to an appropriate default.
28 assert(symbol_level >= -1 && symbol_level <= 2, "Invalid symbol_level") 37 assert(symbol_level >= -1 && symbol_level <= 2, "Invalid symbol_level")
29 if (symbol_level == -1) { 38 if (symbol_level == -1) {
30 if (is_android && use_order_profiling) { 39 if (is_android && use_order_profiling) {
31 # With instrumentation enabled, debug info puts libchrome.so over 4gb, which 40 # With instrumentation enabled, debug info puts libchrome.so over 4gb, which
32 # causes the linker to produce an invalid ELF. http://crbug.com/574476 41 # causes the linker to produce an invalid ELF. http://crbug.com/574476
33 symbol_level = 0 42 symbol_level = 0
34 } else if (is_win && is_clang && !using_sanitizer) { 43 } else if (is_win && is_clang && !using_sanitizer) {
35 # TODO(thakis): Remove this again once building with clang/win and 44 # TODO(thakis): Remove this again once building with clang/win and
36 # debug info doesn't make link.exe run for hours. 45 # debug info doesn't make link.exe run for hours.
37 symbol_level = 1 46 symbol_level = 1
38 } else if (!is_linux || is_debug || is_official_build || is_chromecast) { 47 } else if (!is_linux || is_debug || is_official_build || is_chromecast) {
39 # Linux is slowed by having symbols as part of the target binary, whereas 48 # Linux is slowed by having symbols as part of the target binary, whereas
40 # Mac and Windows have them separate, so in Release Linux, default them off, 49 # Mac and Windows have them separate, so in Release Linux, default them off,
41 # but keep them on for Official builds and Chromecast builds. 50 # but keep them on for Official builds and Chromecast builds.
42 symbol_level = 2 51 symbol_level = 2
43 } else if (using_sanitizer) { 52 } else if (using_sanitizer) {
44 # Sanitizers require symbols for filename suppressions to work. 53 # Sanitizers require symbols for filename suppressions to work.
45 symbol_level = 1 54 symbol_level = 1
46 } else { 55 } else {
47 symbol_level = 0 56 symbol_level = 0
48 } 57 }
49 } 58 }
59
60 # PGO requires full WPO.
61 if (chrome_pgo_phase > 0) {
62 full_wpo_on_official = true
63 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | chrome/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698