Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 1937553002: Add Gr*Proxy classes (Closed)

Created:
4 years, 7 months ago by robertphillips
Modified:
4 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : update #

Patch Set 4 : clean up #

Patch Set 5 : More clean up #

Total comments: 2

Patch Set 6 : Mv SkBackingFit to SkTypes.h #

Patch Set 7 : gcc #

Patch Set 8 : Mv new headers to include\private #

Patch Set 9 : Update the gypi #

Patch Set 10 : Handle A8 texture creation failure #

Patch Set 11 : Fix memory bugs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+602 lines, -23 lines) Patch
M gyp/gpu.gypi View 1 2 3 4 5 6 7 8 9 3 chunks +7 lines, -1 line 0 comments Download
M include/core/SkTypes.h View 1 2 3 4 5 6 7 8 9 1 chunk +9 lines, -0 lines 0 comments Download
M include/gpu/GrContext.h View 1 2 3 4 5 1 chunk +1 line, -6 lines 0 comments Download
M include/gpu/GrRenderTarget.h View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
A include/private/GrRenderTargetProxy.h View 1 2 3 4 5 6 7 8 9 1 chunk +123 lines, -0 lines 0 comments Download
A include/private/GrSurfaceProxy.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +72 lines, -0 lines 0 comments Download
A include/private/GrTextureProxy.h View 1 2 3 4 5 6 7 1 chunk +49 lines, -0 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrBlurUtils.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrRenderTarget.cpp View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M src/gpu/GrRenderTargetPriv.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A src/gpu/GrRenderTargetProxy.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +77 lines, -0 lines 0 comments Download
A src/gpu/GrSurfaceProxy.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +19 lines, -0 lines 0 comments Download
A src/gpu/GrTextureProxy.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +44 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -3 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M tests/ClearTest.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M tests/PrimitiveProcessorTest.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A tests/ProxyTest.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +172 lines, -0 lines 0 comments Download

Messages

Total messages: 60 (31 generated)
robertphillips
4 years, 7 months ago (2016-05-02 17:09:33 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937553002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937553002/80001
4 years, 7 months ago (2016-05-02 17:09:50 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/8258)
4 years, 7 months ago (2016-05-02 17:12:21 UTC) #8
bsalomon
If the proxy can have all the IORef ref types, do we need to propagate ...
4 years, 7 months ago (2016-05-02 17:45:41 UTC) #9
robertphillips
>> If the proxy can have all the IORef ref types, do we need to ...
4 years, 7 months ago (2016-05-02 19:22:55 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937553002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937553002/100001
4 years, 7 months ago (2016-05-02 19:23:05 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/8266)
4 years, 7 months ago (2016-05-02 19:25:26 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937553002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937553002/120001
4 years, 7 months ago (2016-05-02 19:29:25 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-02 19:40:37 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937553002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937553002/160001
4 years, 7 months ago (2016-05-02 19:54:28 UTC) #20
robertphillips
Now with hidden headers
4 years, 7 months ago (2016-05-02 19:54:47 UTC) #21
bsalomon
lgtm
4 years, 7 months ago (2016-05-02 19:58:58 UTC) #22
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-02 20:16:27 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937553002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937553002/160001
4 years, 7 months ago (2016-05-03 12:05:18 UTC) #26
commit-bot: I haz the power
Committed patchset #9 (id:160001) as https://skia.googlesource.com/skia/+/de5bf0cfeca908b81a28cc50065f7bc2da3d2fd1
4 years, 7 months ago (2016-05-03 12:06:36 UTC) #28
robertphillips
A revert of this CL (patchset #9 id:160001) has been created in https://codereview.chromium.org/1949463002/ by robertphillips@google.com. ...
4 years, 7 months ago (2016-05-03 13:44:35 UTC) #29
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937553002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937553002/180001
4 years, 7 months ago (2016-05-03 14:18:33 UTC) #32
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/8279) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on ...
4 years, 7 months ago (2016-05-03 14:19:44 UTC) #34
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937553002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937553002/200001
4 years, 7 months ago (2016-05-03 14:31:10 UTC) #36
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/8285)
4 years, 7 months ago (2016-05-03 14:33:28 UTC) #38
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937553002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937553002/220001
4 years, 7 months ago (2016-05-03 14:47:35 UTC) #42
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 14:58:48 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937553002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937553002/220001
4 years, 7 months ago (2016-05-03 15:46:03 UTC) #47
commit-bot: I haz the power
Committed patchset #10 (id:220001) as https://skia.googlesource.com/skia/+/92605b35efa0155c44d24bd8415b4cc1db8831db
4 years, 7 months ago (2016-05-03 15:47:04 UTC) #49
robertphillips
A revert of this CL (patchset #10 id:220001) has been created in https://codereview.chromium.org/1944953002/ by robertphillips@google.com. ...
4 years, 7 months ago (2016-05-03 19:55:49 UTC) #50
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937553002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937553002/240001
4 years, 7 months ago (2016-05-04 18:47:24 UTC) #53
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-04 19:04:56 UTC) #55
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937553002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937553002/240001
4 years, 7 months ago (2016-05-04 19:46:45 UTC) #58
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 19:47:46 UTC) #60
Message was sent while issue was closed.
Committed patchset #11 (id:240001) as
https://skia.googlesource.com/skia/+/76948d4faaca9fd7730576e2f79790ca8d93c10b

Powered by Google App Engine
This is Rietveld 408576698