Replace CFX_PtrArray with typesafe CFX_ArrayTemplate, part 8

Replace CFX_PtrArray with typesafe CFX_ArrayTemplate, part 8

This also removes another hand-written bubblesort in favor of
the std::sort() STL function.

Committed: https://pdfium.googlesource.com/pdfium/+/d5d07dcf59ddc6439f73382c6e0b9e6d1851000d

[Tom Sepez, 2016-04-29 17:50:22]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-04-29 17:50:22]

Lei, part 8.

[Lei Zhang, 2016-04-29 18:09:21]

lgtm

https://codereview.chromium.org/1937513002/diff/1/xfa/fxbarcode/datamatrix/BC...
File xfa/fxbarcode/datamatrix/BC_DataMatrixDetector.cpp (right):

https://codereview.chromium.org/1937513002/diff/1/xfa/fxbarcode/datamatrix/BC...
xfa/fxbarcode/datamatrix/BC_DataMatrixDetector.cpp:93: if (!maybeBottomRight) {
remove the negation and flip the if/else?

[Tom Sepez, 2016-04-29 18:12:21]

https://codereview.chromium.org/1937513002/diff/1/xfa/fxbarcode/datamatrix/BC...
File xfa/fxbarcode/datamatrix/BC_DataMatrixDetector.cpp (right):

https://codereview.chromium.org/1937513002/diff/1/xfa/fxbarcode/datamatrix/BC...
xfa/fxbarcode/datamatrix/BC_DataMatrixDetector.cpp:93: if (!maybeBottomRight) {
On 2016/04/29 18:09:21, Lei Zhang wrote:
> remove the negation and flip the if/else?

Done.

[Tom Sepez, 2016-04-29 18:12:26]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-04-29 18:12:27]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1937513002/#ps20001
(title: "Flip if/else.")

[commit-bot: I haz the power, 2016-04-29 18:12:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1937513002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1937513002/20001

[commit-bot: I haz the power, 2016-04-29 18:24:18]

Description was changed from

==========
Replace CFX_PtrArray with typesafe CFX_ArrayTemplate, part 8

This also removes another hand-written bubblesort in favor of
the std::sort() STL function.
==========

to

==========
Replace CFX_PtrArray with typesafe CFX_ArrayTemplate, part 8

This also removes another hand-written bubblesort in favor of
the std::sort() STL function.

Committed:
https://pdfium.googlesource.com/pdfium/+/d5d07dcf59ddc6439f73382c6e0b9e6d1851...
==========

[commit-bot: I haz the power, 2016-04-29 18:24:19]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/d5d07dcf59ddc6439f73382c6e0b9e6d1851...