xfa/fxbarcode/datamatrix/BC_DataMatrixDataBlock.h - Issue 1937513002: Replace CFX_PtrArray with typesafe CFX_ArrayTemplate, part 8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxbarcode/datamatrix/BC_DataMatrixDataBlock.h

Issue 1937513002: Replace CFX_PtrArray with typesafe CFX_ArrayTemplate, part 8 (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Flip if/else. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256Poly.cpp ('k') | xfa/fxbarcode/datamatrix/BC_DataMatrixDataBlock.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: xfa/fxbarcode/datamatrix/BC_DataMatrixDataBlock.h

diff --git a/xfa/fxbarcode/datamatrix/BC_DataMatrixDataBlock.h b/xfa/fxbarcode/datamatrix/BC_DataMatrixDataBlock.h

index 039255268fbab136999afc2ff521b2092795d177..782e5ed31904a0b86ad679860d020ee03de3ad29 100644

--- a/xfa/fxbarcode/datamatrix/BC_DataMatrixDataBlock.h

+++ b/xfa/fxbarcode/datamatrix/BC_DataMatrixDataBlock.h

@@ -11,22 +11,23 @@

class CBC_DataMatrixVersion;

-class CBC_DataMatrixDataBlock {

+class CBC_DataMatrixDataBlock final {

public:

- virtual ~CBC_DataMatrixDataBlock();

+ ~CBC_DataMatrixDataBlock();

int32_t GetNumDataCodewords();

CFX_ByteArray* GetCodewords();

- static CFX_PtrArray* GetDataBlocks(CFX_ByteArray* rawCodewords,

- CBC_DataMatrixVersion* version,

- int32_t& e);

+ static CFX_ArrayTemplate<CBC_DataMatrixDataBlock*>* GetDataBlocks(

+ CFX_ByteArray* rawCodewords,

+ CBC_DataMatrixVersion* version,

+ int32_t& e);

private:

+ CBC_DataMatrixDataBlock(int32_t numDataCodewords, CFX_ByteArray* codewords);

int32_t m_numDataCodewords;

CFX_ByteArray m_codewords;

- CBC_DataMatrixDataBlock(int32_t numDataCodewords, CFX_ByteArray* codewords);

};

#endif // XFA_FXBARCODE_DATAMATRIX_BC_DATAMATRIXDATABLOCK_H_