xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256Poly.h - Issue 1937513002: Replace CFX_PtrArray with typesafe CFX_ArrayTemplate, part 8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256Poly.h

Issue 1937513002: Replace CFX_PtrArray with typesafe CFX_ArrayTemplate, part 8 (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Flip if/else. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonDecoder.cpp ('k') | xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256Poly.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256Poly.h

diff --git a/xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256Poly.h b/xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256Poly.h

index aa549efe60eefa9dbbcb7d3a04268e12f7a7c790..03580c23509a71555ae460b5709a5694bee10889 100644

--- a/xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256Poly.h

+++ b/xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256Poly.h

@@ -11,11 +11,15 @@

class CBC_ReedSolomonGF256;

-class CBC_ReedSolomonGF256Poly {

+class CBC_ReedSolomonGF256Poly final {

public:

CBC_ReedSolomonGF256Poly(CBC_ReedSolomonGF256* field, int32_t coefficients);

CBC_ReedSolomonGF256Poly();

- virtual ~CBC_ReedSolomonGF256Poly();

+ ~CBC_ReedSolomonGF256Poly();

+ void Init(CBC_ReedSolomonGF256* field,

+ CFX_Int32Array* coefficients,

+ int32_t& e);

int32_t GetCoefficients(int32_t degree);

CFX_Int32Array* GetCoefficients();

int32_t GetDegree();

@@ -29,11 +33,11 @@ class CBC_ReedSolomonGF256Poly {

CBC_ReedSolomonGF256Poly* MultiplyByMonomial(int32_t degree,

int32_t coefficient,

int32_t& e);

- CFX_PtrArray* Divide(CBC_ReedSolomonGF256Poly* other, int32_t& e);

+ CFX_ArrayTemplate<CBC_ReedSolomonGF256Poly*>* Divide(

+ CBC_ReedSolomonGF256Poly* other,

+ int32_t& e);

CBC_ReedSolomonGF256Poly* Clone(int32_t& e);

- virtual void Init(CBC_ReedSolomonGF256* field,

- CFX_Int32Array* coefficients,

- int32_t& e);

private:

CBC_ReedSolomonGF256* m_field;