Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4807)

Unified Diff: blimp/docs/container.md

Issue 1937423002: Refactor generate engine manifest to accept blacklist as an argument. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing on new BUILD.gn updates. Addressing naming comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | blimp/engine/BUILD.gn » ('j') | blimp/tools/engine-manifest-blacklist.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/docs/container.md
diff --git a/blimp/docs/container.md b/blimp/docs/container.md
index b8c652cef018ef62b6d7ea151230a461f2d4b85b..81d56602b5d27f2305d17d10b89aa13fcb3ecc12 100644
--- a/blimp/docs/container.md
+++ b/blimp/docs/container.md
@@ -35,26 +35,23 @@ The `blimp/engine:blimp_engine_bundle` build target will bundle the engine and
its dependencies into a tarfile, which can be used to build a Docker image.
This target is always built as part of the top-level `blimp/blimp` meta-target.
-### Update Engine Dependencies
+### Manually checking dependencies
-`blimp/engine/engine-manifest.txt` is a list of the engine's runtime
-dependencies. From time to time, this list may need to be updated. Use
-`blimp/tools/generate-engine-manifest.py` to (re)generate the manifest:
+`gen/engine-manifest.txt` is a list of the engine's runtime
+dependencies. This list is automatatically generated in the build, but can
+be manually replicated for debugging and investigation. Use
+`blimp/tools/generate-target-manifest.py` to manually generate the manifest:
```bash
-./blimp/tools/generate-engine-manifest.py \
+./blimp/tools/generate-target-manifest.py \
--build-dir out-linux/Debug \
--target //blimp/engine \
- --output blimp/engine/engine-manifest.txt
+ --output blimp/engine/engine-manifest.txt \
maniscalco 2016/05/18 16:14:12 This example needs to be updated, right? Looks li
Jess 2016/05/18 17:36:44 Done.
+ --blacklist blimp/tools/engine-manifest-blacklist.txt
```
-Be sure to review the generated manifest and remove any false runtime
-dependencies.
-
-For all entries listed in the manifest that are not from
-`//third_party/blimp_fonts`, ensure that the target that generate that artifact
-is manually listed as a dependency of `//blimp/engine:blimp_engine_bundle` to
-ensure that it is built before the bundle step happens.
+You can compare the output at `blimp/engine/engine-manifest.txt` with the
maniscalco 2016/05/18 16:14:12 We probably don't want to recommend that people di
Jess 2016/05/18 17:36:44 Ended up dropping it in out-linux/Debug since we k
+generated target `gen/engine-manifest.txt`.
## Build Docker Image
« no previous file with comments | « no previous file | blimp/engine/BUILD.gn » ('j') | blimp/tools/engine-manifest-blacklist.txt » ('J')

Powered by Google App Engine
This is Rietveld 408576698