Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: blimp/engine/BUILD.gn

Issue 1937423002: Refactor generate engine manifest to accept blacklist as an argument. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing on new BUILD.gn updates. Addressing naming comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« blimp/docs/container.md ('K') | « blimp/docs/container.md ('k') | blimp/tools/engine-manifest-blacklist.txt » ('j') | blimp/tools/engine-manifest-blacklist.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/engine/BUILD.gn
diff --git a/blimp/engine/BUILD.gn b/blimp/engine/BUILD.gn
index 9abf44690ffc4f682dd0313da9ab2e6dc0ce1cb4..9448476a37963522ceb87b52005c3f080f1255b2 100644
--- a/blimp/engine/BUILD.gn
+++ b/blimp/engine/BUILD.gn
@@ -494,10 +494,14 @@ if (is_linux) {
_manifest = "$root_gen_dir/engine-manifest.txt"
_rebased_manifest = rebase_path(_manifest, root_out_dir)
+ _rebased_blacklist =
+ rebase_path("//blimp/tools/engine-manifest-blacklist.txt")
action("generate_manifest") {
- script = "//blimp/tools/generate-engine-manifest.py"
+ script = "//blimp/tools/generate-target-manifest.py"
args = [
+ "--blacklist",
+ _rebased_blacklist,
"--runtime-deps-file",
_rebased_runtime_deps,
"--output",
« blimp/docs/container.md ('K') | « blimp/docs/container.md ('k') | blimp/tools/engine-manifest-blacklist.txt » ('j') | blimp/tools/engine-manifest-blacklist.txt » ('J')

Powered by Google App Engine
This is Rietveld 408576698