Chromium Code Reviews Chromium Code Reviews
Issue 1937423002:
Refactor generate engine manifest to accept blacklist as an argument. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 # Running the engine in a Docker container | 1 # Running the engine in a Docker container |
| 2 | 2 |
| 3 For local development and testing, you can run the engine in a Docker | 3 For local development and testing, you can run the engine in a Docker |
| 4 container. | 4 container. |
| 5 | 5 |
| 6 The steps are: | 6 The steps are: |
| 7 | 7 |
| 8 1. Bundle the engine and its dependencies. | 8 1. Bundle the engine and its dependencies. |
| 9 | 9 |
| 10 1. Build a Docker image. | 10 1. Build a Docker image. |
| (...skipping 17 matching lines...) Expand all Loading... | |
| 28 contributors using Ubuntu, see [official Docker | 28 contributors using Ubuntu, see [official Docker |
| 29 installation instructions](https://docs.docker.com/installation/ubuntulinux/). | 29 installation instructions](https://docs.docker.com/installation/ubuntulinux/). |
| 30 | 30 |
| 31 | 31 |
| 32 ## Bundle Engine | 32 ## Bundle Engine |
| 33 | 33 |
| 34 The `blimp/engine:blimp_engine_bundle` build target will bundle the engine and | 34 The `blimp/engine:blimp_engine_bundle` build target will bundle the engine and |
| 35 its dependencies into a tarfile, which can be used to build a Docker image. | 35 its dependencies into a tarfile, which can be used to build a Docker image. |
| 36 This target is always built as part of the top-level `blimp/blimp` meta-target. | 36 This target is always built as part of the top-level `blimp/blimp` meta-target. |
| 37 | 37 |
| 38 ### Update Engine Dependencies | 38 ### Manually checking dependencies |
| 39 | 39 |
| 40 `blimp/engine/engine-manifest.txt` is a list of the engine's runtime | 40 `gen/engine-manifest.txt` is a list of the engine's runtime |
| 41 dependencies. From time to time, this list may need to be updated. Use | 41 dependencies. This list is automatatically generated in the build, but can |
| 42 `blimp/tools/generate-engine-manifest.py` to (re)generate the manifest: | 42 be manually replicated for debugging and investigation. Use |
| 43 `blimp/tools/generate-target-manifest.py` to manually generate the manifest: | |
| 43 | 44 |
| 44 ```bash | 45 ```bash |
| 45 ./blimp/tools/generate-engine-manifest.py \ | 46 ./blimp/tools/generate-target-manifest.py \ |
| 46 --build-dir out-linux/Debug \ | 47 --build-dir out-linux/Debug \ |
| 47 --target //blimp/engine \ | 48 --target //blimp/engine \ |
| 48 --output blimp/engine/engine-manifest.txt | 49 --output blimp/engine/engine-manifest.txt \ |
|
maniscalco
2016/05/18 16:14:12
This example needs to be updated, right? Looks li
Jess
2016/05/18 17:36:44
Done.
| |
| 50 --blacklist blimp/tools/engine-manifest-blacklist.txt | |
| 49 ``` | 51 ``` |
| 50 | 52 |
| 51 Be sure to review the generated manifest and remove any false runtime | 53 You can compare the output at `blimp/engine/engine-manifest.txt` with the |
|
maniscalco
2016/05/18 16:14:12
We probably don't want to recommend that people di
Jess
2016/05/18 17:36:44
Ended up dropping it in out-linux/Debug since we k
| |
| 52 dependencies. | 54 generated target `gen/engine-manifest.txt`. |
| 53 | |
| 54 For all entries listed in the manifest that are not from | |
| 55 `//third_party/blimp_fonts`, ensure that the target that generate that artifact | |
| 56 is manually listed as a dependency of `//blimp/engine:blimp_engine_bundle` to | |
| 57 ensure that it is built before the bundle step happens. | |
| 58 | 55 |
| 59 ## Build Docker Image | 56 ## Build Docker Image |
| 60 | 57 |
| 61 Using the tarfile you can create a Docker image: | 58 Using the tarfile you can create a Docker image: |
| 62 | 59 |
| 63 ```bash | 60 ```bash |
| 64 docker build -t blimp_engine - < ./out-linux/Debug/blimp_engine_bundle.tar.gz | 61 docker build -t blimp_engine - < ./out-linux/Debug/blimp_engine_bundle.tar.gz |
| 65 ``` | 62 ``` |
| 66 | 63 |
| 67 ## Running the Engine in a Docker Container | 64 ## Running the Engine in a Docker Container |
| (...skipping 25 matching lines...) Expand all Loading... | |
| 93 ```bash | 90 ```bash |
| 94 docker run -v $CONFIG_DIR:/engine/data -p 443:25466 blimp_engine | 91 docker run -v $CONFIG_DIR:/engine/data -p 443:25466 blimp_engine |
| 95 ``` | 92 ``` |
| 96 You can also pass additional flags: | 93 You can also pass additional flags: |
| 97 | 94 |
| 98 ```bash | 95 ```bash |
| 99 docker run ... blimp_engine --with-my-flags | 96 docker run ... blimp_engine --with-my-flags |
| 100 ``` | 97 ``` |
| 101 See the [blimp engine `Dockerfile`](../engine/Dockerfile) to find out what flags | 98 See the [blimp engine `Dockerfile`](../engine/Dockerfile) to find out what flags |
| 102 are passed by default. | 99 are passed by default. |
| OLD | NEW |
