blimp/engine/engine-manifest.txt - Issue 1937423002: Refactor generate engine manifest to accept blacklist as an argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/engine/engine-manifest.txt

Issue 1937423002: Refactor generate engine manifest to accept blacklist as an argument. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up to take from sanity check to review ready code. Includes updating blacklist. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/engine/engine-manifest.txt

diff --git a/blimp/engine/engine-manifest.txt b/blimp/engine/engine-manifest.txt

index 8943ec4ff0fdd9cc3ce65f5b6e7d2eee8e06f704..7a29e5c72f71e3148263ad757427252f27647c58 100644

--- a/blimp/engine/engine-manifest.txt

+++ b/blimp/engine/engine-manifest.txt

@@ -1,10 +1,10 @@

# Runtime dependencies for the Blimp Engine

# This file was generated by running:

-# generate-engine-manifest.py --build-dir out-chromeos/Debug --target //blimp/engine --output blimp/engine/engine-manifest.txt

+# generate-manifest.py --build-dir out-linux/Debug --target //blimp/engine --output blimp/engine/engine-manifest.txt --blacklist blimp/tools/manifest-blacklist.txt

-# Note: Any unnecessary dependencies should be added to

-# manifest-blacklist.txt and this file should be regenerated.

+# Note: Any unnecessary dependencies should be added to provided

+# manifest-blacklist and this file should be regenerated.

./blimp_engine_app

icudtl.dat

natives_blob.bin

@@ -214,4 +214,4 @@ gen/third_party/blimp_fonts/RobotoCondensed-Italic.ttf

gen/third_party/blimp_fonts/RobotoCondensed-Light.ttf

gen/third_party/blimp_fonts/RobotoCondensed-LightItalic.ttf

gen/third_party/blimp_fonts/RobotoCondensed-Regular.ttf

-gen/third_party/blimp_fonts/fonts.xml

+gen/third_party/blimp_fonts/fonts.xml

« no previous file with comments | « blimp/docs/container.md ('k') | blimp/tools/generate-engine-manifest.py » ('j') | blimp/tools/generate-manifest.py » ('J')