blimp/tools/generate-manifest.py - Issue 1937423002: Refactor generate engine manifest to accept blacklist as an argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/tools/generate-manifest.py

Issue 1937423002: Refactor generate engine manifest to accept blacklist as an argument. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up to take from sanity check to review ready code. Includes updating blacklist. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/tools/generate-manifest.py

diff --git a/blimp/tools/generate-engine-manifest.py b/blimp/tools/generate-manifest.py

similarity index 83%

rename from blimp/tools/generate-engine-manifest.py

rename to blimp/tools/generate-manifest.py

index 327f6a8c06bb1060c33ecc195d3a96f3c463b28c..a9e64c1aa146cec632c30bd449a5cda97ad5cc22 100755

--- a/blimp/tools/generate-engine-manifest.py

+++ b/blimp/tools/generate-manifest.py

@@ -3,7 +3,7 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

-'''Generates a list of runtime Blimp Engine runtime dependencies.

+'''Generates a list of Blimp target runtime dependencies.

maniscalco 2016/05/10 17:24:47 Naming nit: generate-manifest.py feels a little to

Jess 2016/05/18 00:20:01 Done.

'''

@@ -31,6 +31,9 @@ def main():

help=('name and path of manifest file to create'),

required=True,

metavar='FILE')

+ parser.add_argument('--blacklist',

+ help=('name and path of the blacklist file to use'),

+ required=True)

args = parser.parse_args()

try:

@@ -48,14 +51,13 @@ def main():

'# This file was generated by running:',

'# ' + command_line + '',

'#',

- '# Note: Any unnecessary dependencies should be added to',

- '# manifest-blacklist.txt and this file should be regenerated.',

+ '# Note: Any unnecessary dependencies should be added to provided',

+ '# manifest-blacklist and this file should be regenerated.',

'',

]

blacklist_patterns = []

- with open(os.path.join(os.sys.path[0], 'manifest-blacklist.txt'), 'r') \

- as blacklist_file:

+ with open(args.blacklist, 'r') as blacklist_file:

blacklist_patterns = \

[entry.partition('#')[0].strip() for entry \

in blacklist_file.readlines()]

« no previous file with comments | « blimp/tools/generate-engine-manifest.py ('k') | blimp/tools/manifest-blacklist.txt » ('j') | blimp/tools/manifest-blacklist.txt » ('J')