blimp/docs/container.md - Issue 1937423002: Refactor generate engine manifest to accept blacklist as an argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/docs/container.md

Issue 1937423002: Refactor generate engine manifest to accept blacklist as an argument. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up to take from sanity check to review ready code. Includes updating blacklist. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/docs/container.md

diff --git a/blimp/docs/container.md b/blimp/docs/container.md

index b8c652cef018ef62b6d7ea151230a461f2d4b85b..83377310b246ce5ee2358d58cffdc48d31083a31 100644

--- a/blimp/docs/container.md

+++ b/blimp/docs/container.md

@@ -39,13 +39,14 @@ This target is always built as part of the top-level `blimp/blimp` meta-target.

`blimp/engine/engine-manifest.txt` is a list of the engine's runtime

dependencies. From time to time, this list may need to be updated. Use

-`blimp/tools/generate-engine-manifest.py` to (re)generate the manifest:

+`blimp/tools/generate-manifest.py` to (re)generate the manifest:

```bash

-./blimp/tools/generate-engine-manifest.py \

+./blimp/tools/generate-manifest.py \

--build-dir out-linux/Debug \

--target //blimp/engine \

- --output blimp/engine/engine-manifest.txt

+ --output blimp/engine/engine-manifest.txt \

+ --blacklist blimp/tools/manifest-blacklist.txt

```

Be sure to review the generated manifest and remove any false runtime

« no previous file with comments | « no previous file | blimp/engine/engine-manifest.txt » ('j') | blimp/tools/generate-manifest.py » ('J')