Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1937103003: Rename of InkDropAnimation classes to InkDropRipple. (Closed)

Created:
4 years, 7 months ago by bruthig
Modified:
4 years, 7 months ago
Reviewers:
tdanderson, sky
CC:
chromium-reviews, asanka, tfarina, dcheng, bruthig+ink_drop_chromium.org, noyau+watch_chromium.org, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename of InkDropAnimation classes to InkDropRipple. The term 'Animation' is too overloaded with respect to the InkDrop. BUG=608423 Committed: https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144 Cr-Commit-Position: refs/heads/master@{#391069}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed test_ink_drop_animation_observer.h from views.gyp and doc update. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+952 lines, -2905 lines) Patch
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/download/download_item_view_md.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/download/download_item_view_md.cc View 2 chunks +4 lines, -4 lines 0 comments Download
D ui/views/animation/flood_fill_ink_drop_animation.h View 1 chunk +0 lines, -130 lines 0 comments Download
D ui/views/animation/flood_fill_ink_drop_animation.cc View 1 chunk +0 lines, -327 lines 0 comments Download
A + ui/views/animation/flood_fill_ink_drop_ripple.h View 5 chunks +15 lines, -15 lines 0 comments Download
A + ui/views/animation/flood_fill_ink_drop_ripple.cc View 9 chunks +22 lines, -23 lines 0 comments Download
D ui/views/animation/ink_drop_animation.h View 1 chunk +0 lines, -131 lines 0 comments Download
D ui/views/animation/ink_drop_animation.cc View 1 chunk +0 lines, -117 lines 0 comments Download
M ui/views/animation/ink_drop_animation_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/animation/ink_drop_animation_controller_impl.h View 7 chunks +26 lines, -26 lines 0 comments Download
M ui/views/animation/ink_drop_animation_controller_impl.cc View 10 chunks +53 lines, -53 lines 0 comments Download
M ui/views/animation/ink_drop_animation_controller_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D ui/views/animation/ink_drop_animation_observer.h View 1 chunk +0 lines, -41 lines 0 comments Download
D ui/views/animation/ink_drop_animation_unittest.cc View 1 chunk +0 lines, -356 lines 0 comments Download
M ui/views/animation/ink_drop_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/animation/ink_drop_host_view.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/views/animation/ink_drop_host_view.cc View 2 chunks +4 lines, -5 lines 0 comments Download
A + ui/views/animation/ink_drop_ripple.h View 6 chunks +15 lines, -17 lines 0 comments Download
A + ui/views/animation/ink_drop_ripple.cc View 6 chunks +17 lines, -17 lines 0 comments Download
A + ui/views/animation/ink_drop_ripple_observer.h View 3 chunks +8 lines, -8 lines 0 comments Download
A ui/views/animation/ink_drop_ripple_unittest.cc View 1 chunk +348 lines, -0 lines 0 comments Download
D ui/views/animation/square_ink_drop_animation.h View 1 chunk +0 lines, -184 lines 0 comments Download
D ui/views/animation/square_ink_drop_animation.cc View 1 chunk +0 lines, -555 lines 0 comments Download
D ui/views/animation/square_ink_drop_animation_unittest.cc View 1 chunk +0 lines, -249 lines 0 comments Download
A + ui/views/animation/square_ink_drop_ripple.h View 6 chunks +19 lines, -19 lines 0 comments Download
A + ui/views/animation/square_ink_drop_ripple.cc View 10 chunks +30 lines, -30 lines 0 comments Download
A + ui/views/animation/square_ink_drop_ripple_unittest.cc View 6 chunks +37 lines, -45 lines 0 comments Download
D ui/views/animation/test/flood_fill_ink_drop_animation_test_api.h View 1 chunk +0 lines, -56 lines 0 comments Download
D ui/views/animation/test/flood_fill_ink_drop_animation_test_api.cc View 1 chunk +0 lines, -43 lines 0 comments Download
A ui/views/animation/test/flood_fill_ink_drop_ripple_test_api.h View 1 chunk +56 lines, -0 lines 0 comments Download
A ui/views/animation/test/flood_fill_ink_drop_ripple_test_api.cc View 1 chunk +43 lines, -0 lines 0 comments Download
M ui/views/animation/test/ink_drop_animation_controller_impl_test_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/animation/test/ink_drop_animation_controller_impl_test_api.cc View 2 chunks +9 lines, -9 lines 0 comments Download
D ui/views/animation/test/ink_drop_animation_test_api.h View 1 chunk +0 lines, -57 lines 0 comments Download
D ui/views/animation/test/ink_drop_animation_test_api.cc View 1 chunk +0 lines, -22 lines 0 comments Download
A + ui/views/animation/test/ink_drop_ripple_test_api.h View 3 chunks +14 lines, -15 lines 0 comments Download
A + ui/views/animation/test/ink_drop_ripple_test_api.cc View 1 chunk +5 lines, -6 lines 0 comments Download
D ui/views/animation/test/square_ink_drop_animation_test_api.h View 1 chunk +0 lines, -64 lines 0 comments Download
D ui/views/animation/test/square_ink_drop_animation_test_api.cc View 1 chunk +0 lines, -53 lines 0 comments Download
A ui/views/animation/test/square_ink_drop_ripple_test_api.h View 1 chunk +63 lines, -0 lines 0 comments Download
A ui/views/animation/test/square_ink_drop_ripple_test_api.cc View 1 chunk +52 lines, -0 lines 0 comments Download
D ui/views/animation/test/test_ink_drop_animation_observer.h View 1 chunk +0 lines, -68 lines 0 comments Download
D ui/views/animation/test/test_ink_drop_animation_observer.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M ui/views/animation/test/test_ink_drop_animation_observer_helper.h View 6 chunks +10 lines, -12 lines 0 comments Download
M ui/views/animation/test/test_ink_drop_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/animation/test/test_ink_drop_host.cc View 2 chunks +28 lines, -29 lines 0 comments Download
A + ui/views/animation/test/test_ink_drop_ripple_observer.h View 3 chunks +22 lines, -23 lines 0 comments Download
A + ui/views/animation/test/test_ink_drop_ripple_observer.cc View 1 chunk +10 lines, -11 lines 0 comments Download
M ui/views/controls/button/label_button.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/button/label_button.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M ui/views/views.gyp View 1 5 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
bruthig
tdanderson@, can you PTAL?
4 years, 7 months ago (2016-05-02 18:22:41 UTC) #2
tdanderson
On 2016/05/02 18:22:41, bruthig wrote: > tdanderson@, can you PTAL? LGTM if the trybots are ...
4 years, 7 months ago (2016-05-02 18:46:28 UTC) #4
tdanderson
https://codereview.chromium.org/1937103003/diff/1/ui/views/animation/ink_drop_host.h File ui/views/animation/ink_drop_host.h (right): https://codereview.chromium.org/1937103003/diff/1/ui/views/animation/ink_drop_host.h#newcode23 ui/views/animation/ink_drop_host.h:23: // Used by the InkDropAnimationController to add and remove ...
4 years, 7 months ago (2016-05-02 18:49:33 UTC) #5
bruthig
sky@: Please review changes in: - chrome/* - ui/views/controls/* - ui/views.gyp https://codereview.chromium.org/1937103003/diff/1/ui/views/animation/ink_drop_host.h File ui/views/animation/ink_drop_host.h (right): ...
4 years, 7 months ago (2016-05-02 19:47:52 UTC) #7
sky
LGTM
4 years, 7 months ago (2016-05-02 22:08:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937103003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937103003/20001
4 years, 7 months ago (2016-05-02 22:12:55 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-02 22:19:09 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 22:21:41 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144
Cr-Commit-Position: refs/heads/master@{#391069}

Powered by Google App Engine
This is Rietveld 408576698