Remove the LayoutSVGInlineText* context in SVGTextLayoutAttributes

Remove the LayoutSVGInlineText* context in SVGTextLayoutAttributes

Most uses of the SVGTextLayoutAttributes* in vector owned by
LayoutSVGText, actually ends up doing ...->context() and dereferencing
the owning LayoutSVGInlineText rather than the attributes object itself.
It's also slightly more obvious what's going on when considering the
iteration over "text nodes" rather than their associated attributes.
Make LayoutSVGText collect the descendant LayoutSVGInlineTexts rather
than the "parts object" SVGTextLayoutAttributes, and rename as
appropriate to reflect that change.
Since removing the context pointer makes SVGTextLayoutAttributes a simple
wrapper around a SVGCharacterDataMap, just store the latter directly.
Rename SVGTextLayoutAttributes.h to SVGCharacterData.h
Also replace a HashMap::find+conditional copy with a HashMap::get.

BUG=607906
Committed: https://crrev.com/62d08faa9793d36f12b0844cdbcdbcec6a6526b9
Cr-Commit-Position: refs/heads/master@{#391052}

[fs, 2016-05-02 14:17:25]

Description was changed from

==========
Remove the LayoutSVGInlineText* backpointer in SVGTextLayoutAttributes

Remove/unwrap SVGTextLayoutAttributes, using SVGCharacterDataMap directly.

BUG=607906
==========

to

==========
Remove the LayoutSVGInlineText* context in SVGTextLayoutAttributes

Most uses of the SVGTextLayoutAttributes* in vector owned by LayoutSVGText,
actually ends up doing ...->context() and dereferencing the owning
LayoutSVGInlineText rather than the attributes object itself.
It's also slightly more obvious what's going on when considering the
iteration over "text nodes" rather than their associated attributes.
Make LayoutSVGText collect the descendant LayoutSVGInlineTexts rather
than the "parts object" SVGTextLayoutAttributes, and rename as appropriate
to reflect that change.
Since removing the context pointer makes SVGTextLayoutAttributes a simple
wrapper around a SVGCharacterDataMap, just store the latter directly.

BUG=607906
==========

[fs, 2016-05-02 14:19:55]

Description was changed from

==========
Remove the LayoutSVGInlineText* context in SVGTextLayoutAttributes

Most uses of the SVGTextLayoutAttributes* in vector owned by LayoutSVGText,
actually ends up doing ...->context() and dereferencing the owning
LayoutSVGInlineText rather than the attributes object itself.
It's also slightly more obvious what's going on when considering the
iteration over "text nodes" rather than their associated attributes.
Make LayoutSVGText collect the descendant LayoutSVGInlineTexts rather
than the "parts object" SVGTextLayoutAttributes, and rename as appropriate
to reflect that change.
Since removing the context pointer makes SVGTextLayoutAttributes a simple
wrapper around a SVGCharacterDataMap, just store the latter directly.

BUG=607906
==========

to

==========
Remove the LayoutSVGInlineText* context in SVGTextLayoutAttributes

Most uses of the SVGTextLayoutAttributes* in vector owned by
LayoutSVGText, actually ends up doing ...->context() and dereferencing
the owning LayoutSVGInlineText rather than the attributes object itself.
It's also slightly more obvious what's going on when considering the
iteration over "text nodes" rather than their associated attributes.
Make LayoutSVGText collect the descendant LayoutSVGInlineTexts rather
than the "parts object" SVGTextLayoutAttributes, and rename as
appropriate to reflect that change.
Since removing the context pointer makes SVGTextLayoutAttributes a simple
wrapper around a SVGCharacterDataMap, just store the latter directly.
Also replace a HashMap::find+conditional copy with a HashMap::get.

BUG=607906
==========

[fs, 2016-05-02 14:22:03]

Description was changed from

==========
Remove the LayoutSVGInlineText* context in SVGTextLayoutAttributes

Most uses of the SVGTextLayoutAttributes* in vector owned by
LayoutSVGText, actually ends up doing ...->context() and dereferencing
the owning LayoutSVGInlineText rather than the attributes object itself.
It's also slightly more obvious what's going on when considering the
iteration over "text nodes" rather than their associated attributes.
Make LayoutSVGText collect the descendant LayoutSVGInlineTexts rather
than the "parts object" SVGTextLayoutAttributes, and rename as
appropriate to reflect that change.
Since removing the context pointer makes SVGTextLayoutAttributes a simple
wrapper around a SVGCharacterDataMap, just store the latter directly.
Also replace a HashMap::find+conditional copy with a HashMap::get.

BUG=607906
==========

to

==========
Remove the LayoutSVGInlineText* context in SVGTextLayoutAttributes

Most uses of the SVGTextLayoutAttributes* in vector owned by
LayoutSVGText, actually ends up doing ...->context() and dereferencing
the owning LayoutSVGInlineText rather than the attributes object itself.
It's also slightly more obvious what's going on when considering the
iteration over "text nodes" rather than their associated attributes.
Make LayoutSVGText collect the descendant LayoutSVGInlineTexts rather
than the "parts object" SVGTextLayoutAttributes, and rename as
appropriate to reflect that change.
Since removing the context pointer makes SVGTextLayoutAttributes a simple
wrapper around a SVGCharacterDataMap, just store the latter directly.
Rename SVGTextLayoutAttributes.h to SVGCharacterData.h
Also replace a HashMap::find+conditional copy with a HashMap::get.

BUG=607906
==========

[fs, 2016-05-02 16:16:28]

fs@opera.com changed reviewers:
+ fmalita@chromium.org, schenney@chromium.org

[fs, 2016-05-02 16:16:28]

This looks more scary than it is - it's mostly renaming things
(~layoutAttributes -> ~descendantTextNodes and variations.)

[f(malita), 2016-05-02 17:14:40]

lgtm

[fs, 2016-05-02 21:08:42]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-05-02 21:16:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1937043002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1937043002/1

[commit-bot: I haz the power, 2016-05-02 21:22:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-02 21:24:07]

Description was changed from

==========
Remove the LayoutSVGInlineText* context in SVGTextLayoutAttributes

Most uses of the SVGTextLayoutAttributes* in vector owned by
LayoutSVGText, actually ends up doing ...->context() and dereferencing
the owning LayoutSVGInlineText rather than the attributes object itself.
It's also slightly more obvious what's going on when considering the
iteration over "text nodes" rather than their associated attributes.
Make LayoutSVGText collect the descendant LayoutSVGInlineTexts rather
than the "parts object" SVGTextLayoutAttributes, and rename as
appropriate to reflect that change.
Since removing the context pointer makes SVGTextLayoutAttributes a simple
wrapper around a SVGCharacterDataMap, just store the latter directly.
Rename SVGTextLayoutAttributes.h to SVGCharacterData.h
Also replace a HashMap::find+conditional copy with a HashMap::get.

BUG=607906
==========

to

==========
Remove the LayoutSVGInlineText* context in SVGTextLayoutAttributes

Most uses of the SVGTextLayoutAttributes* in vector owned by
LayoutSVGText, actually ends up doing ...->context() and dereferencing
the owning LayoutSVGInlineText rather than the attributes object itself.
It's also slightly more obvious what's going on when considering the
iteration over "text nodes" rather than their associated attributes.
Make LayoutSVGText collect the descendant LayoutSVGInlineTexts rather
than the "parts object" SVGTextLayoutAttributes, and rename as
appropriate to reflect that change.
Since removing the context pointer makes SVGTextLayoutAttributes a simple
wrapper around a SVGCharacterDataMap, just store the latter directly.
Rename SVGTextLayoutAttributes.h to SVGCharacterData.h
Also replace a HashMap::find+conditional copy with a HashMap::get.

BUG=607906

Committed: https://crrev.com/62d08faa9793d36f12b0844cdbcdbcec6a6526b9
Cr-Commit-Position: refs/heads/master@{#391052}
==========

[commit-bot: I haz the power, 2016-05-02 21:24:08]

Patchset 1 (id:??) landed as
https://crrev.com/62d08faa9793d36f12b0844cdbcdbcec6a6526b9
Cr-Commit-Position: refs/heads/master@{#391052}